From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EF5ACA2E8D
	for <public@inbox.dpdk.org>; Thu,  5 Sep 2019 18:38:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DA0421F057;
	Thu,  5 Sep 2019 18:38:35 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 109831F03B
 for <dev@dpdk.org>; Thu,  5 Sep 2019 18:38:35 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5D30614005C;
 Thu,  5 Sep 2019 16:38:33 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Sep 2019
 17:38:27 +0100
To: Stephen Hemminger <stephen@networkplumber.org>
CC: Gaetan Rivet <gaetan.rivet@6wind.com>, <dev@dpdk.org>, Ivan Ilchenko
 <Ivan.Ilchenko@oktetlabs.ru>
References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com>
 <1567699852-31693-3-git-send-email-arybchenko@solarflare.com>
 <20190905093615.2c3bbb57@hermes.lan>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <e2f541d3-af58-3aca-fe73-ebd8d0fa6b38@solarflare.com>
Date: Thu, 5 Sep 2019 19:38:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190905093615.2c3bbb57@hermes.lan>
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24890.003
X-TM-AS-Result: No-2.106400-8.000000-10
X-TMASE-MatchedRID: zGP2F0O7j/u8rRvefcjeTfZvT2zYoYOwC/ExpXrHizxXiLrvhpKLfPZX
 3O8Q80boivLWT922y245K8+bF5qeVFtNf1tGHBMOGfTCsR61MuF8yGO3dvk8/VcbfIj2Ta9sP84
 r9LuHKWGNKIBh68PaAWuRi/mMYtyx6BQEtCkk8tIvj6wHfIGxySPx0viUmdeu4WwrKBT2nJ15RA
 29TjvO6DU3HPhRrRy9/76CM4Z/MGblRxm3A2wKujl/1fD/GopdcmfM3DjaQLHZs3HUcS/scHyLg
 dUOAwVfC0DOY+/Bugy+Fmc7jKyHFMyUhnvx6+GyOOUHWPqJiiKH9aAHVv6wWAsVkPYsdOUhjLh5
 j4R96fYokvJJwzQ9hq8IAE7Q6Ar/pEklrZMvsFPAv/l3gdbrzhvm0GY3HbFik6F64SjxN7gdC6T
 O6gQR33puGb8jWxwuHGPJ69mvh0H2+sXgGMniE2wbVcbPPaOfftwZ3X11IV0=
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--2.106400-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24890.003
X-MDID: 1567701514-g6GElYAeT4m9
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of
 promiscuous mode switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/5/19 7:36 PM, Stephen Hemminger wrote:
> On Thu, 5 Sep 2019 17:10:40 +0100
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
>> +		if (ret != 0) {
>> +			ERROR("Failed to apply promiscuous mode");
>> +			return ret;
>> +		}
> Just return the error as normal and let caller deal with it.
> Additional logging is not necessary.

In this particular case we simply follow style around.
No strong opinion. Up to Gaetan.