From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 118577D34 for ; Thu, 18 Oct 2018 10:33:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 01:33:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,395,1534834800"; d="scan'208";a="272325995" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 18 Oct 2018 01:33:42 -0700 To: Raslan Darawsheh , "Iremonger, Bernard" , "Wu, Jingjing" Cc: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , "Xueming(Steven) Li" , Ori Kam , "jerin.jacob@caviumnetworks.com" , "david.marchand@6wind.com" References: <1538897848-1693-1-git-send-email-rasland@mellanox.com> <1539789731-18409-1-git-send-email-rasland@mellanox.com> <1539789731-18409-3-git-send-email-rasland@mellanox.com> <8CEF83825BEC744B83065625E567D7C260D1292F@IRSMSX107.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLzsFNBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABwsF8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Thu, 18 Oct 2018 09:33:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 08:33:46 -0000 On 10/18/2018 9:19 AM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, October 17, 2018 7:33 PM >> To: Iremonger, Bernard ; Raslan Darawsheh >> ; Wu, Jingjing >> Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf >> Shuler ; Xueming(Steven) Li >> ; Ori Kam ; >> jerin.jacob@caviumnetworks.com; david.marchand@6wind.com >> Subject: Re: [PATCH v6 3/3] app/testpmd: set packet dump based on >> verbosity level >> >> On 10/17/2018 5:24 PM, Iremonger, Bernard wrote: >>> Hi Raslan, >>> >>>> -----Original Message----- >>>> From: Raslan Darawsheh [mailto:rasland@mellanox.com] >>>> Sent: Wednesday, October 17, 2018 4:22 PM >>>> To: Wu, Jingjing >>>> Cc: thomas@monjalon.net; dev@dpdk.org; shahafs@mellanox.com; >>>> rasland@mellanox.com; xuemingl@mellanox.com; orika@mellanox.com; >>>> jerin.jacob@caviumnetworks.com; david.marchand@6wind.com; >> Iremonger, >>>> Bernard ; Yigit, Ferruh >>>> >>>> Subject: [PATCH v6 3/3] app/testpmd: set packet dump based on >>>> verbosity level >>>> >>>> when changing verbosity level it will configure rx/tx callbacks to >>>> dump packets based on the verbosity value as following: >>>> 1- dump only received packets: >>>> testpmd> set verbose 1 >>>> 2- dump only sent packets: >>>> testpmd> set verbose 2 >>>> 3- dump sent and received packets: >>>> testpmd> set verbose (any number > 2) >>>> 4- disable dump >>>> testpmd> set verbose 0 >>>> >>>> Signed-off-by: Raslan Darawsheh >>>> Acked-by: Bernard Iremonger >>>> >>>> --- >>>> changes in v6: >>>> add documentation for the packet dump >>>> --- >>>> --- >>>> app/test-pmd/config.c | 25 +++++++++++++++++++++++++ >>>> app/test-pmd/testpmd.c | 4 ++-- >>>> app/test-pmd/testpmd.h | 1 + >>>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++++- >>>> 4 files changed, 33 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >>>> 55fec7f..1696623 100644 >>>> --- a/app/test-pmd/config.c >>>> +++ b/app/test-pmd/config.c >>>> @@ -50,6 +50,7 @@ >>>> #endif >>>> #include >>>> #include >>>> +#include >>>> >>>> #include "testpmd.h" >>>> >>>> @@ -2773,11 +2774,35 @@ remove_tx_dump_callbacks(portid_t portid) >> } >>>> >>>> void >>>> +configure_rxtx_dump_callbacks(uint16_t verbose) { >>>> + portid_t portid; >>>> + >>>> +#ifndef RTE_ETHDEV_RXTX_CALLBACKS >>>> + TESTPMD_LOG(ERR, "setting rxtx callbacks is not >> enabled\n"); >>>> + return; >>>> +#endif >>>> + >>>> + RTE_ETH_FOREACH_DEV(portid) >>>> + { >>>> + if (verbose == 1 || verbose > 2) >>>> + add_rx_dump_callbacks(portid); >>>> + else >>>> + remove_rx_dump_callbacks(portid); >>>> + if (verbose >= 2) >>>> + add_tx_dump_callbacks(portid); >>>> + else >>>> + remove_tx_dump_callbacks(portid); >>>> + } >>>> +} >>>> + >>>> +void >>>> set_verbose_level(uint16_t vb_level) { >>>> printf("Change verbose level from %u to %u\n", >>>> (unsigned int) verbose_level, (unsigned int) vb_level); >>>> verbose_level = vb_level; >>>> + configure_rxtx_dump_callbacks(verbose_level); >>>> } >>>> >>>> void >>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>>> 5dbbf78..3c42924 100644 >>>> --- a/app/test-pmd/testpmd.c >>>> +++ b/app/test-pmd/testpmd.c >>>> @@ -1988,7 +1988,7 @@ start_port(portid_t pid) >>>> return -1; >>>> } >>>> } >>>> - >>>> + configure_rxtx_dump_callbacks(0); >>>> printf("Configuring Port %d (socket %u)\n", pi, >>>> port->socket_id); >>>> /* configure port */ >>>> @@ -2087,7 +2087,7 @@ start_port(portid_t pid) >>>> return -1; >>>> } >>>> } >>>> - >>>> + configure_rxtx_dump_callbacks(verbose_level); >>>> /* start port */ >>>> if (rte_eth_dev_start(pi) < 0) { >>>> printf("Fail to start port %d\n", pi); diff --git >> a/app/test- >>>> pmd/testpmd.h b/app/test-pmd/testpmd.h index c07bee8..3da728c >> 100644 >>>> --- a/app/test-pmd/testpmd.h >>>> +++ b/app/test-pmd/testpmd.h >>>> @@ -777,6 +777,7 @@ void add_rx_dump_callbacks(portid_t portid); >>>> void remove_rx_dump_callbacks(portid_t portid); void >>>> add_tx_dump_callbacks(portid_t portid); void >>>> remove_tx_dump_callbacks(portid_t portid); >>>> +void configure_rxtx_dump_callbacks(uint16_t verbose); >>>> >>>> /* >>>> * Work-around of a compilation error with ICC on invocations of the >>>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>>> index ca060e1..60855c6 100644 >>>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>>> @@ -449,7 +449,11 @@ Set the debug verbosity level:: >>>> >>>> testpmd> set verbose (level) >>>> >>>> -Currently the only available levels are 0 (silent except for error) >>>> and 1 (fully verbose). >>>> +Available levels are as following: >>>> +* ``0`` silent except for error. >>>> +* ``1`` fully verbose except for Tx packets. >>>> +* ``2`` fully verbose except for Rx packets. >>>> +* ``> 2`` fully verbose. >>>> >>> >>> The html output is probably not what you intended: >>> >>> Available levels are as following: * 0 silent except for error. * 1 fully verbose >> except for Tx packets. * 2 fully verbose except for Rx packets. * > 2 fully >> verbose. >>> >>> A blank line is needed between each line. >> >> You a right, output is broken. I updated in the tree, just one blank line before >> list seems did the work. >> Raslan can you please confirm the latest doc in the tree? > > I see it's merged in dpdk-next/master but, it doesn't have the missing blank lines. In repo it is: " Available levels are as following: * ``0`` silent except for error. * ``1`` fully verbose except for Tx packets. * ``2`` fully verbose except for Rx packets. * ``> 2`` fully verbose. " In original patch: " +Available levels are as following: +* ``0`` silent except for error. +* ``1`` fully verbose except for Tx packets. +* ``2`` fully verbose except for Rx packets. +* ``> 2`` fully verbose. " Please, compile both and observe the difference. > >> >>> >>>> set log >>>> ~~~~~~~ >>>> -- >>>> 2.7.4 >>> >>> Regards, >>> >>> Bernard. >>> >>> > > > Kindest regards, > Raslan Darawsheh >