From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8057E2C8 for ; Thu, 6 Jul 2017 15:26:50 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 06:26:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,317,1496127600"; d="scan'208";a="105142516" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.55]) ([10.237.221.55]) by orsmga004.jf.intel.com with ESMTP; 06 Jul 2017 06:26:48 -0700 To: Jerin Jacob References: <1498751388-41571-2-git-send-email-david.hunt@intel.com> <1498830673-56759-1-git-send-email-david.hunt@intel.com> <1498830673-56759-2-git-send-email-david.hunt@intel.com> <20170703035755.GA6275@jerin> <25452a77-c5ae-97e8-b41a-5dfcb9fb19a6@intel.com> <20170705052853.GA8031@jerin> <20170706033120.GA10973@jerin> <7987361f-935e-a689-103d-276fe3a4c36e@intel.com> Cc: dev@dpdk.org, harry.van.haaren@intel.com, Gage Eads , Bruce Richardson From: "Hunt, David" Message-ID: Date: Thu, 6 Jul 2017 14:26:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <7987361f-935e-a689-103d-276fe3a4c36e@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] examples/eventdev_pipeline: added sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 13:26:51 -0000 Hi Jerin, On 6/7/2017 11:04 AM, Hunt, David wrote: > > On 6/7/2017 4:31 AM, Jerin Jacob wrote: >> -----Original Message----- >>> --snip-- >> I checked v7 it looks to OK to merge. Can you fix following minor >> issue with >> check patch and check-git-log.sh >> >> check-git-log.sh >> ----------------- >> Wrong headline lowercase: >> doc: add sw eventdev pipeline to sample app ug > > Will Do. Change sw to SW > >> ### examples/eventdev_pipeline: added sample app > > Will Do. Add _sw_pmd > Both of these will be in next patch. >> Note: >> Change application to new name. >> >> checkpatch.sh >> ----------------- >> >> WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to >> using 'consumer', this function's name, in a string >> #294: FILE: examples/eventdev_pipeline_sw_pmd/main.c:178: >> + printf("# consumer RX=%"PRIu64", time %"PRIu64 "ms, " >> >> WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to >> using 'worker', this function's name, in a string >> #453: FILE: examples/eventdev_pipeline_sw_pmd/main.c:337: >> + printf(" worker %u thread done. RX=%zu TX=%zu\n", >> >> total: 0 errors, 2 warnings, 1078 lines checked > > These are false positives. The text in the messages are not meant to > be the function name. > If anything, I would prefer to change the function names to have " > _thread"? > Having looked at this a bit more, and unable to reproduce with my original kernel version checkpatch, and the patchwork version does not show, and the 4.11.9 stable kernel version does not show, I suggest we mark these down as false positives, as the string is not intended to show the function name. >> I will give pull request Thomas on Friday morning. I will include >> this change set >> in the pull request. >> >> Regarding the performance drop, Can you add __rte_cache_aligned on those >> variable which creates regression in moving to rte_malloc area. The >> cache line could be shared? If not fixing then its fine we will look >> into that latter. > > I will investigate and post a new patch in a few hours. > Of the 4 variables I am attempting to move into fastpath structure, no matter whether I move them one at a time or all at once, with __rte_cache_align or not, I still see a significant performance degradation. I suggest looking into this later. I will push a patch in the next couple of hours with the first two changes mentioned above. OK with you? Regards, Dave.