From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 481D7A00C5; Tue, 7 Jul 2020 00:47:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19D721DBD4; Tue, 7 Jul 2020 00:47:40 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 45B1D1D9A2 for ; Tue, 7 Jul 2020 00:47:38 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id D640F5800D8; Mon, 6 Jul 2020 18:47:37 -0400 (EDT) Received: from imap4 ([10.202.2.54]) by compute7.internal (MEProxy); Mon, 06 Jul 2020 18:47:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm1; bh=r1F3+ edTLKwYlarZ8B1mGRPHHgIdEF2sY1HRrZZez+Q=; b=F0Tg8su/6oDfetoQkZU3P 3JXOSmB2kOJT0eGAcVoGM5AS8K9r72Xbmkok6bM3DCOTpNnLEIPELcuuRJ4FrJ6J j2fnX+v10JPuMDCuDi7NMkn5gho9OwAZdqY0qcWLTZ8NJ4BOtFgMJ7+Oj2W8joAb ldQhFA5AGBu96cyEoE0GMIhrhO7Rq0u7piYnxal0HC1bZnr5oN2DiAYvdKlvnEln ppfN7WRHhK7XSWklkCZji0mu38XsrdIy0ROxI8dUU6L08EPTqGCTjG/ZH7DGVjCd QMee+oiJ9L613ZZEYBhRwRAlxDZACQ5i0vSAFiRHfZQ3L3D5fO1oCfQ8lamAbLV2 g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=r1F3+edTLKwYlarZ8B1mGRPHHgIdEF2sY1HRrZZez +Q=; b=q6Cbci6LXtTzWIYQ/R+KMn5C33PR5+pKtxVKxIMzmlztpAbR0vW4r87KP IIZJs3qRvj1dPvBQVRrO6HyECYHYhu+8ozCHHzhNFdnJEgOExoNuFB+1G5RONFGE ve3tCPtxHYZX6sV1Lx+K2gzljs8ew8U0CzCsilZ5rlRd9hq2InsQEHeQvnktJK3K oRLliCIJK0rUvVCcwuG+n5FAdMYbUyYjXSdhzTfc3c+sQy9pQetgYvYvvrS3mSAS 4XS9dVDa9+KJWvDQhb0iEmspI59DKNYJnUNOgi1ewwelG3Wz3bp2wEVNT7grbxv7 1EKXWnKagJpnDkOuwjvICET3495kA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeggdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdfvhhho mhgrshcuofhonhhjrghlohhnfdcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqe enucggtffrrghtthgvrhhnpeevhfegkedutdekvddvudejueefudduleetheekhfdvheeg teelffetkeejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 01FE93C00A1; Mon, 6 Jul 2020 18:47:33 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-576-gfe2cd66-fm-20200629.001-gfe2cd668 Mime-Version: 1.0 Message-Id: In-Reply-To: <1593941027-86651-2-git-send-email-orika@mellanox.com> References: <1593941027-86651-1-git-send-email-orika@mellanox.com> <1593941027-86651-2-git-send-email-orika@mellanox.com> Date: Tue, 07 Jul 2020 00:47:11 +0200 From: "Thomas Monjalon" To: "Ori Kam" , "Jerin Jacob Kollanukkaran" , xiang.w.wang@intel.com, matan@mellanox.com, viacheslavo@mellanox.com, "Shahaf Shuler" , "Ray Kinsella" , "Neil Horman" Cc: guyk@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, "Hemant Agrawal" , opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, "Richardson, Bruce" , yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, "Jim Thompson" , hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, rasland@mellanox.com, "Yuval Avnery" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] =?utf-8?q?=5BPATCH_01/20=5D_regex/mlx5=3A_add_RegEx_PM?= =?utf-8?q?D_layer_and_mlx5=09driver?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Dim 05 juil 2020, =C3=A0 11:23, Ori Kam a =C3=A9crit=E2=80=AF: > +++ b/drivers/regex/mlx5/Makefile > +# memseg walk is not part of stable API > +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API Not needed > +# DEBUG which is usually provided on the command-line may enable > +# CONFIG_RTE_LIBRTE_MLX5_DEBUG. > +ifeq ($(DEBUG),1) > +CONFIG_RTE_LIBRTE_MLX5_DEBUG :=3D y > +endif I think you would prefer a regex specific flag. In near future, we'll try to convert these debug flags to something more= common or something more dynamic like tracing. > +# User-defined CFLAGS. > +ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y) > +CFLAGS +=3D -pedantic -UNDEBUG > +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) > +CFLAGS +=3D -DPEDANTIC > +endif > +AUTO_CONFIG_CFLAGS +=3D -Wno-pedantic > +else > +CFLAGS +=3D -DNDEBUG -UPEDANTIC > +endif Please give up with pedantic compilation.