From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1D6672BB1 for ; Wed, 7 Nov 2018 08:30:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 23:30:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,474,1534834800"; d="scan'208";a="106576941" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.85]) ([10.67.68.85]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2018 23:30:21 -0800 To: Matan Azrad , "konstantin.ananyev@intel.com" , "anatoly.burakov@intel.com" , Thomas Monjalon , "bernard.iremonger@intel.com" , "jingjing.wu@intel.com" , "wenzhuo.lu@intel.com" Cc: "ferruh.yigit@intel.com" , "dev@dpdk.org" , "helin.zhang@intel.com" , "shaopeng.he@intel.com" References: <1541484436-91320-1-git-send-email-jia.guo@intel.com> <1541484436-91320-4-git-send-email-jia.guo@intel.com> From: Jeff Guo Message-ID: Date: Wed, 7 Nov 2018 15:30:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for hot-unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 07:30:25 -0000 matan On 11/6/2018 2:36 PM, Matan Azrad wrote: > Hi Jeff > > From: Jeff Guo >> Before detach device when device be hot-unplugged, the failure process in >> user space and kernel space both need to be finished, such as eal interrupt >> callback need to be inactive before the callback be unregistered when device >> is being cleaned. This patch add rte alarm for device detaching, with that it >> could finish interrupt callback soon and give time to let the failure process >> done before detaching. >> >> Fixes: 2049c5113fe8 ("app/testpmd: use hotplug failure handler") >> Signed-off-by: Jeff Guo >> --- >> app/test-pmd/testpmd.c | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >> 9c0edca..9c673cf 100644 >> --- a/app/test-pmd/testpmd.c >> +++ b/app/test-pmd/testpmd.c >> @@ -2620,7 +2620,18 @@ eth_dev_event_callback(const char >> *device_name, enum rte_dev_event_type type, >> device_name); >> return; >> } >> - rmv_event_callback((void *)(intptr_t)port_id); >> + /* >> + * Before detach device, the hot-unplug failure process in >> + * user space and kernel space both need to be finished, >> + * such as eal interrupt callback need to be inactive before >> + * the callback be unregistered when device is being cleaned. >> + * So finished interrupt callback soon here and give time to >> + * let the work done before detaching. >> + */ >> + if (rte_eal_alarm_set(100000, >> + rmv_event_callback, (void >> *)(intptr_t)port_id)) >> + RTE_LOG(ERR, EAL, >> + "Could not set up deferred device > > It looks me strange to use callback and alarm to remove a device: > Why not to use callback and that is it? > > I think that it's better to let the EAL to detach the device after all the callbacks were done and not to do it by the user callback. > So the application\callback owners just need to clean its resources with understanding that after the callback the device(and the callback itself) will be detached by the EAL. Firstly, at the currently framework and solution, such as callback for RTE_ETH_EVENT_INTR_RMV, still need to use the deferred device removal, we tend to give the control of detaching device to the application, and the whole process is located on the user's callback. Notify app to detach device by callback but make it deferred, i think it is fine. Secondly, the vfio is different with igb_uio for hot-unplug, it register/unregister hotplug interrupt callback for each device, so need to make  the callback done before unregister the callback. So I think it should be considerate as an workaround here, before we find a better way. > >> removal\n"); >> break; >> case RTE_DEV_EVENT_ADD: >> RTE_LOG(ERR, EAL, "The device: %s has been added!\n", >> -- >> 2.7.4