Re: [dpdk-dev] [PATCH v7 00/15] common linkstatus functions

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/22/2018 11:54 PM, Stephen Hemminger wrote:
> While reviewing drivers, noticed a lot of unnecessary
> duplication of code in drivers for handling the eth_dev link status
> information. While consolidating this, it also became obvious that
> some drivers behave differently for no good reason.
> 
> It also was a good chance to introduce atomic exchange primitives
> in EAL because there are other places using cmpset where not
> necessary (such as bonding).
> 
> Mostly only compile tested only, don't have all of the hardware
> available (except ixgbe and virtio) to test.
> 
> 
> v7
>   - add exchange functions for PPC64
>   - move linkstatus helpers to rte_ethdev_driver
>   - rebase to 18.02
> 
> 
> 
> Stephen Hemminger (15):
>   eal: introduce atomic exchange operation
>   ethdev: add linkstatus get/set helper functions
>   net/virtio: use eth_linkstatus_set
>   net/vmxnet3: use rte_eth_linkstatus_set
>   net/dpaa2: use rte_eth_linkstatus_set
>   net/nfp: use rte_eth_linkstatus functions
>   net/e1000: use rte_eth_linkstatus helpers
>   net/ixgbe: use rte_eth_linkstatus functions
>   net/sfc: use new rte_eth_linkstatus functions
>   net/i40e: use rte_eth_linkstatus functions
>   net/liquidio: use rte_eth_linkstatus_set
>   net/thunderx: use rte_eth_linkstatus_set
>   net/szedata: use _rte_eth_linkstatus_set
>   net/octeontx: use rte_eth_linkstatus_set
>   net/enic: use rte_eth_linkstatus_set

This patchset is not able to make rc1, I am for postponing it to next release
instead of getting in later rc.

It is good to have eal atomic exchange APIs and it is good that some duplicated
code removed from APIs but I think it would be better to discuss and have a
consensus on what dev_link_update() function should return, and get some acks
from PMD maintainers first.

What do you think?