From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 776D545AA8; Fri, 4 Oct 2024 07:04:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BE314065A; Fri, 4 Oct 2024 07:04:32 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2085.outbound.protection.outlook.com [40.107.93.85]) by mails.dpdk.org (Postfix) with ESMTP id 66EC240268 for <dev@dpdk.org>; Fri, 4 Oct 2024 07:04:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EUAHGEklwCrXvJYK/qJQjSMu0p28KG7UjETLiYGa/5tY0/rFvgUEo/zUd+R3p5x8opD8/I7Duy7GdaSJKNc77aZ615rMRwidsGOrPf9quV6pAPS2nZugelSnw7AzC08UmEizyEDBiLmGpwjKeMWuQUg/rEzGFoPpdt3RzNQdxe9q0bsuveal+dv27+UKRrp7m3gPfMiNWPrQ9HGOtpGwKs10ySoR5XiCyAcdIuZ2Sy+SJFXvflLhrorhBqveocybvTVlAdjNUjKROrQjUtC7rH/ZiarHecAqPid4roDDYJarm5i1GBbK432S7ghq5HBMCowH9AKNrzcfWirFHGZHXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HNhhxy0Ig4jgPViW+sSVWCt3w8KkkX0+c2v+G6ZdcEE=; b=Gq6Z3uy3QJTb7iMvz+L9j1/e8t/U6gc8SeGHzgRunoKK+smAbVctObSkTFfKm8y53RE0eAOCddgmEDOoS0Zt2deYhIcFEUnU5C/WZEOucvYCckRhd3G3nGlvOv8Y62oZ+r1ZJgEAiXMFwgUnU0vNDnneQU+nBQcjH18t6YMUojivYfLqMjTBGrFsTteZYJTjJ0bFnFQuwarSWXRSrnm+CVwPkawFLdGSFuLW94BUNMiBThG7co8rjW1ljo20BUc5gjlqpLzYbJOvDH4OxRWQvJF5FJIWENQrcCaMVqzBWZ9qs8DJs0FLo0xZd8aek5j7XAOaEFEQCw4U3Uw7+Xo6zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNhhxy0Ig4jgPViW+sSVWCt3w8KkkX0+c2v+G6ZdcEE=; b=h+XJWPEvossc/dFzt8i8CtoAfEbVqn46L8JbWIKaomji9hSWYoLIgq38EUmvjhQUNrhCuinJfEMlHNOl4mdtCi/oqIyegm55o+pTSq3ARY7Kouo4afZht3Pn0ZcAWPYE0T4+TQOR4foSEjxtneIARJVpowjN9XpDiTPyiY2uZFc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by DS0PR12MB8317.namprd12.prod.outlook.com (2603:10b6:8:f4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18; Fri, 4 Oct 2024 05:04:28 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 05:04:28 +0000 Message-ID: <e3ad6477-9899-4b6a-a817-98e06dc2b363@amd.com> Date: Fri, 4 Oct 2024 06:04:22 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] app/testpmd: add register keyword To: "Varghese, Vipin" <Vipin.Varghese@amd.com>, Konstantin Ananyev <konstantin.ananyev@huawei.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>, "aman.deep.singh@intel.com" <aman.deep.singh@intel.com>, "dev@dpdk.org" <dev@dpdk.org> References: <20240716063724.850-1-vipin.varghese@amd.com> <20240821143857.1972-1-vipin.varghese@amd.com> <20240821143857.1972-2-vipin.varghese@amd.com> <20240821075502.3faa0997@hermes.local> <f68c361b-0f3f-4ec4-ab78-79b3ac921aee@amd.com> <20240827103924.1d1d2711@hermes.local> <0ae233fb72ce49cea5186e1f924db76b@huawei.com> <PH7PR12MB859639DA1EDC9494B9703817829E2@PH7PR12MB8596.namprd12.prod.outlook.com> Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <PH7PR12MB859639DA1EDC9494B9703817829E2@PH7PR12MB8596.namprd12.prod.outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0205.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::25) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|DS0PR12MB8317:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f550a1c-c4c0-4d4e-b34b-08dce432063e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OVlMT2xkcklMVHc1Q0ZkMjkwWFhxR1ZGTWY4Yk5tbkVzb1dWR2IvWG5nVGs3?= =?utf-8?B?ekM2N1FrM1RSbXhQd1dFeWh4bytvWWVlRkFlSTJVb3BnTlYwUUhlSW5peHFI?= =?utf-8?B?bm5JeFM4YjFYTTZ3RnNvUUdzZGVSQnhhd0dnQ0FlVmtqQ0MyeEx6V3EvY2FR?= =?utf-8?B?Rm5MNHZveVJva3B3QmtNOXJRYUdYT0JRWmFnbXVnTGNDQUIxMmRnOUpNQ3BM?= =?utf-8?B?WEF0aHcveCsxMld0ZjhaYUhOOXlFUEpBSHBCSjRLR2JpNTdFbFRYZTNYSFFZ?= =?utf-8?B?ZVZHeTRzWG8zSzdjVUt3K2JoSGNoWDloWlN5L3p1QmplV0VkMTZCL1dqa0VO?= =?utf-8?B?eFRjUmVBWXZNcElYUXRhVFRkNlhwSkI1Nld3NktlRmY4bURCRXlCZ0VWL0dP?= =?utf-8?B?Z2tCMjVBckZtVGUzaHNmSjcyWW1TVExseGREanRrTnJ4MUo1Z0FtT3dYd3Vi?= =?utf-8?B?bE9FYzFZOUdTdkw3bTVLbERLUWVhbHBWcnl1SDc5RDAvY0IyaFNSVENFQSta?= =?utf-8?B?bm9XQUo1ckJYLzl3OWp6c2tMR2RGeERKUHRSQzFZWkpRYTRYZVgram40OVo2?= =?utf-8?B?OEduck5LVmVOb1dDOXhIb01wL3VtZFBwM3NpaEloM2IyVktFVmVtbHFhM2VD?= =?utf-8?B?OVc4YWg1b0pjaWxVUnhsa0g4OC96NTRFK2NkVjdSQUlXVnZNejlrOVE1QVcy?= =?utf-8?B?QzF4WUpVeFRyRTZsY3I4ZjdzWDdpQU4xSTB6cEdodkhUYUlpVUJGWHBLUk9u?= =?utf-8?B?dGxVNGpmOU8zMUdqVXNOOW1POWllSndUc0dhL2Y0VGZtYnJLb3JSa3JpTHFy?= =?utf-8?B?RC9iU0tTaUMvcUMvNk5EWGpVSFVVU1FmWFcyc3RMV0dWWW5FWFdmTEpvemxO?= =?utf-8?B?dW1oNklvRDBqQkpzemxoK2dlb2l6YkgvM1FNVksxWFNuUHRiMlNUdXJZQW9s?= =?utf-8?B?eUY5RHI3ZWpJQ3pMYittNUpFN25xdVFSZko3MWFBUEFZY3htN3Zjc0MyQnFv?= =?utf-8?B?NDhBTHJMK0RLZFZmL2ZhL003RWNsSlZVclUrdHEvWWNyYUx2ZXpROWpGM1FW?= =?utf-8?B?Nktid2ZCOXBDM2VaNG80TFZ4OTBuNzlYSzZMZzRpWW1pc3cxN3cxNFQ3TTdH?= =?utf-8?B?bXNRTmR6TUdlczNlTW91djllR3dET2NsRUtzeHhzVXpXalRHY3ZpQy9Zck5p?= =?utf-8?B?Y0dxRkJ4Ylg5ZmJOTjFIY05jYjVnVTNMYWlucGtzc1Fzb3RUS0RYb05IcHlo?= =?utf-8?B?eCtIOGhEczhHaEdJLy9ocEVURkFJQVlhR3JndE5lWHdFQ3pGUmZBK01qNjV4?= =?utf-8?B?YlB0UWVtRVVsZHAzcDVOMDRPRitJUFlMT3A3NGtVaDlPdjM5SXhKOVQ3QlJi?= =?utf-8?B?VmtEWDFMMnZRQ3dsUGNDZ2xQSDNZMGNqd2txaFAyWFdKbFJSV3dmZ0RZZFZQ?= =?utf-8?B?Yll2dFVPNUhvTDh4R3FPdVNzZ2Y2QXpQdkNZQkhoMzVscDNoaXVDWkJsY0ta?= =?utf-8?B?VHJEOVY4NlQyZlFibmZlaldPYzZKL3B0N1hWWk4zQTRodUprVjhoMjBwSWR1?= =?utf-8?B?cWswWTRlUDVPN2VUKzJtRWZuMzhVNUErTnJDVkdxWjN3SVdNTjNQM2I5cmRa?= =?utf-8?B?eUxYYlU2TjBYeTJsN29CL04weXF6UloyaW5oVnY5Ym41QkZySXZMVkRGZ2dS?= =?utf-8?B?R3FoZHdzekVjM1g2YWJlelJ0dCswMGZNTURxZnBEY1gwZTgydEozQTJ3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVIT2JDeEhzY1hpa1dRODNKNUw5UXVUK0dDZXJndTFLdDVqbW1UNlloQ2hj?= =?utf-8?B?eVh1UCtwRzc2UXVkb1NPTEJjVnFTdkY0eGdTYkRzbHo5V2ozaTJvUjRQMElm?= =?utf-8?B?di8yZzVXOFFxby9ockhMeC9oZXlVMXhOZ3ZrMUl6YjJBc1YxTHNTMGw2YU1r?= =?utf-8?B?Rm52NjZTNTE1Ry9rM2sxenN1dHdiTlpmakxGS1pUMWo3VHZoWm1HNnZmVmp0?= =?utf-8?B?WThtNFBhbko0SEJxWmlMSEpTa2ZwV2g3b1dZMTZlclVrdlh5eDEzeG1CMVp5?= =?utf-8?B?a2sxSVBnbWZ2RFRYaG4zWlgxSkFnNVdJS2R1S3Z5R0h5bDJvMmFXUzNuc1B5?= =?utf-8?B?c1FWZWcxM3E4Z2FLWjRQbXNQQVRjaU1QQ2JYcjdoVXdUWHc2c09MMTBxVnRO?= =?utf-8?B?VUxuZktUa2tRUHgwY0E2L2VOQmRGaUxaRUdCWWxBZ1VTNDhoY1dodDRNY3B5?= =?utf-8?B?SVRiUmk2OXV6cVovV2Q4T016KzNhMzZDcy93ZFRwVVRrR05wVGdTVVFrYkZU?= =?utf-8?B?UEQ1cDZOT05sRUxZTEVnN1k0bG1QbmJ6cHBqKzhZMFkrdVo5ZndUTGNMR1Vx?= =?utf-8?B?SjFXZE93RTZPWHhiUVJRdTNOaGRmMURGcVEwODBxQkliZzc4ODA4QzVvcGQ3?= =?utf-8?B?Z3VMZmI2OXhaWEhEZDhuUjFlZnZTM0taRmM2clZjY2hyTkdQVEs0Wk9jeUVS?= =?utf-8?B?S3owaGQyTjA0aUpJeUIvNktWY2RDNEQ5VHVvQXh5eXZHa0I2YXE4UDVJUWsy?= =?utf-8?B?ZTd5VjFpZlV1bVVzOTVRU3A2WkE5UXdSbjY1KzdlaVVrWmRQd3R6bzYvSStu?= =?utf-8?B?MDBpRU1UV2xxUWZ5dURFTU85MnlwRzFITWt1V093c2RadlVUNzFwWGtVWWh3?= =?utf-8?B?MVYxeEQ2RE9CblJmY2ZtVHRya3NsamJuY1VSaSs3ZHRNa2t2V2Frc3RtVVha?= =?utf-8?B?RWkxSTVNQVFleTljazJzc0phaTJjdU5Mcnh3a0pSYjlmVGZiUEdEQnl5dnJi?= =?utf-8?B?TGl5VThBbTl5VUhsN1pEYU1kckRZaEd4eWlWRjFDQ0YvV05rMDZxVTRjYlhB?= =?utf-8?B?aldldTY5S0s3aG9yYmtXZjhDeTNta1FWMmdzVGF3TkljYUYybVVkYWtCd2NW?= =?utf-8?B?c1E2MVFpRGRmMmZxVHFERldjUmdmU1VQUnBRTVBaZTJUQjVDcHhndjFYdHFG?= =?utf-8?B?L1Q3K3dpSk1xOW84RE04a1gycCtoSkJBdENqK2RkczZHenhmNzRMaGtQVHhH?= =?utf-8?B?dnErYkdhZnM1aS9CTFpYeVU4b2VkWFRnbEd3T0NoK21peno1bUNCMnpxV1BR?= =?utf-8?B?cVcrZlhBaGl6SlRqVXRyZHVZcTJubXBRMDZSbWxXMUE1M0hZdi9HVHpCdC9Z?= =?utf-8?B?aHRnVlE0SHJuTGQrQTFRM0JnVGFOS2xlWGN2bGRuZ1FkTlN3QThTeGJ2RU4x?= =?utf-8?B?UXI1NUNhM250TERvbjNhWXpVU1hWY1djQTVwanJqSXpFTE9mSExyZFNTU1RF?= =?utf-8?B?M3lQczlNT3h4aGpzSXp5Ym45M0ZlcHdZcENMNGh2bmZqNk51NU9OaU80VjVp?= =?utf-8?B?T09ud2dFQU9EQUJiYUwyY1pkN2tISTFJazZ0SkQ2enhoalYyWCtUTG5OSGsz?= =?utf-8?B?dkpmak5JWFdTUUU3YkdseEZnSlVlWndaWjhzZDQxYzNDRlZKNjVPcFFoS2xJ?= =?utf-8?B?VS93c0QxRFBGb2lBN1lGK1lsRkNKY1pUeUN3NnZZaFJMeEFaV3NhM0xhQ2Zs?= =?utf-8?B?WTFJVk8zdDRhRCtVTGtISVpENFNWTmxldllESUhoWHpPTTFSd1F5UmVOVzhO?= =?utf-8?B?MktubGxHYnEzOGJSQUF4cXhra2pxazdQd1dlNVJHSnJ1R0ZnZWFjVTBvWDE3?= =?utf-8?B?WHJYaTBKQ0tPdUQvakk3U1gzcHpST2psNFlzNmpoNTRWRVZLcHNScXNrUVBr?= =?utf-8?B?cy81ZVdkMSt5aThKSHlHSDAvQTFXSnd2RmNOMkxDUGNjTVJOWUFxc2pHeWw2?= =?utf-8?B?OXFxTmZBRW1IUnljNEdwNWE5amhyUWFtaXVmdnV1aml0b0hkUjQ4Ui9XdTgw?= =?utf-8?B?TktMNHIvTUsxSWlMZnBLVDN3Uk1LT0dBS0NrRnFGSHY1ZENONFo1VXIvbHU3?= =?utf-8?Q?2GVBGVnnfudqzkLYlEPsFvEfF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f550a1c-c4c0-4d4e-b34b-08dce432063e X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 05:04:28.6429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xdgJDXNq9O1FDIAZMwRCuk0lJP2xTuiy1woCTHMk2efBCHV3tMXMQq6ob1rTG/bN X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8317 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 9/6/2024 2:02 PM, Varghese, Vipin wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > <snipped> > >> > > >> --- a/app/test-pmd/macswap_sse.h >> > > >> +++ b/app/test-pmd/macswap_sse.h >> > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t >> nb, >> > > >> uint64_t ol_flags; >> > > >> int i; >> > > >> int r; >> > > >> - __m128i addr0, addr1, addr2, addr3; >> > > >> + register __m128i addr0, addr1, addr2, addr3; >> > > > Some compilers treat register as a no-op. Are you sure? Did you check >> with godbolt. >> > > >> > > Thank you Stephen, I have tested the code changes on Linux using GCC >> > > and Clang compiler. >> > > >> > > In both cases in Linux environment, we have seen the the values >> > > loaded onto register `xmm`. >> > > >> > > ``` >> > > registerconst__m128i shfl_msk = _mm_set_epi8(15, 14, 13, 12, 5, 4, >> > > 3, 2, 1, 0, 11, 10, 9, 8, 7, 6); vmovdqaxmm0, xmmwordptr[rip+ >> > > .LCPI0_0] >> >> Yep, that what I would probably expect: one time load before the loop starts, >> right? >> Curious what exactly it would generate then if 'register' keyword is missed? >> BTW, on my box, gcc-11 with '-O3 -msse4.2 ...' I am seeing expected >> behavior without 'register' keyword. >> Is it some particular compiler version that misbehaves? > > Thank you, Konstantin, for this pointer. I have been trying this > understand this a bit more internally. Here are my observations > > 1. shuf simd ISA works on XMM register only. > 2. Any values from variables has to be loaded to `xmm` register before > processing. > 3. when compiled for `-march=native` with compiler not aware (SoC Arch > gcc weights) without patch might have generating with `movzx eax, BYTE > PTR [rbp-48]` > 4. when register keyword is applied for both shufl_mask and addr, the > compiler generates trying to get the variables directly into xmm using ` > vmovdqu (%rsi),%xmm1` > > So, I think you are right, from gcc12.3 and gcc 13.1 which supports `- > march=znver4` this problem will not come. > Hi Konstantin, Stephen, There is no negative impact of adding 'register' keyword, right? At worst it is useless, but Vipin can demonstrate that it has benefit for some cases, so I think OK to get it.