From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7523641D93; Mon, 27 Feb 2023 22:52:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6592940A84; Mon, 27 Feb 2023 22:52:10 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 41A2440A7D for ; Mon, 27 Feb 2023 22:52:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSUw7RDB8rrWGE/iYdUmJKUzq+S7mq/CZelx/PD/Vzw3YdhdLYUuMlS7/VeskyB6DSCjASEoXRH010CqawmFRaGS0h5MXLPqNSnWsF7ftJSRRFPbhG+1oauMnxxu9lFgE8D70xAoO/tZdfJBSUXrhELkHV3+FW2A8WDfI7KJLu1R5WYAnb6B51nA40GRoNwjj8CliHbJmVHEhycqJ4RDhNQbyd7PHCAEJUHKbvC5IcvDeygYpt4kwuytBHz4QJY6uML5l6vvIhpdakfGe4U9KiPWR4CIpJ9GVS5qJPxq3gK0T90vk7M9MJw8pYhvTFCzdbrNRjk/A5XR9IHGMGO9EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8P7wdg+YFkGbejSb8Tifs2Q0mtVdGDYg3VE72mBQmko=; b=HsDr7y7+QKnP4x7FV+cTr3ci4k/M1bjLXbZq2X9HE9x7fX6FFwImHp77bZKJup5DHWDW8S0Lg+CfSaRfXdu8w/E+qvD9dzWWS/C3v/Wsz31xPmzje5RIN+dESgoO4Wz983YSlJmYNp1w+vjwKxsZwMEX/n4j+4pH9cwFVGwISzPfxjCrdJtdg81Rfopqv6UGdt3sNZIJAsglbXVVKekMejr8NgRKHj9ryQLyotx/2l0T4BxGDiyJrbuYiGZwkonndzKXn2Q0TQ+s4Wg7Byn1brrfxb150S5dQO8Q3NoccUbifYaVS+5tOae2kiKTEUO4eiX6raUg4o0A+EoRqAyLig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8P7wdg+YFkGbejSb8Tifs2Q0mtVdGDYg3VE72mBQmko=; b=P4zVgt0RBb1WqCNMONfF/PnA1pk2WRd/0WNO7rbn/8YhzPLLz3NbzJDisD3gF2z9Aqhx9DXqoVCxkK0wLHoM4TM12AW2QMiipZ9GHTX8MWcyUTdQ2Q8xjG8tA8/pAHL3AOi97l9exWwpxqqHA6dGWepZ/dFoiEo9bQOt70l+SE4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB7006.namprd12.prod.outlook.com (2603:10b6:a03:486::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Mon, 27 Feb 2023 21:52:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:52:07 +0000 Message-ID: Date: Mon, 27 Feb 2023 21:52:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com, Bruce Richardson Cc: Wenjun Wu References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-18-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 17/21] net/cpfl: add AVX512 data path for split queue model In-Reply-To: <20230216003010.3439881-18-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0255.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB7006:EE_ X-MS-Office365-Filtering-Correlation-Id: e7e93f67-cac6-49b2-bcbc-08db190cdeb2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FZejFjkdXIl3CwPGuc4rMfaIMqIT4qdHCi5emEvrvVuUKTagEjTRsp2z1GlDiPAiJ7jC3Ji3oC5TsFmJzczPqGxq4PPZwglOrTKxoFrR1C+0nlNK6CncIFyWvnUNSZne8oQ8If9XU361FLSLrFxwtNRfWuijV7sqGUH2BvMt/ncK2/S4dmVIq7sXM8Tqfd0ZkPEtu8gHDspLHnRHRsDSyJ6cXcbmFP3StRo5AdR07exhb0P7F/TM9Qozl8+z/fLYkAyryWzE1BkXkNkaaWshfoRZqzwfr6I9ggNCCzkbR4Hg76HhsG4ay2tooE+HlCJ26CGoobQUNNs779f4qdQnnKcfinqQ5y6AS/qCzn8Nf39BbKgVPxfw3FaELDifq0dvbawm+BFaexvu2VJTJvan+yy364FHPXDZMOt7YmiTW/cBcFq0Gz80NZ1szbof62mL0/WQHZGMIrJdPn89535xW5tFxsdheCkN2Kh3x5272w5kDuIaCA++oEaomXogVAJ70tuCOZhVxq37e15j2d4EXgN4wCYLcWAWCm+wtDVmTQT8cPRmV86KOkXU0LW6z2Fozdm63E7d/XT/n2hB3wHDeatEuRZ45zS2UhfVSt+YtxbWdEQstV5FF/CwPc2lZ3mfyD9aRO8BW51JRH3+U9sQqbOY4p8twGkZVuVU/KOcKXuUyXELIVHkWDSRKsWYlJg1/CsJPix4vr40Gf7WEuU/bRRWrmPcBX2MRmaoc4seupE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199018)(86362001)(66946007)(6486002)(83380400001)(66556008)(5660300002)(110136005)(6506007)(8676002)(66476007)(41300700001)(4326008)(316002)(8936002)(2616005)(53546011)(478600001)(26005)(186003)(6666004)(6512007)(36756003)(2906002)(38100700002)(44832011)(31696002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zy9MQVdCMUl3M0diTW8wdnk5dzZQMzdhTzFITXRreWNwTTBCbmxZdWU3eWJO?= =?utf-8?B?Y0RJSTV2QS9keTJjVDhsWWE2cCtSTWIzb1VUdjlkQ1JraHpBYVBDRTlMT0ZH?= =?utf-8?B?aHQwM2ZSbFN3U0xodmY5eEo4ZDhTZjh1clNXZXVjaE84elRTY3lDN0R3VVV1?= =?utf-8?B?TVFmRG44RHFOcVR5MVdPYnV5bzhQMUVYbVpjVVhBSzR1a09PeUFQUjk5WHJm?= =?utf-8?B?NHpUWkpLYVdFQ1JMMVRVUDlaejc3dXR4U3I4SVZWT1dNZXU5Vzk1TFk1VUZk?= =?utf-8?B?QVdoNmg3Y3h2ZTIyYnZwNWx4V3Q1RjhiRHBibnhZUWF2Y21tbFdSVDNYVElO?= =?utf-8?B?SGlMZmdtOE1ibHNmMWtUNW1rZUlFOU9jY25tSmRXOGdleUN0UkFRa3BETm0v?= =?utf-8?B?bU5GVTJMTkUzM01YLytHeVRhTXZlK2RiNnJlY3FvQ1ZVZjU1RzdXOUJlajhp?= =?utf-8?B?bFAxSGdxVWpUM2xGZFp6S1RPUENOdk90SjJvQUN1a1c1MUxDRFl3OWRDYXp6?= =?utf-8?B?YkNYWjlXQ0JGMDhhWVpJdHdreWtJWnNYSDNWZGlGN0x1aXRwNkh2bjc2aDEw?= =?utf-8?B?WEJpYjNvZmZ3c1V6M1dwamg2Z0dYZm1SUWRhUnlCRHd3MGFrRGJKL3ZhZy9C?= =?utf-8?B?RUltTW9jSmFQYS8remkyWEFiTHVBbGZkNVVlMjhlaUJtaVpwNlV6dkhQUXBP?= =?utf-8?B?alFZcDRia0dGZW1OZ2ZzUmcxdlYzY3VzaFdoa0s0M3lxVFBCUlBhQXQ1TTdt?= =?utf-8?B?clB5Z2U3ZXhuZVNnaVJrYUhXTkt4MDdHd1JDM0lFSGlBQ0dpZENaK0hSaXB3?= =?utf-8?B?aDJkZ3NMTmdKWG02S1lIRVpjZ2c0YlM3SFpWRG1RSHF4NG5sMjJPKzJDaVo5?= =?utf-8?B?ejZhZkFQTXh6ak0zZDFYMi9XTXIxeDR5ZzY0QWRWWFQ1MGZrcTZIRlhBWWlp?= =?utf-8?B?Y29VTzg0K3U5ZFpLR2FXUEhtTzZVejFrNGI2TW5QTGRvcHMrd1NSU2RWcVJl?= =?utf-8?B?amRQam1MbHRVTHVEbE8zbFIzNFRnNUVPYnZOWVJtQThaZ2w0TDhIR2wvQVVw?= =?utf-8?B?U2ZHOERuTmpERlZRQWxvY2FnRG1XVlBmU3lpSk15QW4yNVlOUHRuTHR3VVR4?= =?utf-8?B?MldUMHZ0VG44UHVsYnQ3STc0S2NhMTZZZ1NyWUNIdUZOSFFIR3hadS9FUmh6?= =?utf-8?B?VXBDTlh2alRLYUlvQllpclN1OXZUTzU1ek5kNG05bis1dnUvYytneTlmVnI3?= =?utf-8?B?Lyt4bFF2Z2J6VlR2QVN2MnY3UVpRekdJNWk4aWRZUUV3clQ0MTkzdjBFN1FG?= =?utf-8?B?Zi9CM2tKYnlYK29ZcHo1d0pvMHlacGhKSmN4MytGQ2NrSWpaUUNXd1RabmE4?= =?utf-8?B?c3FoRVdmeVMzVkpMNEVsYis3SDhMdlRRYWUvNUY0NFE1YTNvYkxMTWJzcGpS?= =?utf-8?B?dEYzWGg2cVVMSEFpTDhhcElsTUlYa200V0t3QmQyMG4ra0FTMWdpYmd0d1N3?= =?utf-8?B?NnQ5S05NRFprUEs2cVpGM2FjNTBxSEdhMzdxQVNqZW84Z2RCZlBQaTF5aG5m?= =?utf-8?B?eXdGM2VEaWFFRUVaVEZ0RGxhL3pvSGtXV1M4a1dBQ2ZobUxrRUVsOU1aLzBi?= =?utf-8?B?bTZSR2s3MGtYd2lDZ215VHNLUVpOOHNyV0Zib05XcnhwcXV5QSsvbThJSmds?= =?utf-8?B?aDVtZis5aXMxREcwQzVxUVBIMnV5NGdxT01qNStCM3BFN1pOT1VDUzVEcnF0?= =?utf-8?B?cWlhNG9VS2NQeFpiRUtUYkhTek4xWS9WNzAyUVZSNnJBNnlIaGd6SWozUEEz?= =?utf-8?B?bStJdHRmOVFUQ283WnNMejBFWGpzbU5lQ2UycHNTcldlclhCbXk1RkVDNVla?= =?utf-8?B?MWxDWGVxbkNUeWpXSjRISS9ubnpWNHVUSGNKbEVtZ3V5K3F1ZEhQdGExdXVV?= =?utf-8?B?K0kyeGZQWkQwei9zZnBuNWlmUkR4ZnFKelltLzNlNHFrem96azZaTnJOeVhp?= =?utf-8?B?WU55Rmg5dkRxYWx3S3lFWVdOSE1MUkxoU21IRmhUTmlBRldtN1ZndFlzK1hQ?= =?utf-8?B?RngyZmd3NEZaLy9FdHVkZkIzMG5uelo3TTRKMmtLUTJ3RzVZQm5yU1RGTjRJ?= =?utf-8?Q?CVd/SZVEJEW8Y/hg8uaMr6Bwl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7e93f67-cac6-49b2-bcbc-08db190cdeb2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:52:07.1806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CoEVwGMZFsr6PORzFc3iwzUokPMKCEDt7llJprHvTn02YnQ4VK7d6Y/zhjJWZ3bY X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7006 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add support of AVX512 data path for split queue model. > > Signed-off-by: Wenjun Wu > Signed-off-by: Mingxia Liu <...> > diff --git a/drivers/net/cpfl/meson.build b/drivers/net/cpfl/meson.build > index fbe6500826..2cf69258e2 100644 > --- a/drivers/net/cpfl/meson.build > +++ b/drivers/net/cpfl/meson.build > @@ -23,13 +23,15 @@ sources = files( > if arch_subdir == 'x86' > cpfl_avx512_cpu_support = ( > cc.get_define('__AVX512F__', args: machine_args) != '' and > - cc.get_define('__AVX512BW__', args: machine_args) != '' > + cc.get_define('__AVX512BW__', args: machine_args) != '' and > + cc.get_define('__AVX512DQ__', args: machine_args) != '' > ) > > cpfl_avx512_cc_support = ( > not machine_args.contains('-mno-avx512f') and > cc.has_argument('-mavx512f') and > - cc.has_argument('-mavx512bw') > + cc.has_argument('-mavx512bw') and > + cc.has_argument('-mavx512dq') > ) +Bruce Does it make sense to have a common 'avx512_cc_support' meson function that all required drivers and libraries to use? As it is getting more complex to detect and it is required by multiple components.