From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E584A47CD for ; Mon, 17 Jul 2017 18:20:00 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 577C18006C; Mon, 17 Jul 2017 16:20:00 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx3-us4.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 127E28007F; Mon, 17 Jul 2017 16:20:00 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 940E5600AE; Mon, 17 Jul 2017 16:19:59 +0000 (UTC) Received: from [192.168.239.128] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 17 Jul 2017 17:19:47 +0100 To: Stephen Hemminger CC: References: <20170714183027.16021-1-stephen@networkplumber.org> <20170714183027.16021-10-stephen@networkplumber.org> <60caca67-cfb9-c474-7fa9-faa7752fdaf1@solarflare.com> <20170717090229.48abee36@xeon-e3> From: Andrew Rybchenko Message-ID: Date: Mon, 17 Jul 2017 19:19:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170717090229.48abee36@xeon-e3> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23200.003 X-TM-AS-Result: No--5.623300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1500308400-zTvTvBJ57HWy Subject: Re: [dpdk-dev] [RFC 09/14] sfc: use new rte_eth_link helpers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 16:20:01 -0000 On 07/17/2017 07:02 PM, Stephen Hemminger wrote: > On Sun, 16 Jul 2017 16:48:50 +0300 > Andrew Rybchenko wrote: > >> On 07/14/2017 09:30 PM, Stephen Hemminger wrote: >>> Use the new API (_rte_eth_link_update) to handle link status update. >>> ALso fixes a bug where this driver was not returning -1 when link status changed. >> It is really good that you raise it, since: >> - as far as I can see the return value of the link_update is never used >> - return value is not described and it is unclear what is meant by "link >> status changed" since initial point is unspecified >> >> We have interpreted link status change as change in data->dev_link >> made in the current execution flow, but not in parallel execution flow. > All drivers must do the same thing. Private interpretation is not good. Definitely agree, but to do so, API documentation must clearly define what is required. It is especially pity that all these "fixes" and complexity is just a waste of time since return value is actually never used.