From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <okaya@codeaurora.org>
Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])
 by dpdk.org (Postfix) with ESMTP id AB34047D0
 for <dev@dpdk.org>; Sat, 23 Jul 2016 00:56:50 +0200 (CEST)
Received: by smtp.codeaurora.org (Postfix, from userid 1000)
 id B4CF761180; Fri, 22 Jul 2016 22:56:49 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 pdx-caf-mail.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from [10.38.242.44] (global_nat1_iad_fw.qualcomm.com [129.46.232.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 (Authenticated sender: okaya@smtp.codeaurora.org)
 by smtp.codeaurora.org (Postfix) with ESMTPSA id 8396D602A8;
 Fri, 22 Jul 2016 22:56:48 +0000 (UTC)
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org>
 <20160722141259.35ea0a7e@xeon-e3>
Cc: dev@dpdk.org
From: Sinan Kaya <okaya@codeaurora.org>
Message-ID: <e3fc647d-32fe-6fb8-b957-dfc8b55c4c95@codeaurora.org>
Date: Fri, 22 Jul 2016 18:56:46 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20160722141259.35ea0a7e@xeon-e3>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: support PCI domains
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2016 22:56:51 -0000

On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
> On Fri, 22 Jul 2016 11:34:10 -0400
> Sinan Kaya <okaya@codeaurora.org> wrote:
> 
>> The current code is enumerating devices based on bus, device and function
>> pairs. This does not work well for architectures with multiple PCI
>> segments/domains. Multiple PCI devices will have the same BDF value but
>> different segment numbers (01:01:01.0 and 02:01:01.0) for instance.
>>
>> Adding segment numbers to device naming so that we can uniquely identify
>> devices.
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> 
> I ran into this yes. There is a small risk of breaking some application that
> assumed something about names though.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Thanks, hopefully the change is minor and can be contained until next release.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.