From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C75D0A034F; Tue, 1 Mar 2022 04:41:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B260A407FF; Tue, 1 Mar 2022 04:41:25 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 5A1964067B for ; Tue, 1 Mar 2022 04:41:24 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4K72wr0K5Mz1DH9t; Tue, 1 Mar 2022 11:36:44 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Tue, 1 Mar 2022 11:41:22 +0800 Subject: Re: [PATCH] app/testpmd: add help messages for multi-process To: Thomas Monjalon CC: , References: <20220228032617.46618-1-humin29@huawei.com> <4289631.NgBsaNRSFp@thomas> From: "Min Hu (Connor)" Message-ID: Date: Tue, 1 Mar 2022 11:41:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <4289631.NgBsaNRSFp@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thomas, I have adjust the postions in v2. I think the new postion will be OK. Thanks. ÔÚ 2022/2/28 16:57, Thomas Monjalon дµÀ: > 28/02/2022 04:26, Min Hu (Connor): >> --- a/app/test-pmd/parameters.c >> +++ b/app/test-pmd/parameters.c >> @@ -210,6 +210,8 @@ usage(char* progname) >> printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n" >> " 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n" >> " 0x01 - hairpin ports loop, 0x00 - hairpin port self\n"); >> + printf(" --num-procs: the number of processes which will be used\n"); >> + printf(" --proc-id : the id of the current process (id < num-procs)\n"); >> } > > Can we find a better order instead of just adding these options at the end? > > > . >