From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AE8AC3257 for ; Thu, 1 Feb 2018 18:04:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 09:04:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,444,1511856000"; d="scan'208";a="14747094" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.157]) ([10.237.220.157]) by fmsmga008.fm.intel.com with ESMTP; 01 Feb 2018 09:04:40 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, John McNamara References: <20171216001350.90436-1-ferruh.yigit@intel.com> <9672510.c4JnJd36Tx@xps> From: Ferruh Yigit Message-ID: Date: Thu, 1 Feb 2018 17:04:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <9672510.c4JnJd36Tx@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mk: add debug target X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 17:04:44 -0000 On 1/30/2018 11:40 PM, Thomas Monjalon wrote: > 16/12/2017 01:13, Ferruh Yigit: >> Add "debug" target to build library with debug symbols and optimization >> disabled. >> >> This is shortcut for exiting method to compile with >> EXTRA_CFLAGS="-O0 -g3" >> >> Signed-off-by: Ferruh Yigit >> --- >> + debug build library with debug symbols > [...] >> +.PHONY: debug >> +debug: >> + $(Q)$(MAKE) EXTRA_CFLAGS="-O0 -g3" > > This target will override any EXTRA_CFLAGS, > so we cannot build in debug mode with more extra cflags this way. How about EXTRA_CFLAGS+="-O0 -g3" which is not override EXTRA_CFLAGS but merge them, can be ok? > > I think the cons are higher than the pros. >