From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Jeremy Spewock <jspewock@iol.unh.edu>,
yoan.picchi@foss.arm.com, probb@iol.unh.edu,
paul.szczepanek@arm.com, npratte@iol.unh.edu,
thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output
Date: Thu, 1 Aug 2024 09:43:43 +0100 [thread overview]
Message-ID: <e41ac947-5a44-46df-971f-5350146d95e8@arm.com> (raw)
In-Reply-To: <CAAA20URJ2XceoywxWLe5ur05oALu1Lsoma1tcsYB1UnhDYEEcA@mail.gmail.com>
On 30/07/2024 22:33, Jeremy Spewock wrote:
> On Tue, Jul 30, 2024 at 9:37 AM <jspewock@iol.unh.edu> wrote:
> <snip>
>> +class VerboseOLFlag(Flag):
>> + """Flag representing the OL flags of a packet from Testpmd verbose output."""
>> +
>> + #:
>> + RTE_MBUF_F_RX_RSS_HASH = auto()
>> +
>> + #:
>> + RTE_MBUF_F_RX_L4_CKSUM_GOOD = auto()
>> + #:
>> + RTE_MBUF_F_RX_L4_CKSUM_BAD = auto()
>> + #:
>> + RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN = auto()
>> +
>> + #:
>> + RTE_MBUF_F_RX_IP_CKSUM_GOOD = auto()
>> + #:
>> + RTE_MBUF_F_RX_IP_CKSUM_BAD = auto()
>> + #:
>> + RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN = auto()
>> +
>> + #:
>> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD = auto()
>> + #:
>> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_BAD = auto()
>> + #:
>> + RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN = auto()
>> +
> After reading more of the API and using this patch to write a test
> suite, I believe there is more expansion of these OL flags that should
> take place. For starters, there are the Tx OL flags that, while not
> seeming to be very useful for the current test suites we are writing,
> wouldn't hurt to also include as they seem to be fairly different.
> Additionally, there are some other less common RX OL flags that should
> be included here just to cover all options. I will work on adding
> these into the next version.
If you wanted to cover even more, hw_ptype and sw_ptype look like they
could use a data structure. I reckon a flag like the above would also work.
next prev parent reply other threads:[~2024-08-01 8:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 20:39 [PATCH v1 0/1] dts: testpmd verbose parser jspewock
2024-07-29 20:39 ` [PATCH v1 1/1] dts: add text parser for testpmd verbose output jspewock
2024-07-30 13:34 ` [PATCH v2 0/1] dts: testpmd verbose parser jspewock
2024-07-30 13:34 ` [PATCH v2 1/1] dts: add text parser for testpmd verbose output jspewock
2024-07-30 15:41 ` Nicholas Pratte
2024-07-30 21:30 ` Jeremy Spewock
2024-08-02 14:54 ` Nicholas Pratte
2024-08-02 17:38 ` Jeremy Spewock
2024-08-05 13:20 ` Nicholas Pratte
2024-07-30 21:33 ` Jeremy Spewock
2024-08-01 8:43 ` Luca Vizzarro [this message]
2024-08-02 13:40 ` Jeremy Spewock
2024-08-01 8:41 ` Luca Vizzarro
2024-08-02 13:35 ` Jeremy Spewock
2024-08-08 20:36 ` [PATCH v3 0/1] dts: testpmd verbose parser jspewock
2024-08-08 20:36 ` [PATCH v3 1/1] dts: add text parser for testpmd verbose output jspewock
2024-08-08 21:49 ` Jeremy Spewock
2024-08-12 17:32 ` Nicholas Pratte
2024-09-09 11:44 ` Juraj Linkeš
2024-09-17 13:40 ` Jeremy Spewock
2024-09-18 8:09 ` Juraj Linkeš
2024-09-18 16:34 ` [PATCH v4 0/1] dts: testpmd verbose parser jspewock
2024-09-18 16:34 ` [PATCH v4 1/1] dts: add text parser for testpmd verbose output jspewock
2024-09-18 17:05 ` [PATCH v5 0/1] dts: testpmd verbose parser jspewock
2024-09-18 17:05 ` [PATCH v5 1/1] dts: add text parser for testpmd verbose output jspewock
2024-09-19 9:02 ` Juraj Linkeš
2024-09-20 15:53 ` Jeremy Spewock
2024-09-23 13:30 ` Juraj Linkeš
2024-09-19 12:35 ` Juraj Linkeš
2024-09-20 15:55 ` Jeremy Spewock
2024-09-25 15:46 ` [PATCH v6 0/1] dts: testpmd verbose parser jspewock
2024-09-25 15:46 ` [PATCH v6 1/1] dts: add text parser for testpmd verbose output jspewock
2024-09-26 8:25 ` Juraj Linkeš
2024-09-26 14:43 ` Jeremy Spewock
2024-09-26 15:47 ` [PATCH v7 0/1] dts: testpmd verbose parser jspewock
2024-09-26 15:47 ` [PATCH v7 1/1] dts: add text parser for testpmd verbose output jspewock
2024-09-27 9:32 ` Juraj Linkeš
2024-09-27 11:48 ` Luca Vizzarro
2024-09-30 13:41 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e41ac947-5a44-46df-971f-5350146d95e8@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).