From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F479A00BE; Tue, 7 Jul 2020 09:40:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 745801DA3A; Tue, 7 Jul 2020 09:40:46 +0200 (CEST) Received: from dal1relay8.mxroute.com (dal1relay8.mxroute.com [199.181.239.8]) by dpdk.org (Postfix) with ESMTP id 3A70F1D9FB for ; Tue, 7 Jul 2020 09:40:44 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by dal1relay8.mxroute.com (ZoneMTA) with ESMTPSA id 17328383d400005b7b.004 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 07 Jul 2020 07:40:41 +0000 X-Zone-Loop: df0a4e85c5c2db6cb3daa5a4a48b4e10d1cf787efe4a X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 1A3B360007; Tue, 7 Jul 2020 07:40:40 +0000 (UTC) To: Feifei Wang , Honnappa Nagarahalli , Konstantin Ananyev , Neil Horman Cc: "dev@dpdk.org" , nd References: <20200703102651.8918-1-feifei.wang2@arm.com> <20200703102651.8918-2-feifei.wang2@arm.com> <743167fc-ff84-2918-d2d8-ea03c00297f8@ashroe.eu> <0dd7404d-bb95-e350-1682-9fd309168160@ashroe.eu> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Tue, 7 Jul 2020 08:40:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 1/3] ring: remove experimental tag for ring reset API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/07/2020 04:19, Feifei Wang wrote: > > >> -----Original Message----- >> From: Kinsella, Ray >> Sent: 2020年7月6日 14:23 >> To: Honnappa Nagarahalli ; Feifei Wang >> ; Konstantin Ananyev >> ; Neil Horman >> Cc: dev@dpdk.org; nd >> Subject: Re: [PATCH 1/3] ring: remove experimental tag for ring reset API >> >> >> >> On 03/07/2020 19:46, Honnappa Nagarahalli wrote: >>> >>> >>>> >>>> On 03/07/2020 11:26, Feifei Wang wrote: >>>>> Remove the experimental tag for rte_ring_reset API that have been >>>>> around for 4 releases. >>>>> >>>>> Signed-off-by: Feifei Wang >>>>> Reviewed-by: Honnappa Nagarahalli >>>>> Reviewed-by: Ruifeng Wang >>>>> --- >>>>> lib/librte_ring/rte_ring.h | 3 --- >>>>> lib/librte_ring/rte_ring_version.map | 4 +--- >>>>> 2 files changed, 1 insertion(+), 6 deletions(-) >>>>> >>>>> diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h >>>>> index f67141482..7181c33b4 100644 >>>>> --- a/lib/librte_ring/rte_ring.h >>>>> +++ b/lib/librte_ring/rte_ring.h >>>>> @@ -663,15 +663,12 @@ rte_ring_dequeue(struct rte_ring *r, void >> **obj_p) >>>>> * >>>>> * This function flush all the elements in a ring >>>>> * >>>>> - * @b EXPERIMENTAL: this API may change without prior notice >>>>> - * >>>>> * @warning >>>>> * Make sure the ring is not in use while calling this function. >>>>> * >>>>> * @param r >>>>> * A pointer to the ring structure. >>>>> */ >>>>> -__rte_experimental >>>>> void >>>>> rte_ring_reset(struct rte_ring *r); >>>>> >>>>> diff --git a/lib/librte_ring/rte_ring_version.map >>>>> b/lib/librte_ring/rte_ring_version.map >>>>> index e88c143cf..aec6f3820 100644 >>>>> --- a/lib/librte_ring/rte_ring_version.map >>>>> +++ b/lib/librte_ring/rte_ring_version.map >>>>> @@ -8,6 +8,7 @@ DPDK_20.0 { >>>>> rte_ring_init; >>>>> rte_ring_list_dump; >>>>> rte_ring_lookup; >>>>> + rte_ring_reset; >>>>> >>>>> local: *; >>>>> }; >>>>> @@ -15,9 +16,6 @@ DPDK_20.0 { >>>>> EXPERIMENTAL { >>>>> global: >>>>> >>>>> - # added in 19.08 >>>>> - rte_ring_reset; >>>>> - >>>>> # added in 20.02 >>>>> rte_ring_create_elem; >>>>> rte_ring_get_memsize_elem; >>>> >>>> So strictly speaking, rte_ring_reset is part of the DPDK_21 ABI, not >>>> the v20.0 ABI. >>> Thanks Ray for clarifying this. >>> > Thanks very much for pointing this. >>>> >>>> The way to solve is to add it the DPDK_21 ABI in the map file. >>>> And then use the VERSION_SYMBOL_EXPERIMENTAL to alias to >> experimental >>>> if necessary. >>> Is using VERSION_SYMBOL_EXPERIMENTAL a must? >> >> Purely at the discretion of the contributor and maintainer. >> If it has been around for a while, applications are using it and changing the >> symbol will break them. >> >> You may choose to provide the alias or not. > Ok, in the new patch version, I will add it into the DPDK_21 ABI but the > VERSION_SYMBOL_EXPERIMENTAL will not be added, because if it is added in this > version, it is still needed to be removed in the near future. > > Thanks very much for your review. That is 100% >> >>> The documentation also seems to be vague. It says " The macro is used >> when a symbol matures to become part of the stable ABI, to provide an alias >> to experimental for some time". What does 'some time' mean? >> >> "Some time" is a bit vague alright, should be "until the next major ABI >> version" - I will fix. >> >>> >>>> >>>> https://doc.dpdk.org/guides/contributing/abi_versioning.html#versioni >>>> ng- >>>> macros