From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 53114A0471 for ; Thu, 20 Jun 2019 11:58:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 110B01D124; Thu, 20 Jun 2019 11:58:32 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8ABCA1D122; Thu, 20 Jun 2019 11:58:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9FDD3162906; Thu, 20 Jun 2019 09:58:28 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6013F608A7; Thu, 20 Jun 2019 09:58:27 +0000 (UTC) To: Andrew Rybchenko , Tiwei Bie , Zhihong Wang Cc: dev@dpdk.org, Dilshod Urazov , stable@dpdk.org References: <1559587805-1637-1-git-send-email-arybchenko@solarflare.com> <1560771098-20375-1-git-send-email-arybchenko@solarflare.com> <1560771098-20375-2-git-send-email-arybchenko@solarflare.com> From: Maxime Coquelin Message-ID: Date: Thu, 20 Jun 2019 11:58:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1560771098-20375-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 20 Jun 2019 09:58:30 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/17/19 1:31 PM, Andrew Rybchenko wrote: > From: Dilshod Urazov > > VLAN tag insertion should be in Tx prepare, not in Tx burst functions. > One of Tx prepare goals is to be able to do preparations in advance > (possibliy on different CPU core) and then transmit it fast. > Also Tx prepare can report that a packet does not pass Tx offloads > check. E.g. has no enough headroom to insert VLAN header. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc:stable@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- > v4: > - add more details to commit log > > drivers/net/virtio/virtio_rxtx.c | 50 +++++++++----------------------- > 1 file changed, 14 insertions(+), 36 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime