From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D7A7A00C5; Thu, 15 Sep 2022 13:34:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E2FF4021D; Thu, 15 Sep 2022 13:34:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4749A40A80 for ; Thu, 15 Sep 2022 13:34:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663241693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUpZvKYTHy0hPtAkI07OqZzaLgTFneMnh0DH7AYe7/g=; b=ZAbIzhRHP2DSYoEsDRat5S8UoMBQ0D6zpmR4FQBGdXyB8qduM80EWz2rg1UQuE9b0zA0BJ ParkazHWslpnY+hTGvbwfVwNO9ND1c9+6KVKCWf9UQO0W/mmAsqYt8S+xtDXlJZizeCPq2 YQRJrsnYMagx3oha0Ji53kBsH321hQE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-x4ySL4tTO6yys7PM1zwWPQ-1; Thu, 15 Sep 2022 07:34:50 -0400 X-MC-Unique: x4ySL4tTO6yys7PM1zwWPQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5DBF538149B0; Thu, 15 Sep 2022 11:34:50 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF7732166B26; Thu, 15 Sep 2022 11:34:48 +0000 (UTC) Message-ID: Date: Thu, 15 Sep 2022 13:34:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 37/37] baseband/acc100: reset pointer after rte_free To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-38-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-38-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Set local pointer to NULL after rte_free. > This needs to be set explicitly since logic may check for null pointers. > > Fixes: 060e7672930 ("baseband/acc100: add queue configuration") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index be4c1d07ed..7755d6402f 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -793,6 +793,9 @@ acc100_dev_close(struct rte_bbdev *dev) > rte_free(d->sw_rings_base); > rte_free(d->harq_layout); > d->sw_rings_base = NULL; > + d->tail_ptrs = NULL; > + d->info_ring = NULL; > + d->harq_layout = NULL; > } > /* Ensure all in flight HW transactions are completed */ > usleep(ACC100_LONG_WAIT); Please move it to the top of the series as this is a fix. Reviewed-by: Maxime Coquelin Thanks, Maxime