From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D36BCA045E for ; Thu, 30 May 2019 14:06:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBD611B953; Thu, 30 May 2019 14:06:22 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1C4FC1B94B for ; Thu, 30 May 2019 14:06:20 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190530120620euoutp02987ef7461ef836661c65707724ab9b41~jdH3kVJB60367203672euoutp02S for ; Thu, 30 May 2019 12:06:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190530120620euoutp02987ef7461ef836661c65707724ab9b41~jdH3kVJB60367203672euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1559217980; bh=bvpDjCKaJKmbqNomNC4uyZvYV+2iQsaG6Lto7hPL1O8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=eCBBUWmFisrU7Oq0RWlqJHQeH7pI2IXBtEQZOaOuIo5o5P3/DfvTu/X3nj9w1nYtT W3zpGNe9o9dsGx1nBk4TwzYJSEW4t+lTGacr85cj+/UQ+5zrwbZdSVPhOVtFyLipXx oK/whEEe2cXsFD9JR2iblAHm1m4IRCQpYALGAeRg= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190530120619eucas1p29e818d7ddbb45d63a0f515e4a9febc2a~jdH3EW77l2174321743eucas1p2g; Thu, 30 May 2019 12:06:19 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E2.AC.04298.B37CFEC5; Thu, 30 May 2019 13:06:19 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190530120618eucas1p26e6ff9abe6785efb46f571dad217cd9e~jdH2SgTez2529025290eucas1p28; Thu, 30 May 2019 12:06:18 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190530120618eusmtrp2377926987a4a6a0baaf3c18ec6cb31df~jdH2C-5MJ0402304023eusmtrp2D; Thu, 30 May 2019 12:06:18 +0000 (GMT) X-AuditID: cbfec7f2-f2dff700000010ca-7a-5cefc73bf14a Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 27.36.04146.A37CFEC5; Thu, 30 May 2019 13:06:18 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190530120617eusmtip25d9a60197176d43a0723610610d4fee4~jdH1mQm0q1025310253eusmtip2Y; Thu, 30 May 2019 12:06:17 +0000 (GMT) To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon , Aaron Conole , Kevin Traynor From: Ilya Maximets Message-ID: Date: Thu, 30 May 2019 15:06:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190530115558.GA1279@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsWy7djPc7rWx9/HGMxYzmvx680Ddosbq+wt 3n3azmRxpf0nu8XaQx/YLT49OMHiwObxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMQawRnHZ pKTmZJalFunbJXBl/Gm8w1LQyVZxd/JU1gbGdyxdjJwcEgImEquuXWHtYuTiEBJYwSjRfOQS E4TzhVFi1psFjBDOZ0aJlqXXgRwOsJafSw0g4ssZJQ7NPwvV/pFRYurBQ6wgc4UFQiQ2L1/I BGKLCBhKbF24lRmkiFmgkVHi8+oNYAk2AR2JU6uPMILYvAJ2EhtePASzWQRUJVbeWQlmiwpE SHzZuQmqRlDi5MwnYIdzCrhI/Lo4BWwZs4C4RNOXlVC2vMT2t3PAlkkIrGKXePTtCzvEpy4S TVd2Q9nCEq+Ob4GyZST+75zPBGHXS9xveckI0dzBKDH90D+ohL3Eltfn2EH+ZxbQlFi/Sx8i 7Cjxb8pmJkiw8EnceCsIcQOfxKRt05khwrwSHW1CENUqEr8PLmeGsKUkbr77zD6BUWkWks9m IflmFpJvZiHsXcDIsopRPLW0ODc9tdgwL7Vcrzgxt7g0L10vOT93EyMw9Zz+d/zTDsavl5IO MQpwMCrx8AocfB8jxJpYVlyZe4hRgoNZSYT35/J3MUK8KYmVValF+fFFpTmpxYcYpTlYlMR5 qxkeRAsJpCeWpGanphakFsFkmTg4pRoY1yV7MnxNuJd6ma3Is/nfJUVmzSevFr9s1jtxyCj8 pbbYlAeh3BsOSp7jjLrU+F3NYN2Ke2d7vAqb2ra93pY2v8hJZuspKZUVwZ8iZ140vFE1fXmX WeGz7Ts+fK7VXb/sd5HEmVR/yUcpoutYvin/8p2vHV//sXP5Fe1432cTtygK7d05731xixJL cUaioRZzUXEiAAdG0yU5AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t/xe7pWx9/HGBw5JGLx680Ddosbq+wt 3n3azmRxpf0nu8XaQx/YLT49OMHiwObxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMQawRunZ FOWXlqQqZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl/Gm8w1LQ yVZxd/JU1gbGdyxdjBwcEgImEj+XGnQxcnEICSxllJhy9gpjFyMnUFxK4sevC6wQtrDEn2td bCC2kMB7RolXh5lBbGGBEInNyxcygdgiAoYSWxduBYszCzQySjSeZ4EY+ptR4sCcjewgCTYB HYlTq4+ALeAVsJPY8OIhmM0ioCqx8s5KMFtUIEJi9q4GFogaQYmTM5+A2ZwCLhK/Lk5hhVig LvFn3iWoZeISTV9WQsXlJba/ncM8gVFoFpL2WUhaZiFpmYWkZQEjyypGkdTS4tz03GJDveLE 3OLSvHS95PzcTYzASNt27OfmHYyXNgYfYhTgYFTi4RU4+D5GiDWxrLgy9xCjBAezkgjvz+Xv YoR4UxIrq1KL8uOLSnNSiw8xmgI9N5FZSjQ5H5gE8kriDU0NzS0sDc2NzY3NLJTEeTsEDsYI CaQnlqRmp6YWpBbB9DFxcEo1MLbpqU1KrwtztXl2Q62bOzH16mttzoYMtdPaxqf/K6+trXVW FVweuGlJQFiq8KcKQ9u7Peml3V4HLjvX3eTb6bCyt/1tV+2yFRkrN09qk7j21HJj3Y6/BiE3 rmTIyh5P3OnoeN65dtXmqolhE+dqZTm/j1HR/chef3XJ7c6MBKkLHn12s8rPKbEUZyQaajEX FScCAIj3XLTKAgAA X-CMS-MailID: 20190530120618eucas1p26e6ff9abe6785efb46f571dad217cd9e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190529164006eucas1p296e902a46cb3ef7ac436d619f9e55d5b References: <20190529163958.30796-1-i.maximets@samsung.com> <20190529163958.30796-2-i.maximets@samsung.com> <20190530115558.GA1279@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 1/2] meson: don't check dependencies for tests if not required X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30.05.2019 14:55, Bruce Richardson wrote: > On Wed, May 29, 2019 at 07:39:57PM +0300, Ilya Maximets wrote: >> Don't need to check dependencies if test apps will not be built anyway. >> >> Signed-off-by: Ilya Maximets >> --- >> app/test/meson.build | 38 +++++++++++++++++++------------------- >> 1 file changed, 19 insertions(+), 19 deletions(-) >> > Agree with the idea. > > Would this work as a shorter alternative placed at the top of the file? > > if not get_option('tests') > subdir_done() > endif This looks good to me. However, the resulted patch will be much larger because we'll have to shift most of it to the left. If it's OK, I'll prepare v2 with this change. What do you think? Best regards, Ilya Maximets.