From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B858A0C3F; Thu, 15 Apr 2021 13:09:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 649601621C7; Thu, 15 Apr 2021 13:09:50 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id CC646161FA4 for ; Thu, 15 Apr 2021 13:09:48 +0200 (CEST) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FLc4f17zVz19L4k; Thu, 15 Apr 2021 19:07:30 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 15 Apr 2021 19:09:44 +0800 To: Andrew Rybchenko , CC: , References: <1618046334-39857-1-git-send-email-humin29@huawei.com> <1618447925-12168-1-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Thu, 15 Apr 2021 19:09:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/15 16:15, Andrew Rybchenko 写道: > On 4/15/21 3:52 AM, Min Hu (Connor) wrote: >> This patch adds more sanity checks in control path APIs. >> >> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") >> Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") >> Fixes: 0366137722a0 ("ethdev: check for invalid device name") >> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model") >> Fixes: 5b7ba31148a8 ("ethdev: add port ownership") >> Fixes: f8244c6399d9 ("ethdev: increase port id range") >> Cc: stable@dpdk.org > > Many thanks. I'll keep log messages gramma review to native > speekers. Content looks good to me. > > One minor issue below lost on previous review. > > Other than that, > > Reviewed-by: Andrew Rybchenko > >> >> Signed-off-by: Min Hu (Connor) > > [snip] > >> @@ -1299,6 +1337,12 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, >> >> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >> >> + if (dev_conf == NULL) { >> + RTE_ETHDEV_LOG(ERR, "Failed to configure ethdev port %u to NULL\n", >> + port_id); >> + return -EINVAL; >> + } >> + >> dev = &rte_eth_devices[port_id]; > > I think it is better to keep: > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > dev = &rte_eth_devices[port_id]; > together since they are tightly related. I.e. I'd even remove > empty line between them when it is present and add args > sanity check after the dev assignment. > > >> RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP); > Thanks Andrew, this has been fixed in v5. > In theory, the first argument is sufficient to make the ops > check, but I think it is the right solution to keep it as is > since current tendency is to check operation support when > driver callback is really required and we're going to use it. > However, if we do it just after port_id check, we'll have a > way to check for callback support without any side effects > if we provide invalid argument value. I.e. if -ENOTSUP is > returned, callback is not supported, if -EINVAL, callback is > supported (but argument is invalid and nothing done). > However, it looks a bit fragile and not always possible. > Thoughts on it are welcome. > . >