From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id E19075B1A for ; Wed, 9 May 2018 14:29:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qqCDfPndAn2voLrh0cKiDqcgyPV+INYqJbMxw6lS4AY=; b=Tw3ZaNt6a2bV75G5ELfJa8pgo1IswziSBiNiUBobsLA3FlT9yAvQ3UAJYSV4LJYnH8/Lig+YKa9MDUVWYZuEHcs0Flzohur5lvi7QJxUtWCQovHlzCPWrFMM/vm/z6E70rNdSoLqNnd9+WoaFuQVdGdbkkXe3+ZHekP+mARK5IA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by DB6PR0402MB2773.eurprd04.prod.outlook.com (2603:10a6:4:96::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 12:29:57 +0000 To: "De Lara Guarch, Pablo" Cc: Akhil Goyal , "dev@dpdk.org" , Hemant Agrawal References: <20180509092642.9092-1-shreyansh.jain@nxp.com> <90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com> From: Shreyansh Jain Message-ID: Date: Wed, 9 May 2018 18:16:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BMXPR01CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::26) To DB6PR0402MB2773.eurprd04.prod.outlook.com (2603:10a6:4:96::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR0402MB2773; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 3:Ch/e7nh/uWrDCQHEZJCDRh9KWSj3XjmDYAUl/TP6Z9aPygxm4pILE3rTLSOmqF9Hm3kSRC8be90AnOoE2fWMnt9s7kMtXMq5FH90KFQJX5k0oiTgMJOkTQ25Oa8jHk7lrkAadTYrUh3PY45EjzUEF70TYvRUjkiFxLLgQiHI0RwkQpf2Llp6RnzXaNUILPuw4Ks4iVKwBb5cdNfAB9Y8RX7SmtSFH04Ar5+gWqAtB5CapV2kFtRoo459fSEQyFGl; 25:H5swEt5ONvs9RS6ClX4l/nWl7qMClJCoCpYfv3kFRUQO0Q46AgQfk0unJtmeqCWZrBrVyJYpn2a4u1QYsRdkrpRZDFbwZaTvjSyk/kQt0xYbjwF0UogkjxmVJmlhoPxPNj7idHoCVRCMGBRmbvKijOUkeZGFkqFLE89lhWClO00ltt1rm8zctFRHwnSnRwiHKSlS9gtESSQpY/wjasfNl94YEc3CErAp/XtP178sfGiK41NIEk2AZwZUSg20N3Yz/zHvkzaVSY4ASx9RpxnUQhPwnKQFk4dV4aa0kKElWdBMTqacs0YfpJDJpePC7OJoE6AKd0teBW7gP7IWDP0VMQ==; 31:GpyY0eEYFjqFqR8Luf1uroIFPDPId3/hA/4eGBdbx/KuRIQzlS5bxvFmrFkfLCyid+X/nS+OGR6NCk/eMyWqRvhD3lCEs+j8cav8jtcVYl+kMJdl3z26FCZNjJLGvDQyCmJ4WjJCXwl8ZcyGioXGwtz7Xl4cQPOrxLWyryY0agj+zmAVBT7yeiquymuu09zWs/qrIOvAKTKG1XUvuerfIyM1azJ97cojRL5wEGLwn0E= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2773: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 20:0py4jlgJ1yx3WcMajHzoYitJYE+2wxmR1V/PvT6/Gbj1xJOItrY/0W/xpswgUGftIQLLmTItYRgzW6ocoflV5cTggVvVS6xREbfHfzY24bv0HaEov44kujsajRHy9Il1mmUnwhKJKUjSCvowIr28bM+msYXg48wfOjUfjo0JPctmUB0bJk3jLzug72nkbOjpKTDazm1j2dNczG1ryv724eLwI/n53ySD6y3CkgMNRAnBPX+Mr+FLpVCU8pYUf9OPnTz9b3qS1nxwhjretA4v5rCvXl292dVVMxjPOWmXUREcyo49keqMCd0Th5CYzwHIJgFD1DZ1E9mA7Oy2bgu0JY+xc3Y0hBpRPLKOm/PpugataA9AWsP6pvehKMOMYSxfHbUSSkVTKyNx+uANC3LqqhgQ+uUShh6kLztFh47UHFo/tsbCvJsXrXkFOk8UeauPISTHuaTeAQEECkT0TXDX7oDLoR1zo2JwS7WvfRzbot22ERXuHKaGPWdl2WMGPOr9; 4:0dr/StM36LebcvyBsaOM6mRNOhlpk2VAIf9dvw9++ECJc7Iru1ti24ZXyeYYkYwO9xXj1+RrKUAjoiALUKeZhKzq48QAFOaUhe2VfrwZIYKss/e/A7dSQso44fTzBGb0qCsfxQN01TbQUclTeI2pw5ZkxEkzJMN7y52QYq1iWFdx8Dhy2tDvz3Fjz9+8H2KLCi6Kvc/NscrDf69YKVcazfNO9UXTKPR0bLP00I/4Xssh7vIvvLW2k88yAuc44zd9Mwf0PYEY3KRcUwnfPECi+/f8b26ECC2eBZlC8F4QLLH8iyNSrWDu7WDOglQVxQAftNth5SMQRnw6Hebe6AnSKZWDMLNa7KP5l1Y6mGPMKxq25SL5OBdpL1lK1S8Y9qkD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(190756311086443)(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0402MB2773; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2773; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(39380400002)(39860400002)(396003)(366004)(376002)(13464003)(199004)(189003)(43544003)(67846002)(5009440100003)(52146003)(6246003)(2486003)(58126008)(23676004)(76176011)(52116002)(54906003)(93886005)(11346002)(53936002)(956004)(81156014)(2616005)(64126003)(446003)(476003)(50466002)(16576012)(386003)(25786009)(16526019)(59450400001)(53546011)(478600001)(65806001)(81166006)(4326008)(66066001)(8676002)(47776003)(6116002)(7736002)(305945005)(3846002)(2906002)(68736007)(229853002)(6916009)(2870700001)(26005)(8936002)(5660300001)(65956001)(36756003)(486006)(105586002)(6486002)(44832011)(77096007)(86362001)(31686004)(97736004)(106356001)(6666003)(65826007)(316002)(31696002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2773; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDJNQjI3NzM7MjM6dkxkN0R3OXlFZVVoSVVNTHVCaUZsWmk3?= =?utf-8?B?eCtDOFFqY25VMmcxaUlIOEVvNXZZK2pHQXNUN082WXNFNUJvdjB5VjI2RzVk?= =?utf-8?B?YVRWMUZzdTg0clZpOGUxcXJzSmRkdXdOMSswMm9Mb2RZcnZSaXJwazNXTmt0?= =?utf-8?B?ek1vdjFoellUVmF6dTJETzN0REdWNVU2SUd6UW1BVkx5b2hkOFJrVG4wcGdz?= =?utf-8?B?ekpPOHpxdjlYUmg2WEZCdUtJWUcwQ0lMT0FTNGFFUUJ4c1IzanBVZWx1MXZ0?= =?utf-8?B?UEZhVll2UEo2YXNOaEo3ZHU5SnZDeGovRTRtTTJoQUtQazNtY3Bla05rOTNR?= =?utf-8?B?cldYN2thWVg5STBnaDFubS9TU2F5R1RiU3hWMld4Ylg1K3BjUis2dTUzSU5Z?= =?utf-8?B?VHNKUzR2ZW1kMHdPZFkzWjQ5bVZUMHhFSFF5bW0vbXQ5QjVhdHUzWVFCdGwy?= =?utf-8?B?UnZoOVlNMENSRmZ0eFJQenRLR2ROcjdkK3RjNGh5bzkwNDFtYXpVeHFkbFVq?= =?utf-8?B?MXk5SjBzRmZRRXpTanJBQjZHVG9HQnYwY0JBK1FtbHI5eUdYVzRoY1dTWVJa?= =?utf-8?B?MlJYL3JBdFlqMHlDL2IyaThOU25pOTV5NjNZMFpqNStmV3I0cnNIZ0RFU2Jn?= =?utf-8?B?WW9iUVZIc2d3Q1ZWSW9yQ2J5TGNkWllzY0Q1UkhydHhzYTNPVzN4Ry9keG5O?= =?utf-8?B?bWt4cmFBNzhhVjd2amZrTVRucXUvd2s0Qlo5QXlhUVpYVzVweC9NNzlhYzZ1?= =?utf-8?B?eGZPMno1WFFPZUgxQVR6bTdhOHUwTGtwMk9WMWxobXo3THZYdmczTENCUk8r?= =?utf-8?B?QStwb3NwS2VmdTRicG4wN0hCS0JZS3B5YlU2Q0piYlJmejFvMzFpRnFsNC84?= =?utf-8?B?SGFSR2QxdHpQSnhydEZnbW91anE0dlFjczNMditNaHJxYUlLZGhHbzVXd0Fx?= =?utf-8?B?Nm0zOTZCSkVkaGNELytVTXNZOHNyQXhVNjFJSTZKMWUrWVhPM1h2WXNwdTds?= =?utf-8?B?eElVYlBGbEplM1podFd6L3BTWElKQ0N2TjMzUDBpTThGY3RlOVprL1JGYXBy?= =?utf-8?B?SmNMUnZFbHRnZmNucU16azk2QVk3QWVCYnlwZW8rVFdZOW9SWCtud1pqQi8w?= =?utf-8?B?c05XR3B5MDFxV1JWbm1FYjZ3cUtkZmFqOCt0RlBhNVYzdGFJVXhvWnNGUjZj?= =?utf-8?B?cXdZcGVlbUVHZjc3OGRrSFY4SmxIbjY5dkFhTldZZE81K2xPMGxTUkd5WWR4?= =?utf-8?B?ZTU1MUZBU2x4TlE5VjFKRkZMdWNNQkpyL2FseG1ZSi9jQysveVA2RXZ5UEtT?= =?utf-8?B?M0F2cG55NFE5Uzlrc3cvbzBjbzRTUXRlSTk1Ym9hRzg5a2hiYm0vOWQwTEsr?= =?utf-8?B?clBPVEw3Z1owQU90QlVtcktoTHl4Z1RTdDB4OFh5UmdmM2ZVbzExYTY1cGFs?= =?utf-8?B?QmVSSmVJcmdEYjhpUHZqYy9ZRVhaRDhCQkVBTHhYa055WnBuUHo3M1VLRnp3?= =?utf-8?B?U2xObjIrMTVNb1VZY2lzZHB1TGZiU3dINlNHQ1A0cjBOdExUSk1WMVV5TnpO?= =?utf-8?B?dExvSjhFdTg4MWlnU1c4MGlab1F3VXhXaDROdmR2d21CQk9rYVVrbWpJZ0ZX?= =?utf-8?B?bXVyZ3lVM0xnL3M0cmpBQkxCWWRsUEdINVFqNm5QZGEyeXozakFyUFE3MGFu?= =?utf-8?B?ekdMbCs2WE1yWjE4QVZYT01CUkJ3YWljaHhkdGVMVlVSK2lLTkpMb2dKa3RN?= =?utf-8?B?ODNjVjFGZGpibUlJeENKWFREWXJRNVUwQjFsRDQ2dW5RQWRzb25Cc01JOG9j?= =?utf-8?B?NWZxeUIzVjc3SndHZFhiTmpocWhVT1Rlc3gxejNvM1BodUxmSTliVW5tdzNJ?= =?utf-8?B?Zzk5dXk3bU1aOW9Ma3FoWDNVNG43WTJZMTVZVzVsdTJVTHA4U1BZaFgvaWlE?= =?utf-8?B?R1FhY013U1F4bDRjQzZEZ3ozMEE1Y2h2NzBMd0NwWFRYNjAvdmdlRjFjdzJz?= =?utf-8?B?V1VrQmtSVkllNWpybGJRNkFxazlnMkpkZUFJWkZyc0JqMERqcmJxVGdUNTlM?= =?utf-8?B?TkRwSVlRMlpaNlF5YzY1RDhFa3VZQXM0K0Fodk1ZS3ZzQzdHMmZMN2JTcERI?= =?utf-8?B?MTZrbUhnSlpBdFpJbUZhUFN1N3BMdUllSjZTeVlTUDU1ajhEVklGMW9VWDRW?= =?utf-8?B?NXdCRFpCOXV1SFd4VmxyVC9jWERvQmc9PQ==?= X-Microsoft-Antispam-Message-Info: y/B3gAe1kWrcQvObvlW8/h1RntJctjLtuUYZT/g/yS54nPNys2HOHitb/MNdiqRkReuFRuOPLyzDh7rUeVfmyh8kBMA8zvCO/4C4JrwYq5i8obeVfyF2Yb+OVpXWqqpO1/oIttbGvEGO/PTUW9t0kN7R1TOpksJbEaxctY/9rUeB/wa0X65boNvSlhBV9zph X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 6:PsszyXe3hmQpHSNHh+mQepDMOfMeV0SLxQZ2fCiHcXsG01jvPpjbMAWelzRRg3AaC7lwU6GARnefa4RnAH7WB1AYY5puhrTl7Nt0mIHMFI9OvGr4kjk6wD8tTk4lEHIYCMyeT7Z/SslnmqkEVn88Oh5PunzQ7lT9GhEJlFOeCdsSzGctdxWnliViOIygBQOsTlewoCfZV42BEUeBGUnk87kWiWatofhL/QMvqwzv2ELnp611f893UaolBw0E6UfKGUtbiPLFUkrFP+yIw6otRe8OWWC9XT5O9PEL9H3mcqF+VGaeZv7eeNfB9TzUN0tg4l4dtFko78tuTv7srd6ytqw8pP2EElnnn9EbSWhE0audGz/uqIIgaRXxvmvE9UNBcccqKFsrfJ6/Cz0103G3ixH60wQp2b/EGXGpkgTH9z2TBdPpFG85LfqlgS3CVzdena980R738MtZusd0GKu3TQ==; 5:+Sc29rurh3k2mEYueBKkX99dfkCkvJXeayeYr5FGFIabOl2fldcDf5nfa7bEnPP/XqoycZS9f3jl2F6bs4R/leUJlhMOFvVK+BGePB4inmhTmzAT89Qh/CC2DQJsWg48J93SSVZkfmEKG5yPzFIjpVmXrxf0X4BAEEhSDMUwipQ=; 24:y37Ns4KV5yqOPAFlGNpCAftjnxOGsL92i8DHHqKH+L+1b9Gs8vtRJ0LVDBeWE9at/FHLiDLWws9fQ/aLq4tWM4w2KyXly4pMK505Byi5rHQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 7:tl3/5yHf72km2jQhXyjR8lH3z+RlSfNsrrAiZoW8QIfFaIJsZiCSBqQ5axDCr0QTw8XAmULPapG/P3uwStIwKx/ZCT2XcSsBrigA67W/NZTMU+oSIBwqMbyBL+a3hE7FWh/5Ig3+MRDNdSEQ7BSTSAwNnrkK+P2yCF/5knwvLalsLPhVRSbSk8IoA007F0wmEoVh7J+e1qLcx50x84666YcTgZCFLcrZ23yFyK6vyoJ6CQuaYJQpx4gg8cuA+nUw X-MS-Office365-Filtering-Correlation-Id: 2167b3b7-47c4-47eb-4963-08d5b5a89445 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 12:29:57.9807 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2167b3b7-47c4-47eb-4963-08d5b5a89445 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2773 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:30:00 -0000 On Wednesday 09 May 2018 05:59 PM, Shreyansh Jain wrote: > On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote: >> Hi, >> >>> -----Original Message----- >>> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] >>> Sent: Wednesday, May 9, 2018 12:40 PM >>> To: De Lara Guarch, Pablo >>> Cc: Akhil Goyal ; dev@dpdk.org; Hemant Agrawal >>> >>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova >>> conversion for >>> fle address >>> >>> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote: >>>> >>>> >>>>> -----Original Message----- >>>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >>>>> Sent: Wednesday, May 9, 2018 10:14 AM >>>>> To: Shreyansh Jain ; De Lara Guarch, Pablo >>>>> >>>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal >>>>> >>>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova >>>>> conversion for fle address >>>>> >>>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote: >>>>>> From: Hemant Agrawal >>>>>> >>>>>> fle is already in virtual addressing mode - no need to perform >>>>>> address conversion for it. >>>>>> >>>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") >>>>>> Cc: akhil.goyal@nxp.com >>>>>> >>>>>> Signed-off-by: Hemant Agrawal >>>> >>>> ... >>>> >>>>>> >>>>> Acked-by: Akhil Goyal >>>> >>>> Added Cc: stable@dpdk.org (try remembering this for next time, please). >>> >>> Thanks for doing it this time. I'll take care of this next time. >> >> No worries. Actually, gcc 32 bits is broken: >> >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7: >> error: cast to pointer from integer of different size >> [-Werror=int-to-pointer-cast] >>    op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1)); >> >> Is this PMD supposed to be compatible for 32-bit targets? > > Oh! This is bad. I will send you an update on this in a few minutes. > Ideally, the code was written for 64bit in mind - though, it should > still be able to work (at least compile) for 32 bit. I have sent the v2 but I observe that the patchwork for v1 states 'accepted' - not sure if I can change that back to 'superseded'. If you have already applied and issued the pull request for next (and you won't be changing it), I will send a fix against that. > >> >> Thanks, >> Pablo >> >>> >>>> >>>> Applied to dpdk-next-crypto. >>>> Thanks, >>>> >>>> Pablo >>>> >> >