From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FCF5A052E; Mon, 9 Mar 2020 20:34:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D4FB1BFFB; Mon, 9 Mar 2020 20:34:33 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 8868A1BFFA for ; Mon, 9 Mar 2020 20:34:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583782470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gwL3N3I+WXMkm/SdpHQkEin9hOGQBWH1+1ujdPafJXw=; b=GT/c5pSRCbXoh8BZIZojn3fe4potAEjNec8xHoxbN9AQMP8BF5GO4Hhj4M0f/t7mVlGxMD +hIfxeohYCtELMHStxLuvNzoSAkATwOE0Xd13AKPn5W96WysLT8qjD6YSc8V4Vojngc9QZ 8dzmMe5Ukm+PXicMvKyhxMapd67hHyg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-0eQ6j4qkP5qHua9js2NKzQ-1; Mon, 09 Mar 2020 15:34:26 -0400 X-MC-Unique: 0eQ6j4qkP5qHua9js2NKzQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECC76184C81D; Mon, 9 Mar 2020 19:34:23 +0000 (UTC) Received: from [10.33.36.148] (unknown [10.33.36.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C25460BFB; Mon, 9 Mar 2020 19:34:18 +0000 (UTC) To: Thomas Monjalon , David Marchand , Ye Xiaolong Cc: Haiyue Wang , dev , Qi Zhang , Qiming Yang , Beilei Xing , Wei Zhao , Aaron Conole , ci@dpdk.org, Ferruh Yigit References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200309162057.GD112283@intel.com> <1652587.VLH7GnMWUR@xps> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Mon, 9 Mar 2020 19:34:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1652587.VLH7GnMWUR@xps> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/03/2020 17:57, Thomas Monjalon wrote: > 09/03/2020 17:20, Ye Xiaolong: >> Hi, David >> >> On 03/09, David Marchand wrote: >>> On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrot= e: >>>> >>>> A DCF (Device Config Function) based approach is proposed where a devi= ce >>>> bound to the device's VF0 can act as a sole controlling entity to exer= cise >>>> advance functionality (such as switch, ACL) for rest of the VFs. >>>> >>>> The DCF works as a standalone PMD to support this function, which shar= es the >>>> ice PMD flow control core function and the iavf virtchnl mailbox core = module. >>>> >>>> This patchset is based on: >>>> [1] https://patchwork.dpdk.org/cover/66417/ update ice base code >>> >>> The problem is that the CI(s) won't handle this. >>> Example for the robot: https://travis-ci.com/ovsrobot/dpdk/builds/15246= 1907 >>> >>> Maybe we could add something as an annotation to the cover letter or >>> the first patch of a series so that the CI(s) can detect and try to be >>> intelligent? >> >> Agree, It'd be helpful if the cover letter of the first patch contains s= ome >> base tree info including the base commit and dependency patchset info (i= f any),=20 >> so the CI can determine the correct base on top of which the developer's >> patchset applies to avoid any apply issue and potential false positive.= =20 >> >> And I know there is one option '--base'' of `git format-patch` which is >> dedicated for this kind of usage, it can help create the base tree info = block >> which can be easily consumed by the CI. Here is the simple intro of it. >> >> Imagine that on top of the public commit P (already in upstream), the de= veloper >> applied well-known (on-flight, in the mailing list but not merged yet) p= atches >> X, Y and Z from somebody else or himself, and then built his three-patch= series >> A, B, C, the commit history would be like: >> >> ................................................ >> ---P---X---Y---Z---A---B---C >> ................................................ >> >> With `git format-patch --base=3DP -3 C`, >> >> where P could be the exact commit sha, or variants e.g. HEAD~6, we can a= lso use >> --base=3Dauto for convenience, the base tree information block will be s= hown at >> the end of the first message the command outputs (either the first patch= , or >> the cover letter), like this: >> >> ------------ >> base-commit: P >> prerequisite-patch-id: X >> prerequisite-patch-id: Y >> prerequisite-patch-id: Z >> ------------ >> >> Here P is the commit sha, and X,Y,Z are the patch ids of the dependency = patches. >> >> >> With this info in place, I think CI should be able to setup the exact ba= se for >> the coming patchset, the missing part I can see is the mapping of=20 >> (in-flight patch <-> patch id), since we have all the in-flight patches = in >> patchwork, creating and maintaining such mapping in DB is doable, what d= o you >> think? >=20 > I think it would simpler to list dependencies as patchwork ids. > Example: > =09Depends-on: series-42, patch-12345 >=20 +1. I don't think it should depend on a base-commit. If it doesn't apply/build/work with the latest upstream code then it's a valid error. >=20