From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vincent.jardin@6wind.com>
Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com
 [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 23195379E
 for <dev@dpdk.org>; Fri, 16 Dec 2016 21:29:06 +0100 (CET)
Received: by mail-wj0-f169.google.com with SMTP id tg4so101743416wjb.1
 for <dev@dpdk.org>; Fri, 16 Dec 2016 12:29:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=subject:to:references:cc:from:organization:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding;
 bh=rztr4NGHqWzD6siFYj3viaENOEabJnVvCsfbB8qlyLA=;
 b=r0mjoViuqz8GjTOoifs/ul9OB5DDWyUKDR4jAlTLIT4UW0nnd0KDL1p42Qu06qcuaB
 Bgf4NWQEt74VgUYyZGlcV9FOmtDB9lsmTLE0U/Lp+DCZZC89EegncsRwiUL2Ji19Z4rJ
 CXBQnQUZ1h9SBEApvJiIemZpHJcfpBS/ZAJFc75/XDeLtyizsH4ALSR2d9yK/0S4gghM
 jVfL8FXgxCqgWWzKEQfntPRUPpDJVqjl5tHWbPRQSH0Cke7LzqtCoJqInEn4Y7jbJycX
 nVkTe7ZaHSV1WsC7l+tSH0t0LXYZO9XVEaTa8AjLINnUZvLH8ZKMdIxkwyXHzU1hHHUY
 0dkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:references:cc:from:organization
 :message-id:date:user-agent:mime-version:in-reply-to
 :content-transfer-encoding;
 bh=rztr4NGHqWzD6siFYj3viaENOEabJnVvCsfbB8qlyLA=;
 b=lDiGoSkkVFHd8mImAd6TTvhlXmFdcupjRBlcXB2IIT2TEEKuyKmRxTqneV2hZCLvCK
 0U+qa1ceTWqZAvik9o/Rvge3KAfL3bhIInNq8t6zKFQhwJYUomRaLD1MH5s2mZItGBEB
 1i+A7EBRqEd7+Z9D9yPk06qbaonLXoTDcmJvDmqzoK5uBUL+w2J8jf0bLYuWsBUAk8g9
 KdYOjybCX0Sdmkm+cUhXWdI61CPVZzUpeNkTirvRRP0D14AO6f0jHaEOcoSzoHzXHIfu
 RShGbbyO9jDktZGT18YrQU7LqG8VYVyt+wDNOtfjeYHv9a3ydrG/mkPotD+GzGboE4bT
 gMAg==
X-Gm-Message-State: AIkVDXJqB1jLgyH5oMIG9Zp7xH5+M66aTSmN9XACOcM6lRag3kqeWX6TscM4YIlYKwDE5yZz
X-Received: by 10.194.66.101 with SMTP id e5mr4164252wjt.172.1481920146002;
 Fri, 16 Dec 2016 12:29:06 -0800 (PST)
Received: from ?IPv6:2a01:e35:8a8e:1b70:18c8:ab1b:b2a2:b9be?
 ([2a01:e35:8a8e:1b70:18c8:ab1b:b2a2:b9be])
 by smtp.gmail.com with ESMTPSA id di9sm8333997wjc.37.2016.12.16.12.29.04
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 16 Dec 2016 12:29:05 -0800 (PST)
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
 <20161216190257.6921-1-ferruh.yigit@intel.com>
 <20161216190257.6921-20-ferruh.yigit@intel.com>
Cc: Jingjing Wu <jingjing.wu@intel.com>, Helin Zhang <helin.zhang@intel.com>, 
 Wenzhuo Lu <wenzhuo.lu@intel.com>
From: Vincent JARDIN <vincent.jardin@6wind.com>
Organization: www.6wind.com
Message-ID: <e50661f8-0909-1fd4-5cb4-ac30e23ffdd2@6wind.com>
Date: Fri, 16 Dec 2016 21:28:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20161216190257.6921-20-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast
 promiscuous mode on i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Dec 2016 20:29:07 -0000

Le 16/12/2016 à 20:02, Ferruh Yigit a écrit :
> +#ifdef RTE_LIBRTE_I40E_PMD
> +	ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id,
> +			res->vf_id, is_on);
> +#endif

Why is an ifdef used here? It won't scale to all PMDs.

I means that you are missing an abstraction layer.