From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A935A0543; Tue, 25 Oct 2022 10:19:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 360A140A89; Tue, 25 Oct 2022 10:19:00 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2046.outbound.protection.outlook.com [40.107.100.46]) by mails.dpdk.org (Postfix) with ESMTP id F39ED400D5 for ; Tue, 25 Oct 2022 10:18:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1r0ONQaAJB8wOzjiUh623zHOn009p+3n8QHYRjTjTG5BvxsWGRonJDTO7TSIrF/oknDYk4aRwTYoV4CzjjdwIGLn6NfkzJ0hCv4UHPDaMg/C24+UNxTJJYJTxph6RlzHYbSP73SYu4rLrhPIRQfZIBt/AN/snL94SjFB3cVVv38mIAgeYNDv1XaX4DE9WAXIPSnWey480JEJEGkvaFSJ58b6GWenqyTTXe9oR4aak5CdLw+/NTQ/uYEBghg0LPKm8jXdm8o8wGP9Ue2hzj522zG1iR28kpwiDUXzdpF6Hp8oi9npdMhEWjMcCvSigLwnTKXE2Ie35+sHvwgJk17tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXLZ9davS+b4CcsxgAjd93FkqAcfDGGFMPL6fqogCRU=; b=Mjl1hX8q3WxkbdU5kiY4u7/pbxagn+aqHnVLrnneOYfmU1aBTBmM8TaufdDgQ9N6v9ChuNCrzfrrKBpulsMumnEOumEeG5DydFLzrmP2va6SDGSa9E8BL5t//CRzHz95fSl0lLH6vgDjI3AhWeUbr65LA7EyrYYNKTDI5fgF+Y4nkDYO9uqi/kP+0ZbIwxGM7mPhkFPGvR22e3snHH3vyqkuN30yKFMKLl1JmSZC3I7qePdIYYTid2ueeVsOgJhHSNkI8JmkrrnEPRlCECnecpm/fxWepqZYaVkdzu1V4WsdDd/2bSYj5vlL8vPHr+ZwNZOVdQ94hSIMg4pb5jG1dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXLZ9davS+b4CcsxgAjd93FkqAcfDGGFMPL6fqogCRU=; b=hPyerWQQmFd986PrOIQOxhhwQP7heut6mlHlEkupGZh8cd3dSE256OqwRLDOcWsJ4309YL3lnTBRh3ByP4xDEu8mPDjvd4ZBOtOkHLBHRdv1KQEuJhDBsksz4C8g7BPx+cKP8eatFa4nOs/JkhIREltBP05PDXzEJ6V0AHRowZI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by CO6PR12MB5474.namprd12.prod.outlook.com (2603:10b6:303:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct 2022 08:18:56 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Tue, 25 Oct 2022 08:18:56 +0000 Message-ID: Date: Tue, 25 Oct 2022 09:18:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 25/25] net/nfp: support new tunnel solution Content-Language: en-US To: Chaoyong He Cc: oss-drivers , Niklas Soderlund , "dev@dpdk.org" References: <1666063359-34283-1-git-send-email-chaoyong.he@corigine.com> <1666427069-10553-1-git-send-email-chaoyong.he@corigine.com> <1666427069-10553-26-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0101.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::17) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|CO6PR12MB5474:EE_ X-MS-Office365-Filtering-Correlation-Id: 0820ab76-2091-497c-4286-08dab6618fa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dC9EQhCnHSrjM5ljYz59vwqvRk89sKX+YBheunIoUK0xB9mr+IE394fO+4nOKEZ2rh0Bup4Ycb65Enp8GgUovmW73A/vTpMym/9nvnvCPeSbxBDmIAo1K3BpGANS6TgzrLY4Iju0NKnsxqoKDku9GKTf5DfoxLT+BwMVb+di0EGgdKpJ3l2L1wFg9kkdff2XIvRRl1Qxrjp12np5Caig2poYuH/5A+M0nsFj6Wc91DDQKfiGFWaNgnhbqkYV6JPiHWeslwBNb2fG/ypMudBI9gBeqybV6LogrvH83UkYQk1XD77qw++rfhX3y9kAh0K6LyGi0IZpn+IgCB+QaGTr+GLQWqlPiPeEEgHxatvK1u+mrKpNgQBxIDWZbrU+WavSOKArq+G4jiljzS+KNLQebhbndeGRs/oKmG5RfjvxudMCez1GWVpI9UcTlyDHgYnhjiNX/r67vVploMDzbAArbH03faS+h+rx55a5aQ6FbvQBKvEgkhWxBaOM+SLKYy8OOd15Xb3GuIay43l1PK1o0x1a95504sOSQWzBL6QXcWxtdhyynrOftp0ufC/hlOvUK/kx400pDrs8oiAq3YvWcyfUVd9eQ7DxeQOO+nxpylwk7pNgoQxZtCyhu40uPEdpxA4trNoMOVS7wuF7Kevw2KYIF25/3H+Ef7qD+s3DmDSLeyd7VGlYQPhx/uS8Xo1VI+Mdsn4UDRJa+S17g1JhMgf9KYICY7Sv4P5QCgANtBi735i1JDsK09YbMphH1XKjsKBg4rOj4a0cRKltLcm8iDi+ywp2FDmM6A812quZ5us= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199015)(66556008)(66946007)(8676002)(4326008)(36756003)(66476007)(6486002)(86362001)(31696002)(6916009)(54906003)(316002)(2616005)(66574015)(38100700002)(53546011)(83380400001)(26005)(6512007)(6506007)(6666004)(186003)(478600001)(41300700001)(31686004)(44832011)(8936002)(5660300002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1JqOEVEdkpRTitQdis2YTBHZkV1cllYZFN6OE5uZkQvK2FBVm0wZVhrWFEr?= =?utf-8?B?bEFWL1NwakdvcFoxS0tJQ21sc1lFTEtuNk94MWFPcW5wN1VwOUNVTjBybUF0?= =?utf-8?B?L1dVamtLSW1GUWFZa1JNdCttSVhkeG4wbkR4RUZPUEo1Vm8zaktZem5WWmpj?= =?utf-8?B?cmJ2aXBIME5HdXZkNG9IMURWODMrZ2FhdE9tb3dIeEdkMVFwUUNRZGwyb29X?= =?utf-8?B?MVR3VTRUOWdEL25pQVlLcTZKZjVTa3VXcFUyaW5MckFzVVhKVjVsTW84NXJR?= =?utf-8?B?OTBGcEJKcU1kWVRDcmxITmxJRlluY2dmdjhuU21ncmRGLy9raHhCMmk0MnA5?= =?utf-8?B?RDJoOWlZNWxqT0d4cUxOUGJzOE1MbmI0Rmk1bnZja1NNMUJuNVNKQ3JCcDU1?= =?utf-8?B?UzFIUHpZQkxnUS9qSTdrOVNTNCtMaHVCV0pBS2hSVmdibFRzcHNVcDBMbVl2?= =?utf-8?B?WEkzN0RiSXZRZG1QZHZraFBhbWp0WDVvOWloYS9ZYTJTYVdhVmJBcXowT082?= =?utf-8?B?ZDBlV1puMXlVL2JWVmNXOVRrOU9EY2NwbU5OUlRQS3Vrb0crcC9vbE1IUktx?= =?utf-8?B?eXpXS2o5cjM1TmlKVkMxb1c0bGdlVG5TSnM0dERPM3hSOUNjV3lUSHlnK3R0?= =?utf-8?B?bkRqaHo0d1preDhFdWhPQlpZbTd4UUdoZCs3eWoweCtCNk5uK1VIZmk0ZGVQ?= =?utf-8?B?S3cwN0hTem5nRnVTTmRGNGE1Uzgyclk1TDVzZXBzR2dHUkd1bmVTV0s1dXo5?= =?utf-8?B?akR0Ui9vYjByRHp3ODZHeTJEWUMrS05Fem5VM3ZJZWpualFzRUxiTzhpQ1hn?= =?utf-8?B?V3grTGoxOVNHWVBtUWdIS0hWdHpEMlZPLzM1OEluaWEySmdxVGtKbk95Skh3?= =?utf-8?B?QlMzN1JPRTlYUDZTL3hPMUt0djAyZmlEcWpxamFGTEV6RFc1TmZVWGpLZVds?= =?utf-8?B?OVprTUh0YXVQRnpPcDJETUprVTV2SSsyamlyZVp3cjJFbjJXc2p3NmVXMmky?= =?utf-8?B?Z1F3d01tVFBtcnJ0dE1tdkU2QW45OVk3OFIwTkJBcmxUaVJObk44dURRa0FP?= =?utf-8?B?b3l6QkFyL09nck0rVTBUbUh0ZldGYWVLTGVhVDZ3ZitJR2k0c3J4UjI0M3pQ?= =?utf-8?B?R0lXVDcrbzlRTzl2dSs5VG1zUkNTRklZRGF4RUhNZlpmL0xjdFJDVzBkOGIy?= =?utf-8?B?N01qOXI0SzdHUU4yM3JxQTFGOFRjMlI4YTlEeEhjT05KQjNEaU96Y1dRbnA3?= =?utf-8?B?aGhMaHRGTzdrb1JINVpaQ2NpRXFEbjVtK1AwZ1FDVXMxaGRvZ0VCbjM2SGo3?= =?utf-8?B?THFZYUtPd2NuSFJhUXBXRzF3cTdRZElkVTl0dm5sL210RGx0Tm01ZmJQQmJ2?= =?utf-8?B?NGtIVjY3cUF5K0ZjMU83UVErcWxrNjVHdmNtU3JlQnp0bGsvdlIyZUQvYmJw?= =?utf-8?B?N0hQa0xoanRWNndkVnplc2wrWW0wckYyQXliNXpPSFk0UDRYc254UDBKSkNI?= =?utf-8?B?QW5tbE9wSVNNVWp0RUt1ZzByV2hJYjFXTit2bXhyRWh1Vi90MjNRS0phOXJO?= =?utf-8?B?M3JFTkRFMSszcFdCUG1iRGNlNk9BcjZtblRwSnN4N0RIU1BzaFZLMThPUVVH?= =?utf-8?B?L1UvcHpWY25XVWQvcEZxNDQvUm1vU3Z6eHFsNWhqVldta2ppRm5Db05GN0tj?= =?utf-8?B?eDg5a3FOZFRUdTVJaHdoVEFtUmh1VUE3NjBnU0hhekRVRW9sWnJtZUxlR0dn?= =?utf-8?B?WTlUU2pHczZ1aExXMHdkOFNMVGE5Q0pDb1R5Q2J6eWtTVTVkUEFnV2RpSmtY?= =?utf-8?B?TGFWMC9sWTZpNnRNaUlPRERXUWtMK2lEc0lmYmxaL2l2QW5WeVJNVC9WdFg2?= =?utf-8?B?akZ3UHIyN3F0UFd2eTJFMXVtL2FDQkR4N2FMcWoyaXlHUzk0cFYxdHZZdy80?= =?utf-8?B?Y3lkbTNKL0JEVlVNalFXTjErYzhEa2YyUDhqVkZhWUo2ZHA3Y1lMRkI5L2I1?= =?utf-8?B?Z2Q0MEtjRG1Help1cWkwMmp3ZDZURlE5L3lUUXVPYyt3MDFCcjU5VW5lMk9R?= =?utf-8?B?UDJKcGxnbHMwYUh4aEtvNnBiMGFvMWFLOUhEU055MytwaGJoSWRjZ0M3eU5P?= =?utf-8?Q?gcV0kkRq4JLOZZqeCyXUnMiaG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0820ab76-2091-497c-4286-08dab6618fa4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 08:18:56.6380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LwD9gC6V4wvhROMlGB1QpaccvGC40nxu0Ds7TrWBZNq3EkL3/Ri27xYSVWjznNdS X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5474 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/25/2022 2:44 AM, Chaoyong He wrote: >> On 10/22/2022 9:24 AM, Chaoyong He wrote: >>> The new version of flower firmware application add the support of a >>> new tunnel solution. >>> >>> It changes the structure of tunnel neighbor, and use a feature flag to >>> indicate which tunnel solution is used. >>> >>> Add the logic of read extra features from firmware, and store it in >>> the app private structure. >>> >>> Adjust the data structure and related logic to make the PMD support >>> both version of tunnel solutions. >>> >>> Signed-off-by: Chaoyong He >>> Reviewed-by: Niklas Söderlund >>> --- >>> drivers/net/nfp/flower/nfp_flower.c | 14 ++++ >>> drivers/net/nfp/flower/nfp_flower.h | 24 +++++++ >>> drivers/net/nfp/flower/nfp_flower_cmsg.c | 4 ++ >>> drivers/net/nfp/flower/nfp_flower_cmsg.h | 17 +++++ >>> drivers/net/nfp/nfp_flow.c | 118 +++++++++++++++++++++++++- >> ----- >>> 5 files changed, 157 insertions(+), 20 deletions(-) >>> >>> diff --git a/drivers/net/nfp/flower/nfp_flower.c >>> b/drivers/net/nfp/flower/nfp_flower.c >>> index 41b0fe2..aa8199d 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower.c >>> +++ b/drivers/net/nfp/flower/nfp_flower.c >>> @@ -1074,6 +1074,8 @@ >>> nfp_init_app_fw_flower(struct nfp_pf_dev *pf_dev) >>> { >>> int ret; >>> + int err; >>> + uint64_t ext_features; >>> unsigned int numa_node; >>> struct nfp_net_hw *pf_hw; >>> struct nfp_net_hw *ctrl_hw; >>> @@ -1115,6 +1117,18 @@ >>> goto vnic_cleanup; >>> } >>> >>> + /* Read the extra features */ >>> + ext_features = nfp_rtsym_read_le(pf_dev->sym_tbl, >> "_abi_flower_extra_features", >>> + &err); >>> + if (err != 0) { >>> + PMD_INIT_LOG(ERR, "Couldn't read extra features from fw"); >>> + ret = -EIO; >>> + goto pf_cpp_area_cleanup; >>> + } >> >> Hi Chaoyong, >> >> It looks like there are two flavor of the flower firmware application, one with >> 'extra_features' other without it. >> Does this worth documenting in the driver documentation and the release >> notes? > > Actually, it's just two different methods to process the tunnel decap action in the flower > firmware application. > > The old version flower firmware application needs 'tunnel neighbor' and 'pre-tunnel' table > to get needed information to decap the tunnel packet. > While the new version flower firmware application extends the 'tunnel neighbor' table and > does not need 'pre-tunnel' table anymore when decap the tunnel packet. > > The app which use the rte_flow know nothing about this difference. > So, should we still explain this in the documentation and the release notes? I'm not quite sure > about how details should we expose in these documents. Thanks for clarification, if this is transparent to user/app may not need to document.