From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
Randy Schacher <stuart.schacher@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error
Date: Wed, 6 May 2020 10:13:54 +0100 [thread overview]
Message-ID: <e5184943-eac1-5d29-3d80-5013bbe128eb@intel.com> (raw)
In-Reply-To: <20200505191738.58219-3-ajit.khaparde@broadcom.com>
On 5/5/2020 8:17 PM, Ajit Khaparde wrote:
> Fix uninitialized variable error reported by coverity.
>
> Fixes: d33b68154fa4 ("net/bnxt: add tf_core table scope support")
The commit id and the patch title doesn't exist in next-net (also not int
next-net-brcm), I guess you mean [1] but the updated function below
('tf_em_ctx_reg()') even not exist in that commit.
Can you please check the tag again?
[1] net/bnxt: support TruFlow core table scope
> Coverity issue: 357771
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
> ---
> drivers/net/bnxt/tf_core/tf_tbl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c
> index 93f387e86..d900c9c09 100644
> --- a/drivers/net/bnxt/tf_core/tf_tbl.c
> +++ b/drivers/net/bnxt/tf_core/tf_tbl.c
> @@ -539,7 +539,7 @@ tf_em_ctx_reg(struct tf *tfp,
> {
> struct tf_em_ctx_mem_info *ctxp = &tbl_scope_cb->em_ctx_info[dir];
> struct tf_em_table *tbl;
> - int rc;
> + int rc = 0;
> int i;
>
> for (i = KEY0_TABLE; i < MAX_TABLE; i++) {
>
next prev parent reply other threads:[~2020-05-06 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 19:17 [dpdk-dev] [PATCH 0/2] fix coverity reported issues Ajit Khaparde
2020-05-05 19:17 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array Ajit Khaparde
2020-05-06 9:17 ` Ferruh Yigit
2020-05-06 22:14 ` Ajit Khaparde
2020-05-07 0:09 ` Ferruh Yigit
2020-05-07 3:14 ` Ajit Khaparde
2020-05-05 19:17 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error Ajit Khaparde
2020-05-06 9:13 ` Ferruh Yigit [this message]
2020-05-07 18:55 ` Ajit Khaparde
2020-05-07 21:15 ` Ferruh Yigit
2020-05-06 1:40 ` [dpdk-dev] [PATCH 0/2] fix coverity reported issues Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 " Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 1/2] net/bnxt: fix overrun of the ulp device params array Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 2/2] net/bnxt: fix uninitialized variable error Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5184943-eac1-5d29-3d80-5013bbe128eb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=stuart.schacher@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).