From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D1FAA059B; Fri, 10 Apr 2020 11:28:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C7551D416; Fri, 10 Apr 2020 11:28:07 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 99C1A1D412 for ; Fri, 10 Apr 2020 11:28:05 +0200 (CEST) IronPort-SDR: kf6o36+ZXlHYWWP2TES8hwAFVM3FWfSkuybJiFuAFKFJkVDRoKDFqgwKJSyQp4Np5Ac8IuhM9T ZkN5CO8HBROw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2020 02:27:55 -0700 IronPort-SDR: 3tkL4PSishaV1J5SV0/dwYfKNZbU5HqEf8FEn/STiwWQsQ724cFKtDnlwOQh8qoK/aNA8ZcqK9 sZ1SbPL57X8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,366,1580803200"; d="scan'208";a="331131794" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.17.204]) ([10.252.17.204]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2020 02:27:52 -0700 To: Thomas Monjalon , Jerin Jacob Cc: John McNamara , Marko Kovacevic , dpdk-dev , Andrew Rybchenko , Adrien Mazarguil , Ajit Khaparde , Jerin Jacob , Ori Kam References: <20191025125118.47189-1-ferruh.yigit@intel.com> <1689523.vCJZsxu672@thomas> <3196060.usfYGdeWWP@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Fri, 10 Apr 2020 10:27:52 +0100 MIME-Version: 1.0 In-Reply-To: <3196060.usfYGdeWWP@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2020 10:20 AM, Thomas Monjalon wrote: > 10/04/2020 11:04, Jerin Jacob: >> On Fri, Apr 10, 2020 at 2:26 PM Thomas Monjalon wrote: >>> 10/04/2020 10:44, Ferruh Yigit: >>>> On 10/25/2019 2:39 PM, Jerin Jacob wrote: >>>>> On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: >>>>>> >>>>>> 25/10/2019 14:51, Ferruh Yigit: >>>>>>> "Flow API" is a method/API to implement various filtering features, on >>>>>>> its own it doesn't give much context on what features are provided. And >>>>>>> it is not really a feature, so doesn't fit into feature table. >>>>>>> >>>>>>> Also since other filtering related APIs, 'filter_ctrl', has been >>>>>>> deprecated, flow API is the only supported way in the DPDK to implement >>>>>>> filtering options, if related filter options announced by PMDs, listing >>>>>>> "Flow API" as implemented is redundant information. >>>>>> >>>>>> I fully agree with this explanation. >>>>>> rte_flow is the only supported API for flow offloads. >>>>>> That's why we must remove the legacy API. >>>>>> >>>>>>> Signed-off-by: Ferruh Yigit >>>>>>> --- >>>>>>> --- a/doc/guides/nics/features/default.ini >>>>>>> +++ b/doc/guides/nics/features/default.ini >>>>>>> -Flow API = >>>>>> >>>>>> Acked-by: Thomas Monjalon >>>>> >>>>> # Need to remove "Flow API" from doc/guides/nics/features.rst >>>> >>>> +1 >>>> >>>>> # Need to remove refference of "Flow API" from "doc/guides/nics/*" as well. >>>> >>>> "Flow API" is the implementation of the filtering, it may exist in the nic >>>> documentation, only it is not a feature on itself. I will scan the docs for usage. >>>> >>>>> >>>>> Not specific to this patch, >>>>> Probably we need to add a new matrix to enumerate PATTERN and ACTIONS >>>>> supported by each PMD as a rte_flow feature matrix. >>>>> That some else can take it up if everyone agrees the semantics. >>>>> >>>> >>>> +1, there needs a way to figure out which filtering is supported by a >>>> device/driver. It is not documented and it is very hard to got it from the code. >>>> >>>> Not sure if a new matrix is the good way to go, but I agree we need some way to >>>> clarify it. >>> >>> I think we should split the matrix. >>> Adding a new matrix for flow offloads looks the way to go. >>> I suggest 3 matrices: >>> - port-level features >>> - queue-level features >>> - flow-level features >> >> Not sure what will be the details in "flow-level features". >> >> IMO, We need to have a separate matrix for subdomain features for >> rte_flow, rte_tm, rte_mtr, etc which part of ethdev. >> For instance, rte_flow features can be translated into a matrix of >> supported PATTERN and ACTIONS. > > Yes I'm also fine with this proposal. > My concern is it will be too big and detailed, also hard to maintain which means it will be out dated a while later. After above said, I don't have a better solution right now ...