From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01C7F4565E; Mon, 29 Jul 2024 15:13:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D45540A67; Mon, 29 Jul 2024 15:13:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 9776040674; Mon, 29 Jul 2024 15:13:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722258812; x=1753794812; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=vjWjdUIg93QyVT63kclLW/gStIlEBAYVTU0FYpLWJeY=; b=XYixzGeB+1E1S15Rk6oaQeavS3GdSjXwBVwmeUtWsemfdrNsxwZptPwc NanLvrIIKcWJ9AMdQeg02tx5Z17jGypKalk9shOSdVwows9kgTlGZBGKZ TypnYS9zNitwht0ivqiaBMfr3jKKG9zLI5tslZ93lM1FKwE6yxi/bUCE1 xGRWpizwHj9CM8k4C43uR9pmxId8tGyk6rff7x3OhS/2ZZVUlFza3xblj DoR5SjczUgD3oIzuZdVwQnhc1n5i686Fu/CdDJHxeHPtf6Uqfeb0DRvx/ BLQs/LcUU3qMQUEmq0qibDep00JirS/mGxd393Cn7QkZBeqotVwVMymVz A==; X-CSE-ConnectionGUID: 45/JTRp3Qi+q+MDpdzeBuA== X-CSE-MsgGUID: i+SSCbOmTjyPXY6Ad+5zzA== X-IronPort-AV: E=McAfee;i="6700,10204,11148"; a="31161800" X-IronPort-AV: E=Sophos;i="6.09,246,1716274800"; d="scan'208";a="31161800" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2024 06:13:30 -0700 X-CSE-ConnectionGUID: uNkuI6E6R32y8Bv7Mb28yg== X-CSE-MsgGUID: tRyzJlW2RjWVBpkzyFfmxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,246,1716274800"; d="scan'208";a="58817662" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Jul 2024 06:13:30 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 29 Jul 2024 06:13:29 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 29 Jul 2024 06:13:29 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 29 Jul 2024 06:13:29 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 29 Jul 2024 06:13:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rMYunVmsnde3jyCrnfNpLddGaiXN+P3Y0S/6CS/WgdVUrzdIx0xVgOGNexWUZPCwawVAnbnUsAF7u2T1UNLcZALxsLjfaKFgqlk8zL0apd/up2hR27yeJRhOjfmNm9nMAfty57arb3zWk1oxj3E5kHsj2G50PftaCCybRfodj8b0W7kMAwXxN/BWmbNS1E0oFwAiKaPJmeKUZgw8ReEJiKxNidpDwLlRVsUVpMr8C62keTPr92euM7iwLrmD82nzL1D+2MXtnR2wgsZ+JSB9s9wm6n8qRn3R2f+l+esw6pJpHP5x4azQ26EdN/QKtv7AyWnCk7jHsBlS9yxHgufNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjWjdUIg93QyVT63kclLW/gStIlEBAYVTU0FYpLWJeY=; b=AiOXE7BX9EHAo5Z338Or5yJVdJ/3Iio5A8DmZtGYscL2FBqROx4LVRkc9fvQI7PjGyjOLlKs9cxpGSyDWUxpGXuoy2TMzx1l4YhmQ+lrmGciIqLW/ERU3pIBI/ZJBqCFnR3NKu5yzmbj6l6BWogXEvy46pd3z/snjgNjm4PNDTD4uZu1K8cHGqAhaFNscDmgrZ9yBKy6fEaHUIb11swdlCPz8IbNupQGaY6CMmbufE4cnMR6kDtF2n6qzbVDw/VQwcqe36xaQm+C3fXva1syfREEGUdNg7bGd1w6Vl6JZSGTztVCAPsBM0h5u7ZEK4NrNsFzYB6OWiqpmBKld0ijRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by SJ1PR11MB6082.namprd11.prod.outlook.com (2603:10b6:a03:48b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.27; Mon, 29 Jul 2024 13:13:26 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3%5]) with mapi id 15.20.7807.026; Mon, 29 Jul 2024 13:13:26 +0000 Message-ID: Date: Mon, 29 Jul 2024 14:13:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] examples/ipsec-secgw: revert fix SA salt endianness To: Vladimir Medvedkin , CC: , , References: <20240729125754.939818-1-vladimir.medvedkin@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: <20240729125754.939818-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0296.eurprd04.prod.outlook.com (2603:10a6:10:28c::31) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|SJ1PR11MB6082:EE_ X-MS-Office365-Filtering-Correlation-Id: c1b7c59a-6fdf-47de-032e-08dcafd03b0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N2VNbFlSZ3NpTlV2K2xnNnFyaWNZS1lMMSszdlBQaVVEZGR6Z0dYWXpROUsz?= =?utf-8?B?ODN0b2l1Mkk0d09kQWdhM2ZQd04vNmx1cCtIUzdERVhMTGc5U1h4YnhIKzZY?= =?utf-8?B?OTBydWFCVEhpWHFiWkRnc3YxUXNoV0tvMHV2ZlBpZHE4emUyUEhwS29ldFNB?= =?utf-8?B?RDFqN1RXcU9ic3doV3NYenA5K3k5WlowOUthTEI2OGw2QVpiQ3NPQ1owSThG?= =?utf-8?B?KzhvbjhjMXJua0hRYkhxUHFrTEZGcXdodHhVc2ZvYk5CWFZqUCtBV015UlFE?= =?utf-8?B?TnVocmViR29lZlZwa3hERXYrQ3pBYVRFalZobThKZXU2WUMyV3l3Ymh0NnFk?= =?utf-8?B?VjBSTkdtenZCcGtmQ0h0RG9UZWJMRUxHNGpoVUMraW9RN1Zna2cvaE1PUGtz?= =?utf-8?B?V0hrZE9nYWhvcmxFYlp5T0lXUlpGNThWZGYzVVpsbTZzL2FxcmpUdUZnNXcw?= =?utf-8?B?akI1L01BY1pPZElFaVREcHNjN2hNa1hRckhlNURFcVNZeWlId21sakJUcmNM?= =?utf-8?B?c2w4Um04b05oTXhtOFhrRkdSV05hK3FoTVI5NThjcVBWZXlwMEVDWHlIcDdw?= =?utf-8?B?Q1FodUhLbmp0T09BVFo4VjZkQk1QMUdNZ0xMbjJ3Sm1OaXFDL0Z6eXBYY25R?= =?utf-8?B?U3NKVll5ZVRydDVNWWZ5NlBzSDZvVkxpem4vYlpDRGpFbnRPeHJ3WEpJemZu?= =?utf-8?B?aEoyWG13QkNrZ2RQQi9CbHFHQys1Vmx2WFhtMG1nZllEc3lXRERjcENmdTF6?= =?utf-8?B?SExGbEl4Z2pqVFZ2M2xXdE9XQ3NqN21ObnBUWXZYOEVyZU9WbklBNXQrRzEr?= =?utf-8?B?d3hhcmxHL28zdndaUE4rTHdwT3ZaU3k2VW5pblVqQmRWNjkzNVJvd3JuRUVF?= =?utf-8?B?VEJLem92bW1CWTlUTVd4QTQrb21reUJmTTIrbnVHS3pSOHNJeUpjcnlUUmNP?= =?utf-8?B?WUxWcVNwTFRqUk9QMk9mVjBaSmE2NXFXODROc3FNOFhmbFNWcXR2c05aZS9Q?= =?utf-8?B?L1hLUDVnQTgzL2VmQk1RK2w3Y0FoaVM4WEQ5ckZ3NDNXVXg1aW85YmZGYnhI?= =?utf-8?B?cW55RjdmM0hhWnRnM0xrcVUzbzJMMGJkWWhIYnpXdnZXcGhESEpockVDRDZu?= =?utf-8?B?c0M3ZElrTC9UVGxlVlMrczFvemxvb0FDd1B0Z05LZjhvMXJVVzR3WGNJR3ZQ?= =?utf-8?B?NXMyVVZtSkZQUGdNNzVpWjRhUGFyUUxzNDBTRUNwbFZMN1VLNWtsT3oxdjVK?= =?utf-8?B?ZG1TVC9ZY0tBY1RFdURDNWxxQ2JVNzlBd1FPOWI3Z1JJenMxcUhtVlkxMUZp?= =?utf-8?B?ZFgrbU52QmMyYkpiUGxCK3hYeEI4eERHR1NJMDg2M0xhMVU3dDZjOUhENzlG?= =?utf-8?B?OVl1UFcvOFUrK2U4KzgvanNXR2pxWE0wTEhvNXMwZW4yY0loRlo3bG1OSTkz?= =?utf-8?B?LzF6VC9sSVlwSGdwWGs5bStkQkFkcC9FK0l0WGtNK3UrcnUxSW8zcEdBNUZu?= =?utf-8?B?aHpaa3ZuNS9zd3IyK1hVYU5VclhmNjdCbWNreVQwTU9Iajc4RTI5RUUxWEZR?= =?utf-8?B?bUIxakM3dVVMclQ5VXVia3daeWgxM3hBUEhJS0EwSmVzUnR2d2ZmTkd0SEFJ?= =?utf-8?B?WThLbVhYZDhyZzFHMElsWVpSWitiWHhERXpFWncxZVdPd0tEamM1bUtIblJ5?= =?utf-8?B?aFRCMVRFbEZPWnFGYUd1RHVacE5mdDVEcnh6T1lKa1pUYW85NnZnRWpwck5Y?= =?utf-8?B?WnZpTTdYNnMxbEcwbVdrR2p1K1JkUUtLSjBWb2E4V3MySEVCQVcrL1I2KzNK?= =?utf-8?B?Tm9XbGtDVmNQOVhPaGxydz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVA0czZlRy9RS1JwRk1kQzIzT1NDQUUwQmIwWVRCeHpIVVJjYnRlUytJaXor?= =?utf-8?B?V3QwSXFNdXVEVGRGaVpWT1l3c2phSk42STlpS1NJREFhSFZyTUpLTGpCK2JR?= =?utf-8?B?alhwWmY2RzN2QkxEOVBVai9aV2hpTGFFRlVLK1k3dFN3c2hWWVpjN2VoNytI?= =?utf-8?B?Qys5N0ZWbGZmNDVSR3lJbDVDNk01dW9vRytEb2hBbFRiZmRPOXFTaHp0VUJq?= =?utf-8?B?bmxRWkd3a3UyUy9pbnNGNmxmTkljWitvRUlvSWFNMEQ1eTVnenExTGhZd0l0?= =?utf-8?B?d3hIZURIekUxdC9Fd054aGRiZ25YenRmMGF5aitBSWFGTXNWZUV1OHU4K3k1?= =?utf-8?B?bHVFSlVMOU5NUkpFSVpZSmFVNUtOdnNkb0xRMytUOHlnL2xuV01jTXBEMi9j?= =?utf-8?B?NC9NSzdVZGdmS2xKalBQNGxQNFVUbXRrSGgyY2tTZUFST1NETktULzNxVEp2?= =?utf-8?B?ZGUwUktSSTFvQ3VZblF4SFlIOXByOEp4bDI3QXNoNGNVNUZ2QlQydVhYVkh0?= =?utf-8?B?MndVR2RIN0ZXa2liVzJ1RWRtTFhxemxYVldGNFlYaU9Qa0d4NndoL3BLM1Ax?= =?utf-8?B?RUVaOG1NWW1sVTkrcHROdXhERVYyUjhGNEV4V0gwYkxpOWJLbm5lcXdGQjQ1?= =?utf-8?B?N3pKRld1OGVNN0J0Qlp3eFV4cnBOVnowL1lCRGNMeXBydHdsMTBWRGdHcnlh?= =?utf-8?B?Z1JNWHJsL0NZV1kxM3lVMm9RN3czTnhaRGdrczdzZVFpZGZlbS9jREVKRzEr?= =?utf-8?B?alB6dTRoLy91WEtJZ1pJaEVia2craU1ZejVoblFHd1owN0FDYTYxLy9Uck5y?= =?utf-8?B?RlkweTloeXpVQWZ6VEN0UDJHL3VMUzlBZU13dkw1ejRtT2grUkdJd0tKME83?= =?utf-8?B?UXNlbFNlVnEzU2hsN3VZc1NuVzQ3OXprODFmZCs3T3NwY3ZxYlg1SXlYQWhq?= =?utf-8?B?Z2JwSDR3R1hVSThEQ3N4dmQxSUo5ZzNJY1VXN0VQU1hwVmtFRGo1Y3F4blYr?= =?utf-8?B?MVhlYm5UYkIxYVZKNkRIK0JTc0ttUUx0SUJlWEJ0eWtPd0l4SjI4TUZLL2s0?= =?utf-8?B?UzV3dFEwTE5aWmVwSVpZTEFqeXVmNllwQ0NZQ2Q5MzhJU1ZEclNab0xhdmJa?= =?utf-8?B?d0czZERvR2NtNjNhM3lzVEQramc1NFdoVWYybE1teVFkYWFKM0xkTzhDdHF6?= =?utf-8?B?K0RZOVdVNkxWSDc2Zmc4Y1hYbHhGMyttVWJQOGRsMnBBMGgyLzRQbGNMQWFz?= =?utf-8?B?Qkh6THk0Wk1NeGU3V09LWC9vcTczL1VGQXQzOXpDMEkrdE5laTNNSjVrRlhZ?= =?utf-8?B?SGxCR01rN0I4L0h3cWpYZVJFTHhWeTQxM0dGWG5QVWN1L2lwRTRZQ3dKR1M0?= =?utf-8?B?eXQzVHk2S3EwZnFFaFIrVDE4R1lNcm1oMmpUUnNlZFdLM3p5Z2Vrd1locXR0?= =?utf-8?B?NDVwK3IzUkdKU0RkUnNDMjZKQnh0dkREVWMwaVpoaFZHbG9qNlhYVC81dTYy?= =?utf-8?B?cmRRUmZ3WkxFNkRPQmtUMnpyVFJjSGd6clgybmNtSVJKVUF4SDV2N3RLZTln?= =?utf-8?B?eUJFY1Q1Q2FlQ2tUdHUxb0lvMTY2R09tSU15eWZDTnJpQzc2SGxVUmQ0TWow?= =?utf-8?B?bkFEQitLQVN0c2grMGROaEh0SFFJclhZTFJ2SlhrQVcyYmFJNkRldjdPQ0lH?= =?utf-8?B?bTFGNnpmdmpiT2p3cjRjWCthWmJLSE90N0VzN3F6bUdCVDlpNWJxV2dvYWtz?= =?utf-8?B?a203Y1lZTGJ4MlhrQnRIUnJOL1VPVnEvdmNnMmkyRk0zcmt0dE16Z2NGNDA3?= =?utf-8?B?RFFMblQ3STAzOVBmNy9zb251Q0pyRVNFQnlZTUl2bWVRc3VSL3JnYk5JOUVm?= =?utf-8?B?LzBWMGRHdEJiSDhMUmk1elBsN2xtNXNNM3RRanRyckptQ0FENmlMM3V0WWNy?= =?utf-8?B?ZktFcVdUUGcvV3JJdVUwM1dYTUl0ZlRTMXFXcGdLZWpYS2lhTlQxdENYb2FN?= =?utf-8?B?ZEx1c2dla3RTSGg3aGRPR2xrcXd1VjlFa2RYaXZXbCswZldIdmVIWittVUxZ?= =?utf-8?B?all2MmdQWWlmVnFkSnozNUlXR1VPWXI1elk5SWNiSkt4OUJabWpKdU5TVk9E?= =?utf-8?B?SWRVVk9CNWFpYjN5MzhEVlM4ajFpRGJhT2VVNTJwdjRXTUhGZnA0b1NxOGtz?= =?utf-8?B?Ymc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: c1b7c59a-6fdf-47de-032e-08dcafd03b0b X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2024 13:13:26.1309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +FnneYdYHqJQ4hVNez4ZarMdnAN91FmbU4nkDKLzG6oBlCmy6zdfywk2BWkGY14SpGi4FJy6yNCz22snWWjG1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6082 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29-Jul-24 1:57 PM, Vladimir Medvedkin wrote: > The previous commit swapped the bytes of SA salt which > led to incorrect work of the ipsec-secgw application. > This patch reverts the previous commit and changes > the type of the salt field in the ipsec_sa structure. > > Fixes: e6bfd9676109 ("examples/ipsec-secgw: fix SA salt endianness") > Cc: shihong.wang@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Radu Nicolau