From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91A79A04A6; Mon, 24 Jan 2022 10:18:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DCF0427B3; Mon, 24 Jan 2022 10:18:38 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D4B1840040 for ; Mon, 24 Jan 2022 10:18:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643015917; x=1674551917; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=tSMLplOlWQO0HXkoR/2uEJRP3wc8kygY9KY9bEmDauw=; b=LSowaltBtysEMhtbGNZaZf08gkno7X/4Ab+iicMSAiHtqqYKZsQleyDH nmSI1XwMbeMooKaDHXO3hQ8pV3ipVcmI9JTTVrROK+K+9zGaotWG3Ctmd 4ca6omB5+TzYtAKd5yEKtgzaHe+2DwzOrX/Hwn+e3D0hDGm+NGN2OOuUx t6k+z93tovZ0VrO0jRuVtaAgWE6kBExHme531mxEWsXAcZkDzXAVqo3qs DqEGbrdJglqlS4X9CnMMr4GJRUKLNGsPaxwru6o2J0JO+WGnEg/Q3W4TJ UuPGk2hydnh8v4v+/Ff+aloKhSVQROk8D7UsrkBRDa262v9YQtNR1L6TG g==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="225982812" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="225982812" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 01:18:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="624021897" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 24 Jan 2022 01:18:29 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 01:18:29 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 01:18:28 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 01:18:28 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 01:18:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=naeqGY1s3h/1kct+Gu5M9LfDo3cFW55qT/kMmBwiw2CkRIgtdKWZL8nqJ0QApLSRqBZcOLby4gpvR8FycQRuSk5KZRuQPRiPY4+Zk5Pw3eqCzM71KQajwiDapS6UuO624k5xzwvZWwDKHDLc/ZkSN667hzG7/TSr6B51sE0iq2PBpVRHlT2jrUvPZNjaimqXX9+IXm+2rskgzfKUv8/fvM71j3h+rnbimBqvQHrjenU+AUjx9+csPFViduAzvTlRLKsmhOONodPgXpcpWiL7WS3uQWv6ozqI1evmlUNGwpkYbywTK6dBEGBwyI4PpOuxYXwapXVkijnJjYWzjcU9TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYyVvehk3+BrqcmbD93Bc2M+ypnbSm2wrT+dE1lT6xk=; b=K4yoULsk6rD1coxSsPZ7UZuR59gNkdvTaE6nUX0i39uULK+jcOYQ0aXUWBNzSZt+HeXkeJtlAefAHOK5cAAHgwMIX9ErULTjsi3nsjwTnLALxspCZjf/WwCwrx+37YhyCDBB6uUo8EskWuPiUsApYwxzP+h2w3oqdTuF0ZOqVINYeA5q62NtJRWb5ksrUp3szcESQ7X5GfUjev7AtP/eUEXKSyKHBhczdkbFtPZokFd5mByMVdduWUKRZi0/Dw07eaLJXIaqc9//vlMHrdM6ludLxydqnOVuWx6tkZ9gzqcjH59R2qmtkiXPOzJGgC+ayNwSqv3Xo8ZGJF1D9qGXKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CO1PR11MB4833.namprd11.prod.outlook.com (2603:10b6:303:99::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Mon, 24 Jan 2022 09:18:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 09:18:26 +0000 Message-ID: Date: Mon, 24 Jan 2022 09:16:20 +0000 Subject: Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments Content-Language: en-US To: Kevin Traynor , Xiaoyun Li , , , , , , CC: , Sunil Pai G References: <20211015051306.320328-1-xiaoyun.li@intel.com> <20220106160333.762686-1-xiaoyun.li@intel.com> <20220106160333.762686-3-xiaoyun.li@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0093.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe6148f4-8d0f-4397-0f9b-08d9df1a7a58 X-MS-TrafficTypeDiagnostic: CO1PR11MB4833:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VPvNjPMcmqlV0TChVMMES+sJ4KkYC6ZdFTtCgva2yeDq36WD98LWX/dUeWPfC0QYw0rfrFiQlATv3DKwxZNccTIEWAhewFkCB5SDjcuWfRG+6wQpMjl9K1GcBuOKJQ4TMbwh5L8uPtMYejvWOYm1+ZNanPCLdG1hqBtrEUJ3ycHBAfF2O8jLJzi26DA9M8F4ugD5fJTAlo129RJ8hSEIw0BazefGUaAHiiaLAu6JxiM3zE2cYH60tt4NVK09G2rKMnqevyib3KxnoyAcKRlfSxcEyaLxZQbLVB6zIM3BsRz6i4N66ZhtOgBdFVQQdS0+LOuB4I63c9Htq+XePbTsL2QQG+EHKxAT/J/kQhAlrTD0OEiMUtw8JJ4HKqf4HL4nbEa+LS0JuLoI6kKRyh4dNFU9uNdSAb9Zwg/USMC9HVKottV+09AJlPy2WejiCbwHIDlwwe9N00SLelZn7rfJ+sDylcIQxo1bs7gv2zMJZDbucPADBcXzl5gAgbykPbCtTcYg472+fhj20XvELCq+U0ESFtZR082qAO58Mw4iaZBEQt7Hw1mgTRgaP+BEx09WQuCH5wmt65YHOxEkR709uOO/8fXwTH82PjBKKwJ76+8C0gquZHb7hdGgxj5SR+7z86uqm/IHfDRLOtYDnRGrh0fwFJf+mqeR/lfHmrh5+E8OcDjAPU7XSkVdgASEnmXIXamgPKJr5moSYANGXGvibg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(66556008)(31696002)(38100700002)(6512007)(82960400001)(4326008)(66946007)(26005)(107886003)(86362001)(6666004)(6486002)(8936002)(44832011)(4744005)(66476007)(186003)(83380400001)(8676002)(2616005)(5660300002)(6506007)(53546011)(6636002)(31686004)(36756003)(110136005)(2906002)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWVoTFlOcVVWem0wd2ozR3pMWjk1Y05rSUgyYlM2TVdVNDRXbHBiNkpHZXds?= =?utf-8?B?ZmZ1emI5V0JsVDVXUUhHcGI5aWdxRHFsZVlzUkNYcVJPWTFESFpVelJFSUwx?= =?utf-8?B?WkRPdXllSk5VUmEraGx5dEJCeGl3bTl2elVxWllmdno2SDdRUjZVQWNQZGkr?= =?utf-8?B?L1N4YlpIZlJuSW9XTlcxdzNHRi9DYUg5TDRvVFhGdEd1SE1VWnBrbjZNaTJC?= =?utf-8?B?MFl6QS9uOXVjcXNrTGh3ZkRKcEtnM2huU2xTRC81ZkswSllEbGdYaWxRb21m?= =?utf-8?B?VTdzaUZzRDRFVGpkSUM4M0VsN1cyK0c2VnpCcmR3bXhILzlEMjI2OC9uNEpw?= =?utf-8?B?czQxMVVyRldOK0tBVEFFdUtlTm90bGtKRlB3ZzFkMUwvb2RnUFp5RTdPOGhQ?= =?utf-8?B?NDYyOTM2anZJbUR4SE8xUFY1cDlwQTcxSXR3MWdKQ2xkbDhJdlI5N3MySnk5?= =?utf-8?B?S0drUm5qRE81MkJYWEorNXJKQnZNSEpaMXdqc2FtSGRRUFFUNzBDOFVjQUl3?= =?utf-8?B?Z1J6V2Z6bEpYTlZqZm42SWVDbVovV1N2Y3NpZ2lDMnZ4QWpMeC9zUjZ1YXgv?= =?utf-8?B?TkJNdERJQ0VRMk5NQUpTMDBLQUdCR21oMGZ0N3VWL0pNa2ZKQW9NNndaVEVj?= =?utf-8?B?ZEQvYzgyYTVNWWxScFJzMmVBRE9qM2NMS2hrRjZjcklFSjhjQXVobm44VUg4?= =?utf-8?B?VmZUOUJvRmpIaHhjMUhJblozeWZXamFkK3hsWW5nRGQ0enpla3dOaFR6NDFS?= =?utf-8?B?K1U5NExaNzl1WTNZejdLRkp1ZE1lYlVjQTNHSGZqcEk5MVRiSnZab0RRMVps?= =?utf-8?B?ZG04RmVqY3dLa1Btc1dodFJoVTNoN2ZrbFV4R0orOGdBWC94RWs5RXJTQVFZ?= =?utf-8?B?ck5PSXRLbDdTQ3Nrb0VXdVdpWWtFOFdaRk0rVDZDRUxDcWtRWXVhTXVXQmcy?= =?utf-8?B?Z2xqNGNWZ1J6YXkrTFYydkF5Vy9lRlRrV0lvcWtjRVFZcUVOZHpaYVFrRmJG?= =?utf-8?B?Vkc5ZXh4djc1QWt2ZEtVb0hhbzhKVWdYdWZzN0tNeHJNSm5DTkZ4S2IwaVY0?= =?utf-8?B?NkovaFhUVkY3bEg3RUtxaFNtcUt1Y3p6MXc2Ulc5Q1dsRHBRaDRqREhuS0VP?= =?utf-8?B?REM5VG9YVmY0YVZZbHE5eXFRQmlPN3JPMzhVc3pmZndMSFRPeW1PQ1JDbGRY?= =?utf-8?B?QWY3OENwRGFyMDBhQTdsN0ErUTVnNWRMU3JzSDR6bVBzK3ZPN1VtUFY1WDM1?= =?utf-8?B?cGlqZkZlaXJ2b3NwdWJtVGw4TE1kZHFHYnh0bnZvV2w1Q3l3TExtWjNSSVRl?= =?utf-8?B?ZmVwRXhweldyZDA5ZGVrdGZ3SElsc1dPeTlZZ2pQUE5zSjhjUFBZeVMwdWQ5?= =?utf-8?B?cnl4Zm9oRXZ2U2U5K0lXNW1aZS9wV0RjakU2NXZ1WjU1ZVFJVUlOa0F3WHc5?= =?utf-8?B?VGhEUUh5Zkdtc1hnbWJJamh6TFlxeHowYkx2aFdjM250TEI4NWE3b1JkT0M5?= =?utf-8?B?Wll2aHU3NFlGeEp6L2dReHFnbUZUc1cvRmhBYjlpTjlPRE5XWHArWFdaRmZV?= =?utf-8?B?WnFvNXU0QmhUZ21sa0Q2V0xUQmtDUVhqTDVpbFBRaVZOMnd4OURzVGNuOEcv?= =?utf-8?B?c1N1ZkFCWGNkMHc2YkJ1dVJEa01QWDlrcUVzRkZLUDA2a0M2dmljY2txYlZQ?= =?utf-8?B?L0dYT1BPdDNGSWIwK3BHdWRDakZjeUdyd1lrWkhZeTg2V25zcmZRNi9oM2Y3?= =?utf-8?B?QUZnRnM3d1hXQTk3YUpMcy80dVZuckNYNXljOEtxSTF2dUxSdGFPOE5TZ1py?= =?utf-8?B?ckpvd0lrc2RxWnNTbG8vTUE2Q0VCNUhaSVdvNUlIR2tCTzB0RytPczlqYkpa?= =?utf-8?B?SW5zQUdPQjhHeUM2ZjZYaEdqWlV4cjIwelROZThSTHpVdk5WZUJvYytHMU1z?= =?utf-8?B?YjZtZ0xNN0RhbXFXMi83cTNqVlVWaVpnS2M5cUJyZ0VEMk95eVcxSEdocHdH?= =?utf-8?B?M0NTTjJPc3hGZ1BuSjRGdGNkdTZXSi9FbTN2aitYZktFUW9OZ01LamlLT3Fn?= =?utf-8?B?SWxXRkNrdzFQM1g1TkM5d3lYbGJyeXZhVWVTODg0cExlK3dOS3hNLzhKUUdl?= =?utf-8?B?T3FyV0tGbUhhN0txbVBYcGdGem9sL25NelYyUEp1eEQ4WkF2bGxGNEpLTnRK?= =?utf-8?Q?OPB4d9d/ouZtiBl4Ku/TKTI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe6148f4-8d0f-4397-0f9b-08d9df1a7a58 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 09:18:26.7339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QUflYYQ3Jx8AMYlJkw/vIbcfCM2UBhhvNm6BconuPef/FbBwZyPvU3i45RoaCcvD9E+fuZ303PmzuWfjggTNbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4833 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/21/2022 5:09 PM, Kevin Traynor wrote: > On 06/01/2022 16:03, Xiaoyun Li wrote: >> In csum forwarding mode, software UDP/TCP csum calculation only takes >> the first segment into account while using the whole packet length so >> the calculation will read invalid memory region with multi-segments >> packets and will get wrong value. >> This patch fixes this issue. > > There should be a 'Fixes:' tag and assuming you want this patch backported to LTS, 'Cc: stable@dpdk.org' too. > It can't be, because fix relies on new APIs added in this release (patch 1/2).