From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B37E1A04B6; Mon, 11 Nov 2019 16:45:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5EBA2AB; Mon, 11 Nov 2019 16:45:50 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7A924235 for ; Mon, 11 Nov 2019 16:45:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 07:45:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,293,1569308400"; d="scan'208";a="207142087" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga006.jf.intel.com with ESMTP; 11 Nov 2019 07:45:46 -0800 To: pbhagavatula@marvell.com, arybchenko@solarflare.com, jerinj@marvell.com, thomas@monjalon.net Cc: dev@dpdk.org References: <20191106191803.15098-1-pbhagavatula@marvell.com> <20191111131914.16559-1-pbhagavatula@marvell.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Mon, 11 Nov 2019 15:45:45 +0000 MIME-Version: 1.0 In-Reply-To: <20191111131914.16559-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11/2019 1:19 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used > to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also > `ol_flags:PKT_RX_RSS`. > > Add new packet type set function `rte_eth_dev_set_ptypes`, > allows application to inform PMDs about the packet types it is interested > in. Based on ptypes requested by application PMDs can optimize the Rx path. > > For example, if a given PMD doesn't support any packet types that the > application is interested in then the application can disable[1] writes to > `mbuf.packet_type` done by the PMD and use a software ptype parser. > [1] rte_eth_dev_set_ptypes(*port_id*, RTE_PTYPE_UNKNOWN, > NULL, 0); > > v17 Changes: > ----------- > - Split 8/8 into two patches. > - Add rss_hash to port rx_offloads in testpmd. > - Add log when set_ptype fails. > - Fix few spell check. > > v16 Changes: > ----------- > - Fix testpmd documentation(Bernard). > - s/rte_eth_dev_set_supported_ptypes/rte_eth_dev_set_ptypes. > - Fix release notes placement. > - Enhance offload validation(Andrew). > - Remove if condition in drivers/net while enabling RSS_HASH by default. > - Spilt 5/7 into two patches. > > v15 Changes: > ----------- > - Fix sfc RSS_HASH offload check. > - Fix ethdev RSS_HASH offload check when mq_mode is configured with > MQ_RX_NONE. > - Extend offload validation to return error in the case where application > has requested an offload to be enabled and PMD couldn't honor it. > > v14 Changes: > ----------- > - Remove log from drives > - Add log in rte_eth_dev_configure when certain offloads are requested to be > disabled and PMD cannot honor the request. > - Make changes to default offloads in net/sfc.(Andrew) > > v13 Changes: > ----------- > - Remove DEV_RX_OFFLOAD_FLOW_MARK from this patchset to allow foreward > progress will be sent as a seperate patch. > - Use set_supported function only for l2fwd and testpmd. > - Add info log in drivers which expose the DEV_RX_OFFLOAD_RSS_HASH > indicating that disabling DEV_RX_OFFLOAD_RSS_HASH is not supported. > - Few documentation changes. > > v12 Changes: > ----------- > - Rebase onto next-net. > > v11 Changes: > ----------- > - Use RTE_DIM to get array size. > - Since we are using a list of MASKs to validate ptype_mask return -EINVAL > if any unknown mask is set. > - Rebase to TOT. > > v10 Changes: > ----------- > - Modify ptype_mask validation in set_supported_ptypes.(Andrew) > > v9 Changes: > ---------- > - Add ptype_mask validation in set_supported_ptypes.(Andrew) > - Make description more verbose. > > v8 Changes: > ---------- > - Make description more verbose. > - Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes > is not supported by ethernet device. > > v7 Changes: > ---------- > - Fix unused variable in net/octeontx2 > > v6 Changes: > ---------- > - Add additional checks for set supported ptypes.(Andrew) > - Clarify `rte_eth_dev_set_supported_ptypes` documentation. > - Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2. > > v5 Changes: > ---------- > - Fix typos. > > v4 Changes: > ---------- > - Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end > of array. > - Fix invalid set ptype function call in examples. > - Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power. > > v3 Changes: > ---------- > - Add missing release notes. (Andrew) > - Re-word various descriptions. > - Fix ptype set logic. > > v2 Changes: > ---------- > - Update release notes. (Andrew) > - Redo commit logs. (Andrew) > - Disable ptype parsing for unsupported examples. (Jerin) > - Disable RSS write only in generic mode eventdev_pipeline. (Jerin) > - Modify set_supported_ptypes function to return successfuly set mask > instead of failure. > - Dropped set_supported_ptypes to drivers by handling in library > layer, interested PMD can add it in. > > Pavan Nikhilesh (10): > ethdev: add set ptype function > ethdev: add mbuf RSS update as an offload > ethdev: add validation to offloads set by PMD > drivers/net: update Rx RSS hash offload capabilities > examples/eventdev_pipeline: split port init sequence > examples/eventdev_pipeline: add new Rx RSS hash offload > examples/l2fwd: disable ptype parsing > app/testpmd: add command to set supported ptype mask > app/testpmd: disable packet type parsing by default > app/testpmd: add RSS hash offload to port Rx offload cmd For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/master, thanks.