From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lewis Donzis <lew@perftech.com>, Yong Wang <yongwang@vmware.com>
Cc: dev <dev@dpdk.org>
Subject: Re: vmxnet3 no longer functional on DPDK 21.11
Date: Tue, 30 Nov 2021 08:53:16 +0000 [thread overview]
Message-ID: <e5ba015b-3ff4-c1ae-b270-5ffc2682cf75@intel.com> (raw)
In-Reply-To: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com>
On 11/29/2021 8:45 PM, Lewis Donzis wrote:
> Hello.
>
> We just upgraded from 21.08 to 21.11 and it's rather astounding the number of incompatible changes in three months. Not a big deal, just kind of a surprise, that's all.
>
> Anyway, the problem is that the vmxnet3 driver is no longer functional on FreeBSD.
>
> In drivers/net/vmxnet3/vmxnet3_ethdev.c, vmxnet3_dev_start() gets an error calling rte_intr_enable(). So it logs "interrupt enable failed" and returns an error.
>
> In lib/eal/freebsd/eal_interrupts.c, rte_intr_enable() is returning an error because rte_intr_dev_fd_get(intr_handle) is returning -1.
>
> I don't see how that could ever return anything other than -1 since it appears that there is no code that ever calls rte_intr_dev_fd_set() with a value other than -1 on FreeBSD. Also weird to me is that even if it didn't get an error, the switch statement that follows looks like it will return an error in every case.
>
> Nonetheless, it worked in 21.08, and I can't quite see why the difference, so I must be missing something.
>
> For the moment, I just commented the "return -EIO" in vmxnet3_ethdev.c, and it's now working again, but that's obviously not the correct solution.
>
> Can someone who's knowledgable about this mechanism perhaps explain a little bit about what's going on? I'll be happy to help troubleshoot. It seems like it must be something simple, but I just don't see it yet.
>
> Thanks,
> lew
+Yong
next prev parent reply other threads:[~2021-11-30 8:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:45 Lewis Donzis
2021-11-30 8:53 ` Ferruh Yigit [this message]
2021-11-30 13:42 ` Bruce Richardson
2021-12-06 1:52 ` Lewis Donzis
2021-12-06 9:16 ` Bruce Richardson
2021-12-06 12:08 ` Ananyev, Konstantin
2021-12-06 13:58 ` Lewis Donzis
2022-06-03 13:19 ` Lewis Donzis
2022-06-03 15:25 ` Ferruh Yigit
2024-01-06 14:50 ` Lewis Donzis
2024-01-09 10:21 ` Bruce Richardson
2024-01-09 13:46 ` Lewis Donzis
2024-01-09 14:28 ` Bruce Richardson
2024-01-09 15:21 ` Lewis Donzis
2024-01-09 15:35 ` Bruce Richardson
2024-01-09 23:55 ` Stephen Hemminger
2024-01-10 13:36 ` Lewis Donzis
2024-01-09 14:23 ` [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Bruce Richardson
2024-01-09 16:00 ` Lewis Donzis
2024-01-11 12:03 ` Ferruh Yigit
2024-01-24 12:34 ` Lewis Donzis
2024-01-24 13:58 ` Ferruh Yigit
2024-01-24 14:04 ` Lewis Donzis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ba015b-3ff4-c1ae-b270-5ffc2682cf75@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=lew@perftech.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).