From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 70EE5A0A0C;
	Thu,  1 Jul 2021 17:05:43 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EE32E40141;
	Thu,  1 Jul 2021 17:05:42 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D4ED34003E
 for <dev@dpdk.org>; Thu,  1 Jul 2021 17:05:41 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 40F637F504;
 Thu,  1 Jul 2021 18:05:41 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 40F637F504
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625151941;
 bh=Oiryry5F0dODrkSL0fdoMkIGM0rx9Cete5aQ5q0jNks=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=VTwZ3UjU7MLfTA8ZEjwp9E/yKKu5uxmF7iHP83iyzl2fiXI1hbHEKdRc9tt9IaEQ4
 uIKIeQ0WnM8eeZMW1gBC750BUFT2JOqCLz9fJzGEzIvPjz1Bs2FNZ5QX6C2OsKznps
 PJZ/UeIlWRwgKBdo6WvYR6Q43v+MIhAh9+t6IKA8=
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
References: <1624261125-22274-1-git-send-email-humin29@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <e5cbe6ca-9cab-cb8d-2554-733b50fb1fef@oktetlabs.ru>
Date: Thu, 1 Jul 2021 18:05:41 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1624261125-22274-1-git-send-email-humin29@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/hns3: fix traffic management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/21/21 10:38 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> In a multi-TC scenario, if the length of packets destined for different
> TCs is different, for example, 64B and 1500B packets destined for TC0 and
> TC1 respectively. There is a problem that the bandwidth of the TC to which
> large packets are sent is preempted by the TC to which small packets are
> sent on the Kunpeng 920 network engine. As a result, the TC bandwidth
> accuracy is inaccurate.
> 
> To solve this problem, this patch made the following adjustments:
> 1/ During initialization, firmware reports the capability bit indicating
> whether the TM function is supported.
> 2/ The command word for configuring TC and port rate limiting is added,
> instead of reusing the existing command word. And firmware configured
> to the correct module.
> 3/ When the PF driver is loaded, firmware completes the default
> initialization of the TC and port.
> 
> Fixes: c09c7847d892 ("net/hns3: support traffic management")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Applied, thanks.