From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5412FA034F; Sat, 11 Sep 2021 21:14:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8C5540042; Sat, 11 Sep 2021 21:14:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0656640041 for ; Sat, 11 Sep 2021 21:14:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631387645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFyggyLSzQFsr8YgoP/34ZYsBlCFsTBCVSCPVXwFXww=; b=MdYFvje0yXgF0RbBigmWsim86bbwPoQCljwwWLaubN5p1EVDrdMZVGsGUwnYhT2W368a5I 4FawfGCd9/u0l57FcO/cfXoZ0EM4vVSbX5OagIx1d7tudLc9R8DlGWOwEJCDzeb/kAT5gL XhUifA0I/zcw5YI2iohtG2M/aZuxPZ8= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-WHnCrG_LN6yYSxprxthVbA-1; Sat, 11 Sep 2021 15:14:02 -0400 X-MC-Unique: WHnCrG_LN6yYSxprxthVbA-1 Received: by mail-qk1-f198.google.com with SMTP id h135-20020a379e8d000000b003f64b0f4865so35949831qke.12 for ; Sat, 11 Sep 2021 12:14:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YFyggyLSzQFsr8YgoP/34ZYsBlCFsTBCVSCPVXwFXww=; b=XixzpJZfuYbrHMuDrvWelVU9b9qzgEva1DwOhKyVxYjQakZh4woKXyxSh17+9+bU/o 91ecZT7fPGMyklfd/JQ9jGezOlB5d8yK8po4MZgdYCkV6CNctssqvTShm7xKvWs3EiVj kqnCOGW2TCq78/SJfGDL3hn8FnpxWJw6H8oOksWr5aYOXiv9E4pzd421PQ5IFdf1ZojC gz3iBcmpMXeO7Bjp7qtG434ZYfH5reeHhkRLzRXUatNpheWi7YBwDk3BoACsJUXEgYoJ LWqxi/IHdu1Is0zAZgtlCs0F5urpW3WquAcNxb55WwlP4AS0ktvNNatCD3s5MvueidHD fixQ== X-Gm-Message-State: AOAM533FggGuguBq7baSxeqEyR+kmqEBFmGeNqfP1RFUCTdVz8B+sipT joeplo+H6HgIVL7ZySOiuJtNO6b+ZTy5rMJO0o1s0R30/vvaBL804XT0/f2z4nl9Jw8pF1Euw3f YL6g= X-Received: by 2002:a37:9d09:: with SMTP id g9mr3144087qke.269.1631387642030; Sat, 11 Sep 2021 12:14:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLDzfnnIhHPlELE+7Zh6r9/ZH9FEqs8B8S85YJ7rVWmlnP0ef5Qf8KVNoPHvB+bhB8vIW1bA== X-Received: by 2002:a37:9d09:: with SMTP id g9mr3144068qke.269.1631387641820; Sat, 11 Sep 2021 12:14:01 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id e22sm1478316qtm.10.2021.09.11.12.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Sep 2021 12:14:01 -0700 (PDT) To: "Chautru, Nicolas" , "dev@dpdk.org" , "gakhil@marvell.com" Cc: "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , "Zhang, Mingshan" , "Joshi, Arun" References: <1629407410-28822-1-git-send-email-nicolas.chautru@intel.com> <1629407410-28822-5-git-send-email-nicolas.chautru@intel.com> <98c827cb-ad62-6b56-5a94-275a25d845a0@redhat.com> From: Tom Rix Message-ID: Date: Sat, 11 Sep 2021 12:13:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 4/6] baseband/acc100: add support for 4G CRC drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:04 PM, Chautru, Nicolas wrote: > >> -----Original Message----- >> From: Tom Rix >> Sent: Wednesday, September 1, 2021 7:20 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> gakhil@marvell.com >> Cc: thomas@monjalon.net; hemant.agrawal@nxp.com; Zhang, Mingshan >> ; Joshi, Arun >> Subject: Re: [PATCH v2 4/6] baseband/acc100: add support for 4G CRC drop >> >> >> On 8/19/21 2:10 PM, Nicolas Chautru wrote: >>> This implements in PMD the option to drop the CB CRC after 4G decoding >>> to help transport block concatenation. >>> >>> Signed-off-by: Nicolas Chautru >>> --- >>> doc/guides/bbdevs/acc100.rst | 1 + >>> doc/guides/rel_notes/release_21_11.rst | 4 ++++ >>> drivers/baseband/acc100/rte_acc100_pmd.c | 12 +++++++++--- >>> 3 files changed, 14 insertions(+), 3 deletions(-) >>> >>> diff --git a/doc/guides/bbdevs/acc100.rst >>> b/doc/guides/bbdevs/acc100.rst index ff0fa4b..9fff6ab 100644 >>> --- a/doc/guides/bbdevs/acc100.rst >>> +++ b/doc/guides/bbdevs/acc100.rst >>> @@ -58,6 +58,7 @@ ACC100 5G/4G FEC PMD supports the following BBDEV >> capabilities: >>> - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN`` : set if negative LLR >> encoder i/p is supported >>> - ``RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN`` : set if positive LLR encoder >> i/p is supported >>> - ``RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP`` : keep CRC24B bits >>> appended while decoding >>> + - ``RTE_BBDEV_TURBO_DEC_CRC_24B_DROP`` : option to drop the code >>> + block CRC after decoding >>> - ``RTE_BBDEV_TURBO_EARLY_TERMINATION`` : set early termination >> feature >>> - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER`` : supports scatter- >> gather for input/output data >>> - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN`` : set half iteration >>> granularity diff --git a/doc/guides/rel_notes/release_21_11.rst >>> b/doc/guides/rel_notes/release_21_11.rst >>> index 8ca59b7..f7843bc 100644 >>> --- a/doc/guides/rel_notes/release_21_11.rst >>> +++ b/doc/guides/rel_notes/release_21_11.rst >>> @@ -59,6 +59,10 @@ New Features >>> >>> Added support for more comprehensive CRC options. >>> >>> +* **Updated the ACC100 bbdev PMD.** >>> + >>> + Added support for more comprehensive CRC options. >>> + >>> Removed Items >>> ------------- >>> >>> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c >>> b/drivers/baseband/acc100/rte_acc100_pmd.c >>> index 68ba523..891be81 100644 >>> --- a/drivers/baseband/acc100/rte_acc100_pmd.c >>> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c >>> @@ -980,6 +980,7 @@ >>> >> RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN | >>> RTE_BBDEV_TURBO_MAP_DEC | >>> >> RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP | >>> + >> RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | >> RTE_BBDEV_TURBO_DEC_SCATTER_GATHER, >>> .max_llr_modulus = INT8_MAX, >>> .num_buffers_src = >>> @@ -1708,8 +1709,12 @@ >>> } >>> >>> if ((op->turbo_dec.code_block_mode == >> RTE_BBDEV_TRANSPORT_BLOCK) >>> - && !check_bit(op->turbo_dec.op_flags, >>> - RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) >>> + && !check_bit(op->turbo_dec.op_flags, >>> + RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) >>> + crc24_overlap = 24; >>> + if ((op->turbo_dec.code_block_mode == RTE_BBDEV_CODE_BLOCK) >> These two if-statements can be combined. > They could but really when I tried that became arguably unreadable, I thought it was still better this way. Ok Tom > >>> + && check_bit(op->turbo_dec.op_flags, >>> + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP)) >>> crc24_overlap = 24; >>> >>> /* Calculates circular buffer size. >>> @@ -1744,7 +1749,8 @@ >>> >>> next_triplet = acc100_dma_fill_blk_type_out( >>> desc, h_output, *h_out_offset, >>> - k >> 3, next_triplet, >> ACC100_DMA_BLKID_OUT_HARD); >>> + (k - crc24_overlap) >> 3, next_triplet, >> crc24_overlap had been set before this patch in the above if-statement for >> crc_24b_keep. >> >> so this looks like a bug. >> >> If it is a bug, it should be separated out as its own patch. > Ok fair enough, will do. Thanks > >> Tom >> >>> + ACC100_DMA_BLKID_OUT_HARD); >>> if (unlikely(next_triplet < 0)) { >>> rte_bbdev_log(ERR, >>> "Mismatch between data to process and >> mbuf data length in >>> bbdev_op: %p",