From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <xavier.huwei@tom.com>, dev@dpdk.org
Cc: xavier.huwei@huawei.com
Subject: Re: [dpdk-dev] [PATCH 3/4] net/hns3: Renew command and desc structure
Date: Tue, 15 Oct 2019 09:45:56 +0100 [thread overview]
Message-ID: <e5d5bd99-663d-5661-dfda-312c762b2887@intel.com> (raw)
In-Reply-To: <20191009141653.39364-4-xavier.huwei@tom.com>
On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote:
> From: humin <humin29@huawei.com>
>
> This patch adds commands and modifies descriptor structures for
> accessing manage table and mac table.
>
> Signed-off-by: humin <humin29@huawei.com>
Can you please provide a "Name Surname <email@address.com>" format?
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
> drivers/net/hns3/hns3_cmd.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h
> index be0ecbe86..13a3b87d5 100644
> --- a/drivers/net/hns3/hns3_cmd.h
> +++ b/drivers/net/hns3/hns3_cmd.h
> @@ -217,6 +217,8 @@ enum hns3_opcode_type {
> /* PPP module intr commands */
> HNS3_PPP_CMD0_INT_CMD = 0x2100,
> HNS3_PPP_CMD1_INT_CMD = 0x2101,
> + HNS3_PPP_MAC_VLAN_IDX_RD = 0x2104,
> + HNS3_MAC_ETHERTYPE_IDX_RD = 0x2105,
> };
>
> #define HNS3_CMD_FLAG_IN BIT(0)
> @@ -642,7 +644,7 @@ struct hns3_mac_mgr_tbl_entry_cmd {
> uint16_t vlan_tag;
> uint32_t mac_addr_hi32;
> uint16_t mac_addr_lo16;
> - uint16_t rsv1;
> + uint16_t index;
> uint16_t ethter_type;
> uint16_t egress_port;
> uint16_t egress_queue;
> @@ -707,12 +709,13 @@ struct hns3_mac_vlan_tbl_entry_cmd {
> uint16_t vlan_tag;
> uint32_t mac_addr_hi32;
> uint16_t mac_addr_lo16;
> - uint16_t rsv1;
> + uint16_t port;
> uint8_t entry_type;
> uint8_t mc_mac_en;
> uint16_t egress_port;
> uint16_t egress_queue;
> - uint8_t rsv2[6];
> + uint8_t rsv2[2];
> + uint32_t index;
> };
>
Aren't these new fields and defines used at all? If not why added?
next prev parent reply other threads:[~2019-10-15 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:16 [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for sending and receiving messages Wei Hu (Xavier)
2019-10-15 8:45 ` Ferruh Yigit
2019-10-18 8:23 ` Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 2/4] net/hns3: change the return value of firmware processing timeout from -EBADE to -ETIME Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 3/4] net/hns3: Renew command and desc structure Wei Hu (Xavier)
2019-10-15 8:45 ` Ferruh Yigit [this message]
2019-10-25 12:34 ` Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 4/4] net/hns3: restores bus_master_en and msix_enable during PF FLR reset Wei Hu (Xavier)
2019-10-10 3:28 ` [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver Wei Hu (Xavier)
2019-10-15 8:46 ` Ferruh Yigit
2019-10-18 8:24 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d5bd99-663d-5661-dfda-312c762b2887@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=xavier.huwei@huawei.com \
--cc=xavier.huwei@tom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).