From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AB12A2E8D for ; Thu, 5 Sep 2019 18:49:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 459821F03B; Thu, 5 Sep 2019 18:49:22 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2156A1BF76 for ; Thu, 5 Sep 2019 18:49:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 952574C0058; Thu, 5 Sep 2019 16:49:18 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Sep 2019 17:49:12 +0100 To: Stephen Hemminger CC: Gaetan Rivet , , Ivan Ilchenko References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1567699852-31693-3-git-send-email-arybchenko@solarflare.com> <20190905094013.6038f374@hermes.lan> From: Andrew Rybchenko Message-ID: Date: Thu, 5 Sep 2019 19:49:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190905094013.6038f374@hermes.lan> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24890.003 X-TM-AS-Result: No-1.753700-8.000000-10 X-TMASE-MatchedRID: QfHZjzml1E+8rRvefcjeTfZvT2zYoYOwC/ExpXrHizzHoLp1yJ83GOBw lzWEEXt21bNT+YxZ+GC9y8dYwYlbbxy/DZ8tz1CLSszr2nuUNKwCn5QffvZFlfPXnE+NdHS+xOv 8bbijtGuUzIEJbp2koSJwmvDpw+Lm9IKRKjO372FoOA9kFf9sy66IBbSnfz+3x4gtHcG+Se9R18 QpzXStTv2Fq3oxveV/7qL4IUbQ95ZhyMOhUPZ7nrzK9RGVgYIhH3yyYiehcctCI7pNLiSjfcUzz dIu4oxh92grUwQgYZd5OPD8XJFfpL9ZdlL8eonaKsmEtKMlFWZZePD7Slhp3Stb2I8KzIvWDEth OFecBTyKDNPoIPXXm1zyvhq3dqyn/J6+P/+O1Q1h+VpdYrXSkoHcvuFpqf38XrKaBAGN3QMv37/ yde6GSrMy17fc1MRptotQn8/z9hp9syS/i6krrTaWry7OqRt5tCKwVA9+ahz5ysgKQ7Oq+GjxdO g9/8w5530MvdBuwh1WXGvUUmKP2w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.753700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24890.003 X-MDID: 1567702159-9IR2BFTshtfm Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/5/19 7:40 PM, Stephen Hemminger wrote: > On Thu, 5 Sep 2019 17:10:40 +0100 > Andrew Rybchenko wrote: > >> From: Ivan Ilchenko >> >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return >> value was changed from void to int, so this patch modify usage >> of these functions across net/failsafe according to new return type. >> >> Try to keep promiscuous mode consistent across all active >> devices in the case of failure. >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko > In reality, failsafe's promiscious mode is actually a lie. > The only common use case of failsafe is on Azure/Hyper-V and in a guest > setting promiscuous is not allowed. That is why there is no promiscuous > setting in netvsc PMD. Confused $ git grep promiscuous drivers/net/netvsc/ drivers/net/netvsc/hn_ethdev.c:hn_dev_promiscuous_enable(struct rte_eth_dev *dev) drivers/net/netvsc/hn_ethdev.c: return hn_vf_promiscuous_enable(dev); drivers/net/netvsc/hn_ethdev.c:hn_dev_promiscuous_disable(struct rte_eth_dev *dev) drivers/net/netvsc/hn_ethdev.c: return hn_vf_promiscuous_disable(dev); drivers/net/netvsc/hn_ethdev.c: .promiscuous_enable     = hn_dev_promiscuous_enable, drivers/net/netvsc/hn_ethdev.c: .promiscuous_disable    = hn_dev_promiscuous_disable, drivers/net/netvsc/hn_var.h:int hn_vf_promiscuous_enable(struct rte_eth_dev *dev); drivers/net/netvsc/hn_var.h:int hn_vf_promiscuous_disable(struct rte_eth_dev *dev); drivers/net/netvsc/hn_vf.c:int hn_vf_promiscuous_enable(struct rte_eth_dev *dev) drivers/net/netvsc/hn_vf.c:     VF_ETHDEV_FUNC_RET_STATUS(dev, rte_eth_promiscuous_enable); drivers/net/netvsc/hn_vf.c:int hn_vf_promiscuous_disable(struct rte_eth_dev *dev) drivers/net/netvsc/hn_vf.c:     VF_ETHDEV_FUNC_RET_STATUS(dev, rte_eth_promiscuous_disable);