From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-telemetry: print name of app when connected
Date: Tue, 16 Feb 2021 10:40:36 +0000 [thread overview]
Message-ID: <e5ff396d-befa-2119-da19-32e1cfa5fbaf@intel.com> (raw)
In-Reply-To: <20210216094415.28000-1-bruce.richardson@intel.com>
On 16-Feb-21 9:44 AM, Bruce Richardson wrote:
> When the dpdk-telemetry client connects to a DPDK instance, we can use the
> PID provided in the initial connection message to query from /proc the name
> of the process we are connected to, and display that to the user. We use
> the "cmdline" procfs entry for the query since that is available on both
> Linux and FreeBSD (assuming procfs is mounted on the BSD instance).
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> usertools/dpdk-telemetry.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
> index 181859658f..82b91f346f 100755
> --- a/usertools/dpdk-telemetry.py
> +++ b/usertools/dpdk-telemetry.py
> @@ -45,6 +45,11 @@ def handle_socket(path):
> return
> json_reply = read_socket(sock, 1024)
> output_buf_len = json_reply["max_output_len"]
> + pid = json_reply["pid"]
> + if os.path.exists('/proc/' + str(pid) + '/cmdline'):
> + with open('/proc/' + str(pid) + '/cmdline') as f:
First of all, this is better done using os.path.join:
path = os.path.join('/proc', str(pid), 'cmdline')
if os.path.exists(path):
with open(path) as f:
...
More importantly this isn't terribly Pythonic as it's not over-using
exceptions :) IMO a better way would be:
try:
with open(path) as f:
...
except IOError as e:
# ignore if doesn't exist
if e.errno != errno.ENOENT:
raise
> + argv0 = f.read(1024).split('\0')[0]
> + print("Connected to application: '" + os.path.basename(argv0) + "'")
Also, formatting is better than concatenation, e.g. at least:
bname = os.path.basename(argv0)
print("Connected to application: '{}'".format(bname))
>
> # get list of commands for readline completion
> sock.send("/".encode())
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-02-16 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 9:44 Bruce Richardson
2021-02-16 10:40 ` Burakov, Anatoly [this message]
2021-02-16 11:02 ` Bruce Richardson
2021-02-16 11:13 ` Burakov, Anatoly
2021-02-16 11:39 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2021-02-16 12:19 ` Burakov, Anatoly
2021-02-17 13:57 ` Kevin Laatz
2021-03-25 17:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ff396d-befa-2119-da19-32e1cfa5fbaf@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).