From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63A45A0560; Mon, 21 Nov 2022 15:11:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45FB741148; Mon, 21 Nov 2022 15:11:03 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63]) by mails.dpdk.org (Postfix) with ESMTP id D96FB400EF for ; Mon, 21 Nov 2022 15:11:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpRJldk4vhIO1UcmwzQyp2cVFzMxaPnDZcI9PJsWiYwB3r1NRlyyd+ibixMTmuUKVOcZF8PgkCd2MhdxdwHz1jVPH4geB97L6KdqjE6tXVDfYvSj90QlhhGD7uElPsfddNIqxECkEiBVoranjiixPACQ7WHhPEDNjBmsjDnarwY6gIU0lflulLlKvUzQmdAtR8jbdoFSdfsxxvANNkJ7JjD7E6sMPPa2m+exqhdBWu0uSkNvbkmgPb8RcwWcrgCDoGUaN2lOijBljxeWLI253VH/RqWv7jZduN8sjAPSUczhQIhXzs5O2WgcbCBd5DIUeRFbdFKWUJNMAV8pZhlOQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKZbjjOusUuoCGR1rMaYesL5/rw7iEZjXN7cuzFOjp8=; b=fSymjC9vFakaFloe6Rus3WnHWFgLMNBgvaglaSitZv7sDnRW7UUOf5P/llBaty+vSyGP0xlo1OsNIB9uA8nugHHnSvHwb0gySykWtdTh8ADeze2baj67fZH4eY4UjV0TDd5qiueNWvo9+cy30HbIvpjVtGl0IxV0SJeWRKqUzjgzZDDq9o8yYyeIEzk5jJsdTGIYGV5uaPF9mLbYmpz78GP0TrfWjrKCwGtpP76M2MpsAMCbk3BmFwGmdHDw4hZ3W0V3gDUKXnd3Or1Db3OcdvXrfZfqxjpLZA/mKkrQZKvoi3lw/anWEhe7zCPsiEnkNrUarwiyIQRXUrJNuzSvvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKZbjjOusUuoCGR1rMaYesL5/rw7iEZjXN7cuzFOjp8=; b=1G6UVNHHKlH3CVVsXgHJV+TNflGQLmydexSuMuLefM5fb8rm+8pxJzMwZgG90rSB7V0o37t7Z2YXzV2PEbJeaVunuZv2nhFZSmCVzD7Hbvr/Pn3+mDDhV2SI2L437j67w/e7FNf0AVQzrnR04rP87WOFUdNtOzr7Ekwbyf7kw/E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6521.namprd12.prod.outlook.com (2603:10b6:208:3bd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 14:10:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 14:10:57 +0000 Message-ID: Date: Mon, 21 Nov 2022 14:10:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [EXT] Re: [PATCH v5 1/1] app/testpmd: add valid check to verify multi mempool feature Content-Language: en-US To: Hanumanth Reddy Pothula , Aman Singh , Yuying Zhang Cc: "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "thomas@monjalon.net" , "yux.jiang@intel.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram References: <20221118141334.3825072-1-hpothula@marvell.com> <20221121124546.3920722-1-hpothula@marvell.com> <3405bb67-9731-4b8c-2a52-1cd71ebe52d9@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0040.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::28) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6521:EE_ X-MS-Office365-Filtering-Correlation-Id: 608401e4-d875-4a95-dd39-08dacbca3522 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3gGnc3BAdsGHDs9PMpfLRxCvZGElsMlM5BTb43V2aQd+kvCldY79lyasWBYSsfAghBtJNmRHJir77UO8Ala0IUloU0e5NCorNgrReGupYxjBNg8pYiWmvAy6trlmmzZ3LtrmJkRw8UgZt4vokyioVGZ8E2V1FIsOd4h4Otyx5lkH/0x4cWSaMMklbV48N5jfwcKPN5Nkto4se8Eu1NyaTCgnFRC/SufPygHObYxVjKcxsXdVtRSGSO+Zi8ikcAtRWz2YRdOF7kckPNpUlYXJK7cKdocBRr3F71JB0FHX4eCHlCaNlfGlHZd4cEvFUc35DCM1K/a03haRiQbmQz945a6OsQHrQx8B1a0VD8uUCmru7II8lljij8DK9CG936WOTKfOZzs2bMVGj+hhOsKyViPuJK/Fvlt1Jf1unlW31LerlgedE3B0sX9kCh5ICOnfD+n1RtwNxUlGl2+36O23o8ZicRoAz5RS8NzndL1G+ra7URL1TpwQrOACDkI/7IGfUtLKucaCcFzPn4/Qnm8x5pwBG3qzU3j3my8JZN9KoaKA+lli7h1pbZj/pNbmUGDT6ycnS761Y1FvsgJSkorkSUiJHqc1t3VtgM6nJ0ag6FdvKITIHQfrCTb4eUuagfXb9oeMKufbMlM3gdqXU0edXWvm9ELkZEY0pJZMGleb/O0uKAW11GjHUUlJXI4RuJhc5ONkqoHHQHY+3BrSflD11t0ZeogEM1DB+ex7dXyBaCw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(2906002)(15650500001)(36756003)(83380400001)(186003)(38100700002)(31686004)(2616005)(6506007)(53546011)(26005)(6512007)(6666004)(478600001)(6486002)(54906003)(110136005)(4326008)(44832011)(41300700001)(8936002)(8676002)(66476007)(316002)(5660300002)(66556008)(66946007)(31696002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjNCV0d3bkRRR0h0cFEvNm5vYlVzZERja3UzRUdHN0g3WmtleUxGYmJMNVdw?= =?utf-8?B?bDRmL2o0Vi85dGVCemNzMjg4MTdSUmR2WXNWV1lpd2puZ3FXRDdkUkVFUG5h?= =?utf-8?B?WENzbGpYellZbTZSbXoyb0o0ZXRsNlVXS2E1Q0NCeHg5ZENLQjFkcjJHWTFm?= =?utf-8?B?eWtJeEN0a01BN2NBclBaVjdMOFYvSEtUN1RHa1ltL0lIdXJSOFhoSld2YlhV?= =?utf-8?B?eHhaeEJMM05UM0k5ZFN5ZWEydExxbG5DWlRSUGRpTUU5RGhpYlB4QkVQenZH?= =?utf-8?B?d0wreXl3U252OFdCMzdIOU83bXFZSjdndVRPR25DK25HMUtrYWovZEpodVNj?= =?utf-8?B?WGRsSm9UUTFJY2dXS2NFM0E0bjMrVXUvNmlJYjlHSXNlemRkWk11eTJYcGpy?= =?utf-8?B?ODlINlk4VlZNZU5wbWhDYzRsQllNU1B1UnVPTDJxUXJKUWpjNjlKbDRuOTcr?= =?utf-8?B?V3pwMXFEeW9CeW9HS1dINzc5cjhEOU82dHU4VFRta01penh4WVU2R3pudFIx?= =?utf-8?B?U1J3UjJpOGhUMHZWYytLT3ZaVWF2NnYwR0NQWWNlZ1JTSkVENVQwQm1HNFY2?= =?utf-8?B?OENHZkZqaEx0VnFkeGovN2hnKzhyYS9aMzlObjZhdE04T1FTTVBXNDFkQTFX?= =?utf-8?B?YTJPSDcyYTJScHNaQmN5eVFLMnZCSWNRK3UyWEZBcGlNUUFLZjVJQyt4Ty9a?= =?utf-8?B?OUZLNHRVY1JEK2FpcUcyOUZxRHMvRTM4a0VRM2xob3FUT0xFN21TcmR4aW5h?= =?utf-8?B?UGZ4d1hkYVpFUTFXRmtoVVp4Q2lYZndTU0I2OE1nN0dqMjFGeGFjelhUYU9p?= =?utf-8?B?OEtKTTR1UVVaOStTa3hnM2lvcG5MbXZ0QXZMdktiUGE5SFlYRGZuQUNENnQ2?= =?utf-8?B?dkN1d011ODF5ZHMzT0V3bXNycHl0NDJ0bnJ1WlF6WnVjMEtpblYvNFBsbDFp?= =?utf-8?B?dGxrTXpxbERVcXAwR0FHZGNmOUFKWFFNM1VQSGc3clRTbW5uakgwNnJ3VHJk?= =?utf-8?B?UXkzbXJXN2NBMk56U2QzOU54VUlLcTQvc0VGbWNpaGFLWFhpWS9UY2xNaGoy?= =?utf-8?B?eWJjcisrVG10bXl6Ti8vb3A2N3hpRnhMNndoaVRrdUNCU3R1WDkwUzZSWGxO?= =?utf-8?B?RTJpWmFMaGI1ektzN1pjekhtdGU0S0FQNFVQQ2RJUVZoNjdyMmRsTUdEbGo0?= =?utf-8?B?MzJNQldMYVdLbDZjWnVIc2t6R21vWFVpdkxkZWNoc3NpeDQ0U1o5aGRKd0J6?= =?utf-8?B?WE81ZUxXSnFISlVVL3Q3b1FLQ1ZYTUpvY3draFRHM1JEeENJeEowcXFQc2Nn?= =?utf-8?B?UTFOK3dDQmh4MUllNXBXL0VtWkRHNklwTWlHQUhCdXBrWU1tSC9tajJNZzNH?= =?utf-8?B?Ykh1c01kWmpSQ09nbDE5cVNIWEJaRmZVMkxiT2NIeVFaS0ozMUQyNHQ4bUtB?= =?utf-8?B?UDVpTEdyd1lwSTcvUlBKMFkrcnhyL0lvQjE1YnRMNEJZL1hLbEcxVXhsc0dq?= =?utf-8?B?NUtJNUN1VytmdmNDTWRLdythaXVSOHFBMEFBWVJmeFpNc0pNU2RSRU1CcVVX?= =?utf-8?B?RVplbm5RczZ0dCt0SlhERHdjcW5UbG1UUjNKSTFVbTdzY3UySjdseElHcFhC?= =?utf-8?B?K3RmUHZPbHI3akluNkp5TU1BMC8vMUhOVVUxL2VLSVdOV0tSQ1lKajlIK2l3?= =?utf-8?B?VTZ4VGRKUXNGMkVzd0trczhZWHFTTWt1NCs1THlSU3hvakFGYnc3Tm1ZZkJo?= =?utf-8?B?U3Z5a0x0cVdGY1ltNDNEVURrcEtIYlNnNnhMVmxaUGpLSUphcFE4R1VxN3Q2?= =?utf-8?B?WHZGQk1WU0dpVnNDZWg2cklVYjNzK3lwb3NpM2YreWVNLzdSeTIxcVJqVUxi?= =?utf-8?B?OWhTZGFiS2pHR0E2Si8xVXp3dkdmZ3E0V0ZDTWJXdTRHaWhSWEtGSm9NSkRI?= =?utf-8?B?T3Q4WkRQOGR6c3JObURjd0dYSHliZG04Y2pEbWJHYVU4dUlMK0tOYXFlRkVr?= =?utf-8?B?cUovOHRSUVZlZGNWYTgvajFiODFkMjBuakkzM3NSRHdYc1R3YjBjaXB4N0Rx?= =?utf-8?B?eTU4VnE3VUs0NFJVNUh2R3JWbGxLWndTMVJMZEI0WWdJZWlXYnNuWjZuS2pG?= =?utf-8?Q?tPNOU1V2xvAsh6hHc52lQRakI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 608401e4-d875-4a95-dd39-08dacbca3522 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:10:57.8356 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GnnzRXFU2KjbDQWFcP6VzYrDqZkbHhEAhdR50UBnXAXj4NkUA7A1eFEUwfENUps+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6521 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/21/2022 1:36 PM, Hanumanth Reddy Pothula wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, November 21, 2022 6:53 PM >> To: Hanumanth Reddy Pothula ; Aman Singh >> ; Yuying Zhang >> Cc: dev@dpdk.org; andrew.rybchenko@oktetlabs.ru; >> thomas@monjalon.net; yux.jiang@intel.com; Jerin Jacob Kollanukkaran >> ; Nithin Kumar Dabilpuram >> >> Subject: [EXT] Re: [PATCH v5 1/1] app/testpmd: add valid check to verify >> multi mempool feature >> >> External Email >> >> ---------------------------------------------------------------------- >> On 11/21/2022 12:45 PM, Hanumanth Pothula wrote: >>> Validate ethdev parameter 'max_rx_mempools' to know whether device >>> supports multi-mempool feature or not. >>> >>> Also, add new testpmd command line argument, multi-mempool, to >> control >>> multi-mempool feature. By default its disabled. >>> >>> Bugzilla ID: 1128 >>> Fixes: 4f04edcda769 ("app/testpmd: support multiple mbuf pools per Rx >>> queue") >>> >>> Signed-off-by: Hanumanth Pothula >>> >>> --- >>> v5: >>> - Added testpmd argument to enable multi-mempool feature. >>> - Simplified logic to distinguish between multi-mempool, >>> multi-segment and single pool/segment. >>> v4: >>> - updated if condition. >>> v3: >>> - Simplified conditional check. >>> - Corrected spell, whether. >>> v2: >>> - Rebased on tip of next-net/main. >>> --- >>> app/test-pmd/parameters.c | 3 ++ >>> app/test-pmd/testpmd.c | 58 +++++++++++++++++++++++++------------ >> -- >>> app/test-pmd/testpmd.h | 1 + >>> 3 files changed, 41 insertions(+), 21 deletions(-) >>> >>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>> index aed4cdcb84..26d6450db4 100644 >>> --- a/app/test-pmd/parameters.c >>> +++ b/app/test-pmd/parameters.c >>> @@ -700,6 +700,7 @@ launch_args_parse(int argc, char** argv) >>> { "rx-mq-mode", 1, 0, 0 }, >>> { "record-core-cycles", 0, 0, 0 }, >>> { "record-burst-stats", 0, 0, 0 }, >>> + { "multi-mempool", 0, 0, 0 }, >> >> Can you please group with relatet paramters, instead of appending end, >> after 'rxpkts' related parameters group (so after 'txpkts') can be good >> location since it is used for buffer split. >> > Ack > >> need to document new argument on >> 'doc/guides/testpmd_app_ug/run_app.rst' >> > Ack > >> Also need to add help string in 'usage()' function, again grouped in related >> paramters. > Sure, will add help string >> >>> { PARAM_NUM_PROCS, 1, 0, 0 }, >>> { PARAM_PROC_ID, 1, 0, 0 }, >>> { 0, 0, 0, 0 }, >>> @@ -1449,6 +1450,8 @@ launch_args_parse(int argc, char** argv) >>> record_core_cycles = 1; >>> if (!strcmp(lgopts[opt_idx].name, "record-burst- >> stats")) >>> record_burst_stats = 1; >>> + if (!strcmp(lgopts[opt_idx].name, "multi- >> mempool")) >>> + multi_mempool = 1; >> >> Can you group with related paramters, same as above mentioned location? >> > Ack >>> if (!strcmp(lgopts[opt_idx].name, >> PARAM_NUM_PROCS)) >>> num_procs = atoi(optarg); >>> if (!strcmp(lgopts[opt_idx].name, >> PARAM_PROC_ID)) diff --git >>> a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>> 4e25f77c6a..9dfc4c9d0e 100644 >>> --- a/app/test-pmd/testpmd.c >>> +++ b/app/test-pmd/testpmd.c >>> @@ -497,6 +497,11 @@ uint8_t record_burst_stats; >>> */ >>> uint32_t rxq_share; >>> >>> +/* >>> + * Multi-mempool support, disabled by default. >>> + */ >>> +uint8_t multi_mempool; >> >> Can you put this after 'rx_pkt_nb_segs' related group. >> > Ack >>> + >>> unsigned int num_sockets = 0; >>> unsigned int socket_ids[RTE_MAX_NUMA_NODES]; >>> >>> @@ -2655,28 +2660,23 @@ rx_queue_setup(uint16_t port_id, uint16_t >> rx_queue_id, >>> union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {}; >>> struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {}; >>> struct rte_mempool *mpx; >>> + struct rte_eth_dev_info dev_info; >>> unsigned int i, mp_n; >>> uint32_t prev_hdrs = 0; >>> int ret; >>> >>> + ret = rte_eth_dev_info_get(port_id, &dev_info); >>> + if (ret != 0) >>> + return ret; >>> + >>> /* Verify Rx queue configuration is single pool and segment or >>> * multiple pool/segment. >>> + * @see rte_eth_dev_info::max_rx_mempools >>> * @see rte_eth_rxconf::rx_mempools >>> * @see rte_eth_rxconf::rx_seg >>> */ >> >> Is above comment block still valid? > Will remove >> >>> - if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 || >>> - ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != >> 0))) { >>> - /* Single pool/segment configuration */ >>> - rx_conf->rx_seg = NULL; >>> - rx_conf->rx_nseg = 0; >>> - ret = rte_eth_rx_queue_setup(port_id, rx_queue_id, >>> - nb_rx_desc, socket_id, >>> - rx_conf, mp); >>> - goto exit; >>> - } >>> - >>> - if (rx_pkt_nb_segs > 1 || >>> - rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) { >>> + if ((rx_pkt_nb_segs > 1) && >>> + (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)) { >>> /* multi-segment configuration */ >>> for (i = 0; i < rx_pkt_nb_segs; i++) { >>> struct rte_eth_rxseg_split *rx_seg = >> &rx_useg[i].split; @@ -2701,7 >>> +2701,14 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, >>> } >>> rx_conf->rx_nseg = rx_pkt_nb_segs; >>> rx_conf->rx_seg = rx_useg; >>> - } else { >>> + rx_conf->rx_mempools = NULL; >>> + rx_conf->rx_nmempool = 0; >>> + ret = rte_eth_rx_queue_setup(port_id, rx_queue_id, >> nb_rx_desc, >>> + socket_id, rx_conf, NULL); >>> + rx_conf->rx_seg = NULL; >>> + rx_conf->rx_nseg = 0; >>> + } else if ((multi_mempool == 1) && (dev_info.max_rx_mempools != >> 0) && >>> + (mbuf_data_size_n > 1)) { >> >> What do you think to move 'rte_eth_dev_info_get()' within this if block, >> and reduce 'dev_info' scope, like > Ack >> >> else if (multi_mempool == 1) >> if (mbuf_data_size_n <= 1)) >> log(describe problem) >> return >> struct rte_eth_dev_info dev_info; >> ret = rte_eth_dev_info_get(port_id, &dev_info); >> if (dev_info.max_rx_mempools == 0) >> log("device doesn't support requested config" >> return >> >> else >> >>> /* multi-pool configuration */ >>> for (i = 0; i < mbuf_data_size_n; i++) { >>> mpx = mbuf_pool_find(socket_id, i); >> >> Where the mempools are created? Is that code also needs to be updated to >> use/check 'multi_mempool' variable/config? > I think it's not required, as user might create multiple pools for other scenarios as well, for example as part of buzilla id: 1128, user creating two pools but not for multi-mempool feature. > ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 5,6 -n 8 --force-max-simd-bitwidth=64 -- -i --portmask=0x3 --rxq=1 --txq=1 --txd=1024 --rxd=1024 --nb-cores=1 --mbuf-size=2048,2048 If they are not created explicit for multiple pool, agree to not change that code, thanks. >> >>> @@ -2709,14 +2716,23 @@ rx_queue_setup(uint16_t port_id, uint16_t >> rx_queue_id, >>> } >>> rx_conf->rx_mempools = rx_mempool; >>> rx_conf->rx_nmempool = mbuf_data_size_n; >>> - } >>> - ret = rte_eth_rx_queue_setup(port_id, rx_queue_id, nb_rx_desc, >>> + rx_conf->rx_seg = NULL; >>> + rx_conf->rx_nseg = 0; >>> + ret = rte_eth_rx_queue_setup(port_id, rx_queue_id, >> nb_rx_desc, >>> socket_id, rx_conf, NULL); >>> - rx_conf->rx_seg = NULL; >>> - rx_conf->rx_nseg = 0; >>> - rx_conf->rx_mempools = NULL; >>> - rx_conf->rx_nmempool = 0; >>> -exit: >>> + rx_conf->rx_mempools = NULL; >>> + rx_conf->rx_nmempool = 0; >>> + } else { >>> + /* Single pool/segment configuration */ >>> + rx_conf->rx_seg = NULL; >>> + rx_conf->rx_nseg = 0; >>> + rx_conf->rx_mempools = NULL; >>> + rx_conf->rx_nmempool = 0; >>> + ret = rte_eth_rx_queue_setup(port_id, rx_queue_id, >> nb_rx_desc, >>> + socket_id, rx_conf, mp); >>> + } >>> + >>> + >>> ports[port_id].rxq[rx_queue_id].state = rx_conf->rx_deferred_start >> ? >>> >> RTE_ETH_QUEUE_STATE_STOPPED : >>> >> RTE_ETH_QUEUE_STATE_STARTED; >>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index >>> aaf69c349a..9472a2cb19 100644 >>> --- a/app/test-pmd/testpmd.h >>> +++ b/app/test-pmd/testpmd.h >>> @@ -464,6 +464,7 @@ enum dcb_mode_enable extern uint8_t >>> xstats_hide_zero; /**< Hide zero values for xstats display */ >>> >>> /* globals used for configuration */ >>> +extern uint8_t multi_mempool; /**< Enables multi-mempool feature. >> */ >> >> Again please group this same location as done in .c file > Ack. >> >>> extern uint8_t record_core_cycles; /**< Enables measurement of CPU >>> cycles */ extern uint8_t record_burst_stats; /**< Enables display of >>> RX and TX bursts */ extern uint16_t verbose_level; /**< Drives messages >> being displayed, if any. */ >