From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E78B0A04BB; Tue, 6 Oct 2020 16:59:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13B661B696; Tue, 6 Oct 2020 16:59:25 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2C1371B690 for ; Tue, 6 Oct 2020 16:59:23 +0200 (CEST) IronPort-SDR: 4dW8wigeN5nxRJRLAeDUlpPkpwXaAtzXQ7XpX34zy2CEdUD2pHZ6e+j3V3mtf7rZtaqwsKk7Dd k/7D4cl8dcpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="226122947" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="226122947" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 07:59:00 -0700 IronPort-SDR: /e/WEzWVnNL1m6LbKH91hi+k9ncIk9lu/51KHOGSGk6tBu9HxnAXhmesLOLLy0EuPHT/8hlIOy iq0KrzDEn3Cg== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342320452" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 07:58:57 -0700 To: Ophir Munk , dev@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Olivier Matz References: <20200915131717.18252-2-ophirmu@nvidia.com> <20200918141735.18488-1-ophirmu@nvidia.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Oct 2020 15:58:53 +0100 MIME-Version: 1.0 In-Reply-To: <20200918141735.18488-1-ophirmu@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/2020 3:17 PM, Ophir Munk wrote: > v1: > Initial version > v2: > Rebased + Minor update in protocol options field: > char opts[0] ===> uint8_t opts[] > v3: > Rebase > document "geneve-port=N" parameter > v4: > Mispelling corrections > v5: > Rebase + Updates following review > http://patches.dpdk.org/patch/77734/ > > Ophir Munk (3): > app/testpmd: add GENEVE parsing > app/testpmd: enable configuring GENEVE port > app/testpmd: reduce tunnel parsing code duplication > Hi Ophir, The patchset looks good except a few comments I put into the patches. But I have two highlevel questions/comments, 1) The testpmd tunnel parsing feature is not documented properly, there are various related commands but there is no documentation to put all together. What do you think putting a new section for it under the "Testpmd Runtime Functions" (testpmd_funcs.rst) with this patchset? 2) The 'csum' forwarding engine seems become forwarding engine for the case where packet payload needs to be parsed, like gro/gso, tunnel parse. Even the description of the forwarding engine in the documentation is not accurate now. I wonder if we should rename the forwarding engine at this stage?