From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A449A04B1; Wed, 4 Nov 2020 18:24:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D28022BE1; Wed, 4 Nov 2020 18:24:54 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 19C14160 for ; Wed, 4 Nov 2020 18:24:51 +0100 (CET) IronPort-SDR: yBPwdtmlLX45t6pCmj8gheC+YxlW0cn6aYU9hWpCet5scoTe+hknQYBSmrLK/U0oeYZoifNwwN 2HXBinEhrHDQ== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="168471318" X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="168471318" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 09:24:33 -0800 IronPort-SDR: 1crIk2eqMvUfrFlP46TiIpFLw22mAwKcFYzGjVuaTLNgwJCFtTuHUNb+8/GCzxGUb9idODPQAD nsES13MJxRkA== X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="353913623" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.228.199]) ([10.213.228.199]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 09:24:31 -0800 To: Jiawen Wu , Jian Wang Cc: dev@dpdk.org, david.marchand@redhat.com, Thomas Monjalon References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <000301d6ac0a$5be17140$13a453c0$@trustnetic.com> <6e95b6fe-d341-ac17-ff22-57e9b3a8cc2d@intel.com> <6496862.mUQds5VCSJ@thomas> From: Ferruh Yigit Message-ID: Date: Wed, 4 Nov 2020 17:24:27 +0000 MIME-Version: 1.0 In-Reply-To: <6496862.mUQds5VCSJ@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > 27/10/2020 12:37, Ferruh Yigit: >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: >>> On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: >>>> Series applied to dpdk-next-net/main, thanks. >>>> >>>> 57/58 & 58/58 has been distributed to the relevant commits while merging, >>>> please double check them in the upstream repo. >>>> >>>> 56/58 & 53/58 has been dropped while merging. >>>> 56/58 needs a new version which can be send individually, >>>> 53/58 is adding a deprecated feature, it can't go in as it is. >>>> >>>> Also can you please send a patch for the comment mentioned in 38/58? >>> >>> I will send two additional patches, one as a new version for 56/58, the other one to fix 'rte_panic()'. > > When pulling in the main branch, I see some checkpatches warnings > (in order of criticality): > Using rte_smp_[r/w]mb > Using rte_panic/rte_exit > Using compiler attribute directly > > Please could you fix them (at least first two) before the second series? > Hi Jiawen, Jian, I would like to double check if above request is clear, and if it is OK in your end? Thanks, ferruh