From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3174FA034F; Wed, 24 Feb 2021 04:37:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1A241607A0; Wed, 24 Feb 2021 04:37:38 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 0FF3E4069B; Wed, 24 Feb 2021 04:37:36 +0100 (CET) IronPort-SDR: TDveROEg/E7y9hXZpHtkf82rdlZGOwpsEOzaV4sk+lCZdX3EXu1M1Hyh9aiL9WPQ8bt2OPlPTb QsrE64+ekfdA== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="172690532" X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="172690532" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 19:37:35 -0800 IronPort-SDR: r8Hr+UkFWrr6PmYhct/FPmQ2CQFmChLcNHzljEhZdG4ch699engAR3YCcP2qex2VzxlaarToMu 514S2NLtORuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="366823467" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 23 Feb 2021 19:37:35 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 19:37:34 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 11:37:32 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.002; Wed, 24 Feb 2021 11:37:32 +0800 From: "Guo, Jia" To: "Yu, DapengX" , "Wang, Haiyue" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/e1000: remove MTU setting limitation Thread-Index: AQHXBqaA23+KzJTHzkymUA8v50SFoKpmrhxQ Date: Wed, 24 Feb 2021 03:37:32 +0000 Message-ID: References: <20210219100323.102093-1-dapengx.yu@intel.com> In-Reply-To: <20210219100323.102093-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Seems that this is align with the fixing process of the other pmds(ixgbe/tx= gbe) and it is not bad. Thanks. Acked-by: Jeff Guo > -----Original Message----- > From: Yu, DapengX > Sent: Friday, February 19, 2021 6:03 PM > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] net/e1000: remove MTU setting limitation >=20 > From: Dapeng Yu >=20 > Currently, if requested MTU is bigger than mbuf size and scattered receiv= e is > not enabled, setting MTU to that value fails. >=20 > This patch allows setting this special MTU when device is stopped, becaus= e > scattered_rx will be re-configured during next port start and driver may > enable scattered receive according new MTU value. >=20 > After this patch, driver may select different receive function automatica= lly > after MTU set, according MTU values selected. >=20 > Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > drivers/net/e1000/em_ethdev.c | 12 ++++++++---- > drivers/net/e1000/igb_ethdev.c | 12 ++++++++---- > 2 files changed, 16 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/e1000/em_ethdev.c > b/drivers/net/e1000/em_ethdev.c index 9b8c4a7de..3c6f643c1 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -1805,11 +1805,15 @@ eth_em_mtu_set(struct rte_eth_dev *dev, > uint16_t mtu) > if (mtu < RTE_ETHER_MIN_MTU || frame_size > > dev_info.max_rx_pktlen) > return -EINVAL; >=20 > - /* refuse mtu that requires the support of scattered packets when > this > - * feature has not been enabled before. */ > - if (!dev->data->scattered_rx && > - frame_size > dev->data->min_rx_buf_size - > RTE_PKTMBUF_HEADROOM) > + /* > + * If device is started, refuse mtu that requires the support of > + * scattered packets when this feature has not been enabled before. > + */ > + if (dev->data->dev_started && !dev->data->scattered_rx && > + frame_size > dev->data->min_rx_buf_size - > RTE_PKTMBUF_HEADROOM) { > + PMD_INIT_LOG(ERR, "Stop port first."); > return -EINVAL; > + } >=20 > hw =3D E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private); > rctl =3D E1000_READ_REG(hw, E1000_RCTL); diff --git > a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index > 5323504e9..1716d6b90 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -4394,11 +4394,15 @@ eth_igb_mtu_set(struct rte_eth_dev *dev, > uint16_t mtu) > frame_size > dev_info.max_rx_pktlen) > return -EINVAL; >=20 > - /* refuse mtu that requires the support of scattered packets when > this > - * feature has not been enabled before. */ > - if (!dev->data->scattered_rx && > - frame_size > dev->data->min_rx_buf_size - > RTE_PKTMBUF_HEADROOM) > + /* > + * If device is started, refuse mtu that requires the support of > + * scattered packets when this feature has not been enabled before. > + */ > + if (dev->data->dev_started && !dev->data->scattered_rx && > + frame_size > dev->data->min_rx_buf_size - > RTE_PKTMBUF_HEADROOM) { > + PMD_INIT_LOG(ERR, "Stop port first."); > return -EINVAL; > + } >=20 > rctl =3D E1000_READ_REG(hw, E1000_RCTL); >=20 > -- > 2.27.0