From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA2CDA0547; Thu, 26 Aug 2021 11:46:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C58A40140; Thu, 26 Aug 2021 11:46:21 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 32ED14013F; Thu, 26 Aug 2021 11:46:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="217710064" X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="217710064" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 02:46:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="575675171" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 26 Aug 2021 02:46:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 02:46:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 02:46:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 26 Aug 2021 02:46:17 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 26 Aug 2021 02:46:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KfKN9pfty2x0cLhzSj6OXZARv/e0JzRkjFGSYcCSFZrSSNqtNsX3QAHrVHbR9C19aEBE28geeFmx3CzuxXS/M7ZxoSSNR2ERWo68hgJllevGPYMjXmLNGq2eG1tKI9iH5lE5bXGnGkoEfJTYpkul7u4nowSDcjoEA053DJfNy6gbwfXReOmmByczDUqsEYYpeR6jDMU3EN9oNb1XL78sIVJfva0BLETHxyVHdn/8OsIY2EI14UqatnCFH0oqEegupi/qpBsYRKAwyXGWXeIu0kuDXSxkIRXI3UFVBeLxJ+6vAnlSa5gI5Do23uKO9juUoEWPFyqi1GWlENsEruGMXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BwO0OH1okQFSbRCRJU7IderEg5x4SznYrKeEJlPjEX4=; b=nTXRlJd9LfULEjLyAJRjnsWmfG5akS9PFb6PXhuvuGti7C0BXT6StsY8vHswH6yqT7XWMiSSNus38/VlSVKnlN/kx4XgPaeDeUqA6M8duQdAoMP6ILmDO+vSLRNsocSpJeL1hkXXwakLR2BmXnrYOvjZ4wjuBPM6cdG+Wa7Pw0ve+fYrBTWNr3e1YHF2CHF6Od8o5NKJVH34OGfGRc7YIvuCVyEpyRUteiWUH3uCFQT/P1ATF51syZjG9iCNSopABDkSaE1Kf9qEwM0E+8IMh5QlD5vsoSS3bQ57YzZcY2t9YBxiggJPaGvAIMxlssnO9mJWArYMTvdiDtcRIbEMfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BwO0OH1okQFSbRCRJU7IderEg5x4SznYrKeEJlPjEX4=; b=zrTegOSPAD9yWgMETdsZhtGF3xAYT/90/2dUvMbzwRj4ZmgdzpkA0ZhE9FsrF8FeE50XhPutIkujsAX0x97wsoTvueTZ52DVP/fM9MLmyX8cYGllha2BsXMVKo6Hd2fgHiOqVYdFGjbOlKbAZNzd5vUqQM0A6fCmWgPN2yE3nWc= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB4949.namprd11.prod.outlook.com (2603:10b6:510:31::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.21; Thu, 26 Aug 2021 09:46:13 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91%7]) with mapi id 15.20.4457.020; Thu, 26 Aug 2021 09:46:13 +0000 To: Ferruh Yigit , Xuan Ding , , , CC: , , "techboard@dpdk.org" , David Marchand References: <20210825112700.83810-1-xuan.ding@intel.com> <8aef3f20-8edf-7e6a-5e59-f325a2d3383a@intel.com> <886efb65-32aa-adb9-63de-9ca41d87ac4b@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 26 Aug 2021 10:46:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: <886efb65-32aa-adb9-63de-9ca41d87ac4b@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR05CA0053.eurprd05.prod.outlook.com (2603:10a6:10:2e::30) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.12] (212.17.34.161) by DB7PR05CA0053.eurprd05.prod.outlook.com (2603:10a6:10:2e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Thu, 26 Aug 2021 09:46:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f33f473-9af6-4657-556a-08d96876578f X-MS-TrafficTypeDiagnostic: PH0PR11MB4949: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rAsbVHgxpShMqTTg1b9YJMq5ko9bfWSamUbeIe7ppqGJ8GP3/jec4OMfw6FdRWp2r+o0tVY5/q+PI5SbRQ1WwUBazTeCzZGC5tDZqS07rZasvEX9JbcBto1VRbStIA2p7bJAIbSWUbUhwBIFKsjD08+SJ13P7p4Hb0H41omtCbDO3Nm9cObFCFxsG4bMT1XOv4yW4v7gY6rI0jMTNfo2UOqy2KZ9oCgwQTb5PN/DV5QxdsPzt7V9MVFgaCxMq/Bkm/6o6RfzVKIPGguOLUG8nDz9KEDxObE5fcuKdJpZ3QIZvvz7RF0CXDKybeKbQfCrImDkX3dn52YiqquzMV1NYR+htV0kh+rwzsspbSLnJ7VBGVyZmCztLie9HeHdCoW6+HOC3RHtO1vQRF7u2vENXKUbgnLiEUK8zTb1lrw+8wg/BzPTt2UgFmbnh9uAd3ZEHGlYnMRn+A2QyJkpRqoJpGZgivCGWHWdLzEW5as74PyQcd4aGWOTF3rxPkUtVmzodHSEBHqhxV1k95E1RP7T9CS+VV6pcTAjfyqWM0rT7l55vDjy3BJZVj66yKKsyqiOJUqab49eTFdhtjPmLzLh+oWAJNAKxd3wrFDtjUDsSah68TtM4E6iyGe/mVzhF4UVvOD/FSMAgj9CWWbftp0EIOz3dq6vjtzNCV1zv1CigQZSWnyjdryIlkcDiGwsTffS7Q2GT/LJZMSFSD/MohR6QFh67rKDAmJD5BfmcSC6gYz4fTIEkLs8uhbsmHcZdrv9XM+/deQw21MAFXQZyMc6mi8//g8YaATzf97Q5c7YH3JrQj0z8T6tTjzaH4jhKMPZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(366004)(39860400002)(396003)(8676002)(66476007)(31696002)(5660300002)(4326008)(66946007)(53546011)(54906003)(8936002)(956004)(2906002)(478600001)(86362001)(6666004)(2616005)(36756003)(316002)(186003)(16576012)(31686004)(26005)(110136005)(66556008)(966005)(38100700002)(6636002)(83380400001)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1hhWnBya3A2UW8wcy9sb1lWWEg3ZzI4TllkWG9OQS9waDd3cTRpbEYrQkND?= =?utf-8?B?Sjd3Q1NNWFdRSy8xVGJva0lMaFI5b1hzQURkTlhXS0ZhL2JKaDR2bHViUk1R?= =?utf-8?B?eHlVb0dEd1U3M2NLQWhDWlF4c3gwZ2ZiTFJ5dm5lR0IzTllJTUxZYko5a25U?= =?utf-8?B?cDRJSHdUSkhwdjBjRk9LTHMrSW5SSy9iYUpzYkphV01UeGNnNTJLZ1ZObU90?= =?utf-8?B?Rm9ETzh6TlVaSDdvTzhmMVNZdFpCS21wancrR1Z3eGVETG5hUHErQTVrMjE2?= =?utf-8?B?dzJHNmdvaXd5QVo2OFZuY1N3bnlPeHpEZkhRbFBJTHZrVjJEYlFFRlVpQlBy?= =?utf-8?B?ZDZBL01jZC9WZDdQU0Y0QWUrbEk3UjhPQTBqT1ZoaWJwRG44MkpRS1MxblBS?= =?utf-8?B?UEF3TzQ4MEdURWt5a3d6c1lkTG1RZE1CTXk0NWZ1U2l5bmNFYk1LODVHbVE5?= =?utf-8?B?SGNGelcxUVRMRnNJR0Z4cWorb3l6U3d0YjMzeUI5eENQQ1BCTWx6L0s5WVM3?= =?utf-8?B?NFYreFJNSjFMV3I0S3k5YmxCSVBRUmdZSmdBR1JpM2VVdURrM1h5aW5Ea3lh?= =?utf-8?B?dGxnMHF1REtYdktIUFhxcXoyUWZvWmFOSk9FQWtsb3hBWHJsQUFjL3BMRWNL?= =?utf-8?B?WDR3RDNhc29KMWJpWVllLzg1SnRqQWMzVkpQRUwyWEJGOGRyUGgrWHlBWmg4?= =?utf-8?B?WjgwTnU1dXVQMks2K2dPQlFtbWYyQWVyQXd2OTZsZnhGM0h1Mkh2ay9RaXFJ?= =?utf-8?B?OS9GZHJ3VXVBWFpqWnlJdUoydmF1MVV1Sks4WXcwRUMwZ2Y2ekZyTE85NTN4?= =?utf-8?B?UU1rK0h5MFhMdGhyUkJCNGw5NUFyYXh2aUZtblp4dkd0dGVHZi9wZ1YxRGgr?= =?utf-8?B?aE1IbjE2S3NVL3JlZndKZEI3Rmc1TDY2blFITjNZUFNDaVZtdVdHMlhKdTJh?= =?utf-8?B?dGxFZGRqbVRmM1U4SHduSW9yZ2psRzVsWGhoRlJlMWt2aVJseEpDMEZCSUti?= =?utf-8?B?SnRpTElzNG9sLzVFUVAwSVYyRDIwRnZtWjA4dmNRVzVIRStnWWlNVzdiY3RF?= =?utf-8?B?eWp1ZzhKa1hiaVptNGt6ZmNmOXRTZ3RQN2dyR2l6STRRUnQyVGRhb082RGRG?= =?utf-8?B?a3hRaHd1RThuRVBBNWEvVEJscGtQSHluQS9VM1VkRUk2U2liOGEzTDYrSmRa?= =?utf-8?B?OGNUc3YyVVRwREpUemo5aEhobk9Ub1RweWlOaXFjL2JLNUxneGpCNjVrYUUw?= =?utf-8?B?aHJxajg0R2ZPYWxQdGhocTBrOVhDbnUvYnBzZWp0NWQ1OUNVTTc3Q3d5UmJO?= =?utf-8?B?RU9TcVZVWmlTcFkxeGRPYm85NWdqTGwxdXhEd3dyeUhxQkJ1b3lVZXB0UHBN?= =?utf-8?B?Z3BETU93QllZUGVFTTc5TVV5ZnJkLy9taTMyNUxhcmc3RHQ3U0F2UVh3OUF1?= =?utf-8?B?Q3ovdnk2bTVWaWF2cWV6eXlha2dEMmpzaGw0bzlvQ3V1S3A5L0ZSNno3OHJr?= =?utf-8?B?bktiMGlEY2MwNkNLQmVLN0VidmVMUnNpVHlxYXdsVXAvUUw0UGNUWU9Qcnky?= =?utf-8?B?bnlKaTk0SzA1SVRqdVdtWVFaZExseGUwNUc4Qjk3Ykt0OXJCS1YrTU1WbSt1?= =?utf-8?B?K0YyYmt1NEJ5MTM4a0tCVEhZMmhzWkpmZ01DcHJSS052ZmtuTEhySURzek9W?= =?utf-8?B?RDRuVDRVcGphbS9SYlBxT2RmK0Q1Ri9FVmNJbUR6eWR6RWgrVmFVcU1XQkhx?= =?utf-8?Q?PChYHHrhZRJzxX5CplRpaFZX2B+/itF3ndZtRJb?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2f33f473-9af6-4657-556a-08d96876578f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 09:46:13.6406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ce863fRx71V5NO/CvIi2jnBOP/F+sFYxEt1yM8fWgTeg9GvhYA2L3vnWuATOM5O9ITEJkE1+PtB7zsvWPUp59pxp3CyXcG1OKXxs9j44sZ8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4949 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: announce change in dma mapping/unmapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Aug-21 10:29 AM, Ferruh Yigit wrote: > On 8/25/2021 12:47 PM, Burakov, Anatoly wrote: >> On 25-Aug-21 12:27 PM, Xuan Ding wrote: >>> Currently, the VFIO subsystem will compact adjacent DMA regions for the >>> purposes of saving space in the internal list of mappings. This has a >>> side effect of compacting two separate mappings that just happen to be >>> adjacent in memory. Since VFIO implementation on IA platforms also does >>> not allow partial unmapping of memory mapped for DMA, the current DPDK >>> VFIO implementation will prevent unmapping of accidentally adjacent >>> maps even though it could have been unmapped [1]. >>> >>> The proper fix for this issue is to change the VFIO DMA mapping API to >>> also include page size, and always map memory page-by-page. >>> >>> [1] https://mails.dpdk.org/archives/dev/2021-July/213493.html >>> >>> Signed-off-by: Xuan Ding >>> --- >>>   doc/guides/rel_notes/deprecation.rst | 3 +++ >>>   1 file changed, 3 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst >>> b/doc/guides/rel_notes/deprecation.rst >>> index 76a4abfd6b..272ffa993e 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -287,3 +287,6 @@ Deprecation Notices >>>     reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other >>>     information from the crypto/security operation. This field will be used to >>>     communicate events such as soft expiry with IPsec in lookaside mode. >>> + >>> +  * vfio: the functions `rte_vfio_container_dma_map` and >>> `rte_vfio_container_dma_unmap` >>> +  will be amended to include page size. This change is targeted for DPDK 21.11. >>> >> >> Acked-by: Anatoly Burakov >> > > Techboard decision was to add a new API, instead of updating existing ones, to > not break the apps using this API. > > @Xuan, @Anatoly, can you please confirm if this will solve your problem? > I don't think adding a new API is a particularly good solution. The "new" API will be almost exactly as the old one, but adding one parameter. I don't expect code duplication to be an issue, but having two API's that do the same thing seems like it's rife for potential confusion. If we add a new API, we can then either remove the old API entirely in 22.11 (effectively renaming it), or we remove the new API in 22.11 and rename it back to the old function name. I don't think neither of these is a good solution, as we risk introducing more users for the API that will later change. I think the pain of updating current software for 21.11 (while keeping compatibility with 20.11 ABI!) is going to happen regardless, and whether we decide to add a "temporary" new API or permanently rename the old one. It's (in my opinion) easier to just bite the bullet and update the function in 21.11. However, if the tech board feels like adding a new API is a good solution, then okay, but we need to flesh out roadmap a bit better. Do we rename the old API, or do we add a temporary new API? -- Thanks, Anatoly