From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pascal.mazon@6wind.com> Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 13AF569C6 for <dev@dpdk.org>; Wed, 1 Feb 2017 16:42:21 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id b65so44790847wmf.0 for <dev@dpdk.org>; Wed, 01 Feb 2017 07:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=51D3ZlHtjWf9HiRixKFq/32IQfeS0XkbvZeQ8pE294c=; b=QLSugsu/BgGQtd1s+pRv5uE67+efDznomWHvvyLldVH8eiss5QsDSIH2YttsqTRNtX 4LdbsEAzROPlOPi6HInCTiPTtK6q4WddMEaUBrp11vBmIuJ/mVSDactnL9mo0I4up2to +iXS6bDPE2hy4KPWjhU6GJGXiYrNjRxWIN2LLYaYdNT2l76/FPJ2GIgpmnfEtKop9Bo5 7gvTZNFln0TaBZkvqVZ86NAOkK67BCcGR4q+nQ653Smj1hPStx6ZzCH0ruFMFzkz1TLF v6bShpoOvm5tf7a+PxeIzJ0ak2VYVTKoVS9EKF0hx5a/7m2gTwlVbDMyONTWMvMlfrrd z/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=51D3ZlHtjWf9HiRixKFq/32IQfeS0XkbvZeQ8pE294c=; b=pxXS7J6LJbdDwmwoDVfQiQ6X2h9QxWk4H+85eEh9ssirdjmu7tmIH0pvoG6Vz69AUo YIGYkIp+7F6he482/2aJDpEifAnAd/uRCyuze+AVIOmPjG15sWT0vwhStutNGS5kxOz3 t+T50gZAd/Zs+hUTD605nBmtwDrstUexsdKt8J6yClmxzaWVEnTSiFUMxbt3UtW5Q941 Uxw/wi+2ym973yJR2Tn2LVteFjkKbBWn4bxS3F1L20Wj32n5HVxuxWk2q7g5Q+teVt7u wTxVP6Ao78RxfEX9uiKM9HHAoUtIFPROL9XZWZFJGiF7bS7Tn/hUgFeBsST+Lkmz7oIs FfCA== X-Gm-Message-State: AIkVDXJDQjy6EgiJqBZUNjXwyG0LrGzDo6xfhtljqLl0reSYeQIS6OFB+VK+oGErjOp3MYzQ X-Received: by 10.28.143.204 with SMTP id r195mr3472312wmd.32.1485963740484; Wed, 01 Feb 2017 07:42:20 -0800 (PST) Received: from [10.16.0.184] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u198sm30205397wmf.9.2017.02.01.07.42.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2017 07:42:19 -0800 (PST) To: "Wiles, Keith" <keith.wiles@intel.com> References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <abf0d961-4b2a-e1bf-0732-cc9d933f9278@intel.com> <39a46c11-66c4-d8ed-a2bc-d9421cb4afd0@6wind.com> <ec2ade7b-282c-e882-8f2d-68c4f058ce1d@intel.com> <fcde07c9-44a5-deba-fede-de929e1fff62@6wind.com> <9fa2c783-349c-e20c-0e57-0c24e67a4683@intel.com> <9C574760-33CF-4163-94D4-A0C919F4592C@intel.com> <e1b5c4ec-7609-5a40-311a-61087ad2cad9@6wind.com> <74B7FC24-638D-4A48-A02D-C80B5B4E7E2B@intel.com> <78727e66-3588-79ab-6448-9858c19e2361@6wind.com> <A3752D28-D41D-47F0-9560-2DC190138478@intel.com> <8a13261b-215c-e294-1f61-b57e5ea998eb@6wind.com> <C74A55BC-4176-4CE7-9CF5-1343E371B567@intel.com> Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org> From: Pascal Mazon <pascal.mazon@6wind.com> Message-ID: <e6ab132f-7c01-a723-eb41-670c9c20aacc@6wind.com> Date: Wed, 1 Feb 2017 16:40:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <C74A55BC-4176-4CE7-9CF5-1343E371B567@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/tap: use correct tap name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 01 Feb 2017 15:42:21 -0000 On 02/01/2017 04:25 PM, Wiles, Keith wrote: > >> On Feb 1, 2017, at 2:11 AM, Pascal Mazon <pascal.mazon@6wind.com> wrote: >> >> On 02/01/2017 12:29 AM, Wiles, Keith wrote: >>> >>>> On Jan 31, 2017, at 10:39 AM, Pascal Mazon <pascal.mazon@6wind.com> wrote: >>>> >>>> On 01/31/2017 05:06 PM, Wiles, Keith wrote:> >>>>> Looking at the changes to set the link up/down and the adding the two functions. I noticed in the stop/start routines I was set the link in DPDK and not adjusting the interface link. Should the stop/start routine also do the same thing? >>>>> >>>> >>>> Well, my patch is probably wrong. >>>> The best option would probably be to set dev->data->dev_link.link_status >>>> appropriately inside tap_link_set() only. >>>> >>>> I'm not sure it's compulsory to actually set the link UP in tap_dev_start() >>>> (respectively DOWN in tap_dev_stop()). >>>> If it is, however, it would be best done using tap_link_set() in those >>>> functions. >>> >>> I was setting the link up/down in both places in the old code. The gotta is link up/down came later (I guess) and applications only call start/stop. In the other drivers like ring the like they tend to set link in start/stop and in link up/down, which is what I patterned my driver on. >>> >>> I looked around and the only applications calling link up/down was testpmd and ip_pipeline, but all of the apps call start/stop. Even the docs to not suggest that link up/down be used it appears start/stop must set the Link state and the developer can call link up/down APIs if needed for others reasons. >>> >>> I assume the link up/down only effects the link state and the start/stop is creating/destroying resources. >>> >>> My only solution I guess is to add the link up/down code to the start/stop API. >> >> I'm not sure I understand your conclusion. >> If the apps usually call start/stop only, then definitely those functions should set the link state appropriately. >> To that effect, I think it best to just call tap_link_set() in tap_dev_start() (and similar for stopping). >> Apps with just start/stop functions would get the expected behavior, and the tap PMD would also support setting the link up/down independently, for testpmd and ip_pipeline for example. >> >> Does that sound fine? > > Yes, this was what I was trying to say and calling tap_link_set() in tap_dev_start() is the solution. Great, that looks good to me! Regards, Pascal