From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx: remove pedantic definition for icc
Date: Wed, 23 Oct 2019 21:03:10 +0100 [thread overview]
Message-ID: <e6dc37a8-38a8-6eed-32a0-e5d6059a93db@intel.com> (raw)
In-Reply-To: <1571830296-12039-1-git-send-email-rasland@mellanox.com>
On 10/23/2019 12:31 PM, Raslan Darawsheh wrote:
> Trying to compile mlx5 pmd in debug mode with icc
> will lead to compilation failures due to the fact that
> icc doesn't have support for the pragma of pedantic.
What would you think about following patch title:
net/mlx: fix icc build
And should this patch backprted?
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> v2: add commit description
> ---
> ---
> drivers/net/mlx4/Makefile | 5 ++++-
> drivers/net/mlx5/Makefile | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 25d7c75..0abdc8d 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -67,7 +67,10 @@ endif
>
> # User-defined CFLAGS.
> ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUG
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
Can use "CONFIG_RTE_TOOLCHAIN_ICC" directly for check.
> +CFLAGS += -DPEDANTIC
> +endif
> AUTO_CONFIG_CFLAGS += -Wno-pedantic
> else
> CFLAGS += -DNDEBUG -UPEDANTIC
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 04de93a..0369ee6 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -83,7 +83,10 @@ endif
>
> # User-defined CFLAGS.
> ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUGi
I guess you are a 'vim' user :)
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
> +CFLAGS += -DPEDANTIC
> +endif
> AUTO_CONFIG_CFLAGS += -Wno-pedantic
> else
> CFLAGS += -DNDEBUG -UPEDANTIC
>
next prev parent reply other threads:[~2019-10-23 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 11:31 Raslan Darawsheh
2019-10-23 14:36 ` Raslan Darawsheh
2019-10-23 20:03 ` Ferruh Yigit [this message]
2019-10-24 14:52 ` [dpdk-dev] [PATCH v3] net/mlx: fix icc build Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6dc37a8-38a8-6eed-32a0-e5d6059a93db@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).