From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E528A0C41; Thu, 30 Sep 2021 10:25:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A771410FF; Thu, 30 Sep 2021 10:25:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C43F7410F0 for ; Thu, 30 Sep 2021 10:25:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632990334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svIDzA2kKSEJ+pvJtNkXjaP/PKwmqZ1gPTxZq+2Xe30=; b=WqWAEGFOQ0p6QT7BxmV3c2IHIxL4nnuYXG0OtoP1QjBLz9G8cf9zbsE6Y3rU70COtigaBN /7wbC3OLF2uHzu1+0asMlSxGCl5WbARZBJIIXj8/fAQ1Y4yMVXw9zRFW/lBSJFv6vnuATh PZRvzynBAKkO+C4I4Xs6BU4LM/W7oWk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-422-vZUdMREBNbKJSTzCNA_Gnw-1; Thu, 30 Sep 2021 04:25:32 -0400 X-MC-Unique: vZUdMREBNbKJSTzCNA_Gnw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C2771923762; Thu, 30 Sep 2021 08:25:31 +0000 (UTC) Received: from [10.39.208.6] (unknown [10.39.208.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4079060BE5; Thu, 30 Sep 2021 08:25:15 +0000 (UTC) Message-ID: Date: Thu, 30 Sep 2021 10:25:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Olivier Matz Cc: david.marchand@redhat.com, chenbo.xia@intel.com, dev@dpdk.org, stable@dpdk.org References: <20210929201739.176306-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: revert forcing IOVA as VA mode for virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/21 23:15, Olivier Matz wrote: > Hi Maxime, > > On Wed, Sep 29, 2021 at 10:17:39PM +0200, Maxime Coquelin wrote: >> This patch removes the simplification in Virtio descriptors >> handling, where their buffer addresses are IOVAs for Virtio >> PCI devices, and VA-only for Virtio-user devices, which >> added a requirement on Virtio-user that it only supported >> IOVA as VA. >> >> This change introduced a regression for applications using >> Virtio-user and other physical PMDs that require IOVA as PA >> because they don't use an IOMMU. >> >> This patch reverts to the old behaviour, but needed to be >> reworked because of the refactoring that happened in v21.02. >> >> Fixes: 17043a2909bb ("net/virtio: force IOVA as VA mode for virtio-user") >> Cc: stable@dpdk.org >> >> Reported-by: Olivier Matz >> Signed-off-by: Maxime Coquelin > > Tested-by: Olivier Matz > > Many thanks for your quick solution on this! > You're welcome, thanks for reporting. I just notice your reply to v1, so I missed to report your Tested-by on v2 (which only has cosmetic changes). Feel free to add it. Maxime