From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FB04A0521; Tue, 3 Nov 2020 11:05:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23E56C848; Tue, 3 Nov 2020 11:05:47 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 5F689C82C for ; Tue, 3 Nov 2020 11:05:45 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id 33so7034080wrl.7 for ; Tue, 03 Nov 2020 02:05:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Gghnx0cu7dK6hKGGcrKtg50phUzuRK+P1MFBN5hWmoA=; b=rgANd0s/y3IstPNDsO9dV3hTQrSr6BrEPf0AKCw4tLaYaMKhtbrICzSAitIg3vSn5n F1npncZHN5/Az1AFzXFH8HvmFMJ06jR/YE5K2eISp37sye0OQiyBwfOxeLaG37mn2oPd LomlN2Zxby8SXzW2Sgm0CNAo/8ZPpuNDlcn+mXPyiZ3rw3uEDOUCbpNb6tHKHGzyQRtT tKoyH3BlhbaTlrf2xGcYdZbV0BTxRJDzgG/BwL3OTWpHPIapW/iE8f3RmmuvvdsZtNoL 64keDaJfHrl+Q5jLxi4VPez1h2VRST8aLwQOhIMewC1hG5Pl1NiWJOMcMJbtgqlmWj5S ryRA== X-Gm-Message-State: AOAM532qUe9kEqGZ1YC7ndJ9xGnIYr6nBw0ycDDRa5zyKsRH4/86rVJR TZZNge2Nc0OtDsoCHNCOYv0= X-Google-Smtp-Source: ABdhPJxdFKKvdO6KoEH6eppQonHDfLGDam7nbB3oTXMBrZBLIOfVjPFsdVpkwYiqGseSCJi92sDtOw== X-Received: by 2002:adf:8b15:: with SMTP id n21mr26415475wra.313.1604397945117; Tue, 03 Nov 2020 02:05:45 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g23sm2327503wmh.21.2020.11.03.02.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 02:05:44 -0800 (PST) Message-ID: From: Luca Boccassi To: Dmitry Kozlyuk , Narcisa Ana Maria Vasile Cc: dev@dpdk.org, John Alexander Date: Tue, 03 Nov 2020 10:05:43 +0000 In-Reply-To: <20201103104209.5e345a89@sovereign> References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> <20201103040512.GA21662@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20201103104209.5e345a89@sovereign> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote: > Hi Naty, >=20 > > Doesn't the 'input' option gets you original (unmodified) line endings = on checkout? > > If a file in the repo has CRLF endings, Unix devs will get it as-is (wi= th CRLF), right? >=20 > The "input" option is for Unix devs only. >=20 > > Regardless, this is the best option for Unix and since we're normalizin= g line endings for=20 > > existing files, Unix devs should get LF on checkout. > > I will send a patch to normalize netuio as well. >=20 > AFAIK, you don't need to. Whatever you settings were when committing netu= io, > it now checks out with CRLF on Windows (core.autocrlf=3Dtrue, installer > default) and with LF on Linux (core.autocrlf=3Dinput, although unset also > works). I'd wait for confirmation from Luca, though. Hi, Thank you for looking into this. Yes the netuio folder is ok as-is: $ dos2unix -id windows/netuio/netuio.vcxproj* windows/netuio/netuio.sln 0 windows/netuio/netuio.vcxproj 0 windows/netuio/netuio.vcxproj.filters 0 windows/netuio/netuio.sln The patch looks good to me, as I really need all files to be checked in with LF only as a hard requirement before I can upload to Debian/Ubuntu, so: Acked-by: Luca Boccassi Does the change also stop future check-ins of CRLF files? --=20 Kind regards, Luca Boccassi