From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 076515699 for ; Wed, 21 Sep 2016 18:16:39 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 21 Sep 2016 09:16:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,374,1470726000"; d="scan'208";a="171473755" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.98]) ([10.237.220.98]) by fmsmga004.fm.intel.com with ESMTP; 21 Sep 2016 09:16:39 -0700 To: Olivier Matz , dev@dpdk.org References: <20160920161708.9707-1-ferruh.yigit@intel.com> <3ee96eae-d94e-6046-0d29-8b7bcbe363ca@6wind.com> From: Ferruh Yigit Message-ID: Date: Wed, 21 Sep 2016 17:16:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3ee96eae-d94e-6046-0d29-8b7bcbe363ca@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 16:16:40 -0000 On 9/21/2016 4:04 PM, Olivier Matz wrote: > Hi Ferruh, > > Thanks for checking the API documentation. > Please see few comments below. > > On 09/20/2016 06:17 PM, Ferruh Yigit wrote: >> Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool") >> Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by default") >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/librte_mempool/rte_mempool.c | 4 +--- >> lib/librte_mempool/rte_mempool.h | 4 +--- >> 2 files changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c >> index df8b68c..e96d14f 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -908,9 +908,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size, >> /* >> * Create the mempool over already allocated chunk of memory. >> * That external memory buffer can consists of physically disjoint pages. >> - * Setting vaddr to NULL, makes mempool to fallback to original behaviour >> - * and allocate space for mempool and it's elements as one big chunk of >> - * physically continuos memory. >> + * Setting vaddr to NULL, makes mempool to fallback to original behaviour. > > I would replace "original behaviour" by "rte_mempool_create() behaviour". > >> */ >> struct rte_mempool * >> rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size, >> diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h >> index 0243f9e..6fc331a 100644 >> --- a/lib/librte_mempool/rte_mempool.h >> +++ b/lib/librte_mempool/rte_mempool.h >> @@ -591,8 +591,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *); >> * >> * This function uses ``memzone_reserve()`` to allocate memory. The >> * pool contains n elements of elt_size. Its size is set to n. >> - * All elements of the mempool are allocated together with the mempool header, >> - * in one physically continuous chunk of memory. > > While there, maybe we could replace ``memzone_reserve()`` by > ``rte_memzone_reserve()``. > >> * >> * @param name >> * The name of the mempool. >> @@ -748,7 +746,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size, >> * >> * The mempool is allocated and initialized, but it is not populated: no >> * memory is allocated for the mempool elements. The user has to call >> - * rte_mempool_populate_*() or to add memory chunks to the pool. Once >> + * rte_mempool_populate_*() to add memory chunks to the pool. Once >> * populated, the user may also want to initialize each object with >> * rte_mempool_obj_iter(). >> * >> Thanks for the comments, I will send a new version of the patch with suggested fixes. Thanks, ferruh