From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39910A0561; Tue, 21 Apr 2020 04:49:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 239E11D411; Tue, 21 Apr 2020 04:49:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6AD7E1D14E; Tue, 21 Apr 2020 04:49:12 +0200 (CEST) IronPort-SDR: U9d/4kxZmHuOhGEDrA+5IT97Sfz9uB/P04hnUWTpqZpz1gfMzfOigJHgcpis7sefTGCcGTTR7w o+fPTX8uI83w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 19:49:11 -0700 IronPort-SDR: E6zqYCpLTJVt8DIcasCN7B35KPwhKJQxBuzC9m2WHRb1l0wJxJ6CEWcUmw3QfJVLzy058nWhyN zpf8N/os2pXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="273378355" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 20 Apr 2020 19:49:11 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 19:49:10 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 21 Apr 2020 10:49:07 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Tue, 21 Apr 2020 10:49:07 +0800 From: "Wang, ShougangX" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset Thread-Index: AQHWETWzGbLbujYWy02kviaymaJXuqh3uxuAgAswY+A= Date: Tue, 21 Apr 2020 02:49:07 +0000 Message-ID: References: <20200413013839.71374-1-shougangx.wang@intel.com> <20200414075342.GB26847@intel.com> In-Reply-To: <20200414075342.GB26847@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaolong > -----Original Message----- > From: Ye, Xiaolong > Sent: Tuesday, April 14, 2020 3:54 PM > To: Wang, ShougangX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port res= et >=20 > Hi, Shougang >=20 > On 04/13, Shougang Wang wrote: > >It's a normal behavior to change the link status to up after resetting > >the port. So it is unnecessary to set link down before starting port, > >and changing the link state(link up/down) frequently will cause link > >speed unstable. > > > >Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") > >Cc: stable@dpdk.org > > > >Signed-off-by: Shougang Wang > >--- > > drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- > > 1 file changed, 3 deletions(-) > > > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > >b/drivers/net/ixgbe/ixgbe_ethdev.c > >index 23b3f5b0c..206358b85 100644 > >--- a/drivers/net/ixgbe/ixgbe_ethdev.c > >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c > >@@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, > void *init_params __rte_unused) > > diag =3D ixgbe_bypass_init_hw(hw); > > #else > > diag =3D ixgbe_init_hw(hw); > >- hw->mac.autotry_restart =3D false; >=20 > Why do we need this change? Seems it is not mentioned in the commit log. In c3f2fbff78cf, port was set to down by following 2 steps. 1. Setting autotry_restart flag to false to prevent NIC from linking up by = itself. 2. Calling ixgbe_dev_set_link_down(). Force to set link status to down is unnecessary operation before starting p= ort, so I revert these 2 changes in this patch. Thanks Shougang