From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EA09A034E; Wed, 19 Jan 2022 18:26:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D74634117D; Wed, 19 Jan 2022 18:26:13 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 612CE41147 for ; Wed, 19 Jan 2022 18:26:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642613171; x=1674149171; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=B2cQbz0lko9aq4S1ikHhl1+XXX2iKahiOiZXeJoy/YE=; b=aCO6YQHHB8hSS6n8HTEF1+DSOPf5Uw1RbCHahf2cIT0S8Iy3trnvwhOo Nv4u6dt2E3PZu3hRF0ALqr7/w0gsywvbSmV+cFyD+eK+1qT1hKnuPLklh OYAEocngkWIgVQnFhPAmeD5OWe+Pja/8omkKpg5Hhj1DW4mmv+mxgNcKf XuDVII7Xv/tW7ObixFVK/DsUkmT81kj4vCvJ0l2DCDMQyEoEEY6N9J1YQ 3FsbEmMtbdVJjTg+ArxgQ09R03yZ0DLSf6J7mmQCCW8de7ggipMbHZSaz 8wb22m91/y8WzlHWWsawBconNbjFziwrd5imw7OxuLYjEI3sFsu6QdxWZ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225099873" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="225099873" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 09:23:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="765010375" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 19 Jan 2022 09:22:59 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 09:22:59 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 19 Jan 2022 09:22:59 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 19 Jan 2022 09:22:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f7pVNPdRQiYIoyRihT2RAZB1MoX9Mq+UYCcS+imbqCrzGvbR3i24KRx2Cvx38GmTQN3ptwZn3Fhx+PldFfwybotlUghZFbdF8vtLRcazNsNMoqb4Ot602BqugmosGbDB63kGke55rXw6mYdg7Q8k9gze6OEfSKBp3CYSl7MUwAHy1VvOPxsDFv/EJjO274VdYrQ0PbDtmnlavnePM3E6rQ9Gqf1/oFX1G34u25+x5Fg6wY0XF1akOhnDvXX0f90sPf2RWNP5npL07G/6xP0kp3070XPa3AdRcgh5gJN96fk/kcyAiYvUu4wEYL8HI1FEv8DnjdF1xd9XAX+J5foQkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AeA05wmePcxeJQ78+tdatyZH+k0Y5sQ7rIzWY0D21Lw=; b=Hj3G9o+KBkNG4DpKeNDiY/HxthqLXqmhbczdQCjqBHM4YJwr5L4VY08Jwqki4L9d8gTmld1QjK4g4mcktoxM0JegT6fccz9XgOhC3oL6bKRfJv1v4KbYLz2ov2ghtPi1LtVSEGxWJ4wcvSDwuOUSp/NNdyW9V/42PXGPErFKMJw/l/c6RtI5S9bHQovQmwX6NxYFSsPUxxqBrNaq+UF0zNXlhx/efs/tQCPuNs8U2RGcpKZEQ7QZii9Jxg7R8mLt35Q+2JNEHqIr99GQm/Ym0m78BYMx4uSe4Y22QQL5r4VvgJLDQ0lYKzO2em3ML75O4dn1VLAFMCZ0YPjDjxTsiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB5397.namprd11.prod.outlook.com (2603:10b6:208:308::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Wed, 19 Jan 2022 17:22:57 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.008; Wed, 19 Jan 2022 17:22:57 +0000 Message-ID: Date: Wed, 19 Jan 2022 17:22:51 +0000 Content-Language: en-US To: Yanling Song , CC: , , , , References: From: Ferruh Yigit Subject: Re: [PATCH v6 05/26] net/spnic: add mgmt module X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ebd2d79-6bd0-4808-c903-08d9db7055ec X-MS-TrafficTypeDiagnostic: BL1PR11MB5397:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:341; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Huz5ZxVU7o31uNghbZap7MFTN5On1H+LHCOH+d04tydcpB/Sbnl5XZ+nDTvHOsURllFELmkOoTyZ0/pBYNWy0DS3PRdWtkwQtI28hdalJVlSi6uM/9jKzq2a64ET6IpWydtJYA7NRV0bNryw5Q2LxoDRHv1saKQwZLGY29np8g1MMdioLieHkFmaN4w8t7xD12LeOOr9oaoIg5QhTLFCxtRqv7xuA/Ghmwoh47xAicnesTetRQA6wg1LctIe8BWny4upi2KtY0Z02AnYJ9AMXFWAA7XfuQ6YhfbxbpkSsxRfA69JK2iqLvA/Y8+FiE7dJ3uooGTGc5W2b7XpZIayJmwZuj7HQ2bxgtiUlRk2ErXkt5UGRyrtsAqnxhYoY8LE/fgJu1t8ZDiq31BYqU3IC7OjiCICT1APRP+rpPr8c3rZxu6G3FiVNNxO3JN1k0zszpLIqUG98YLkh4ebb4w4wr08B8yIWmMq+yXLVCVXU7BnMdoWIo53VyHXhEDfvKd125M/yCdmSoqr1AEp48Q+JhLfZf4SmAwMRGefQGgbSYDQe/7ivKwoEuSON5/0sM/gMVh/fIDxR84VegJ419FtcuqhCXigSkcWlZ/S9X6WvztnfJ9co3OigkWXGhDqyrcU2iVilXH6RkBDrPWXmixDZtuJ5XaJ/1nMWboHve37huFZc0NGprG1EJ3X8vbVrGnEZoZbpSOfzvkiNr3TTRAX3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(508600001)(66946007)(66556008)(4326008)(2906002)(66476007)(8936002)(186003)(4744005)(31696002)(5660300002)(6486002)(86362001)(6666004)(26005)(36756003)(82960400001)(2616005)(44832011)(6512007)(38100700002)(6506007)(8676002)(31686004)(53546011)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXdteFJWK1JDRUg1RTZCMnYyZjl2QWo0bEZhZ0ZmVWM5ZnpYTksrN0gycUtu?= =?utf-8?B?Nnd2bXVvb2hHRFpxQXMwZk1hUWpuZE5ubUF5ZnlLczd4ZUdPMW0xTVMzYlRy?= =?utf-8?B?eks3MHhISDNxZkljUFBOb281ajgyMGNLQkF6TjdCTTFWRkVEdVBRNGlPVys2?= =?utf-8?B?U0ZYRnhFdTgwZkhPZm1lM1NVSkNMWUJjajU4K2RCNjZXbWZCN0N1NWZ5RUwy?= =?utf-8?B?Yk9rc1JSSU9aZnUwWkd6Y3A4Q3cxdDNzRDNCV01ua3ZSR0d5amUyQ2FpblVw?= =?utf-8?B?dVVWMlBtb3JqdFNHR0hETmdBMkVycVRkcGdEU3BGWnk1NUNwVi9vNjJ3QTRS?= =?utf-8?B?OUdROTlTdWE3Y0JsZktFK1B3Q0kxYldHT1htaU9xZE0xYzdtQ2p4RHVuSDR4?= =?utf-8?B?Q0pVTHdaeTkvVFFWemU2eFJSWFZxRFRsZjFacjJ6a2RYZDFVelBrUUVTL28v?= =?utf-8?B?OHhmeFo0NnVzRmdXUjF3eGkwWXFoZ0RrVDluc1VTR29tR3E4ZjBRb3MvQ3Vs?= =?utf-8?B?eGx0UUlIYmhPaFQzdjcyMGhUQ1ArTHdiMVpYMXFVbVkzVmdZaUlMaDc0YzRy?= =?utf-8?B?NXlKL0JEeU1BWGdLS2Z0YUd5Ui9Qa1IwZ282TktOQXdTbVc2UXhGQ2d3N0lp?= =?utf-8?B?cnJIUFhaT0FYS2N3MnhTN09qQ3RRYXpHT3cxOE9Cc0FRak9YT2R3RDF1emFX?= =?utf-8?B?N1k3bmRReDlnbWpSTmc3Nmh6SHZ5ODh1YVBIdHZLZ3lDWDVFcUIvK1V4Rzho?= =?utf-8?B?YXZpaTllZVN2Z3VubmovajRzTGhWdFhVdmg1czRmb0RTWEpYU1h4MTNTMHVv?= =?utf-8?B?SlFkY0c4dFNtMzl5a3pEN1JTK1RIcGNJY09nQ0N5eVRzSThsRFQ2UTk1NnVN?= =?utf-8?B?M3RRUGNsSzc0MmoxNUdkSUVqdGtJS0tsVlpzczYvTWV3U0djWXJlbXhMMDBM?= =?utf-8?B?OVhSek9xNnkrRS9EUzNWQ0FJeFBtN2U5bXpQaUh3QlhZTUpMY2VJV3J1eGtz?= =?utf-8?B?M2tDcVVVd1VBNlBZSkNRcGJ2eVduTk40MktLUjFyc0s5VmJmR0l0eTZyWGhn?= =?utf-8?B?Um1XdnBiRjJlcis2a21SbDkzL0FucjI3RHRyQVZ2clRvdUIwMUkzNU4xQVEv?= =?utf-8?B?R3ZRRmVLb0o2VzM1Wkx3V1E3SzUzdUk2czhNNC8yczhDUURNcEN1K0dRNTFP?= =?utf-8?B?RXpzdHJFaDhqanExOWw2bU13VzlORCs2dUdLZng5MjJvNG4xWExrL05hRUkz?= =?utf-8?B?Uk4wdC9Ubk56SFNEZzhqRno0MzIzY3NuSmxOc3hVMlZSTTc2QmhnNWVJWHVM?= =?utf-8?B?VlpWTWhWY2tra1k4dG1PYmNoYzlPNzBJS3k1bkJPaUgrK2cxWnA5ZDRQNVBH?= =?utf-8?B?RnE1eURqaHM3Y29wUjIraDRKRnFnc0Nkeldmd0J3RG9pQ0U2M1YzNkxTKzBv?= =?utf-8?B?c2JaOVd1bDJaMzg5MEdMRzJ6VE5UVmI3YmhrTGtzL0Z4dHo2elZZU1YrVG5q?= =?utf-8?B?MFBnTHM0SlRjK2twMXVMYjhDK3FZbXVraHhrZUsrMHJZNis5cE5uU3YvdUVY?= =?utf-8?B?aFRwZTRWZ3gxSnlvNFppRVlydG10cVpYaGZPQ253eFhtQlRLSzZta2c2NU53?= =?utf-8?B?b1ZkcEFManpvWXFuQndwL0d5RWFnU1BDTm5oMWg3bUVKTHBaWGpZN0dwdXpr?= =?utf-8?B?bDhBUXRURzVDcUNNMndkTGd1QXhRU1U4VzZ2UEFDRWdEZU5DcUE5L0FkMVVu?= =?utf-8?B?bUtvQ01hNUppUVJ3V0FoSkRLeDVhT0VkQlVJWnVVcU5VS0czTDYrVzdlc28z?= =?utf-8?B?WE1kTkVnankvalJ5QVhHOWFGMHhneEZhR0dobEdUdXcyUkFkbisxRXNJYVcr?= =?utf-8?B?RnNnRmk3Z21jaFlDRllTSTB3RlJSL1ZDUXNZVTZTd0FCaE44RHRQWjd4aTN5?= =?utf-8?B?OGsyVm5mcXBBZU5ZTmNoMnFKYk9iWHVjYVovbFBQYmFGaTVGcDlBS2hEeDAy?= =?utf-8?B?b0w0WWNRRDBFSzEyeUdhbVY1WERCQWpxQmFzOWhXMmc0Q3lxaElMSXFaOXFl?= =?utf-8?B?UTJoQld4N3BwenF0MTRSM3RDSXRDWXBwTEdCVmNDcDVmTG0xaUNiU2pzN2l1?= =?utf-8?B?cmI2eDlsMk9CK0dYRkVNUWV2WENweURlQkFseFlSRkpsTmxPTWRqU00vQmFs?= =?utf-8?Q?IAeTPlk+dpOW9FnxlvEJKjE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8ebd2d79-6bd0-4808-c903-08d9db7055ec X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 17:22:57.6549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sB3uisyYR8D5Rc0C00k/UeeXx8pRABnLoHffqv7jogBNPGxsfsq8LLY7L0F/me4KS9QQ8MNJdhdQfp3CtT1ovg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5397 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/30/2021 6:08 AM, Yanling Song wrote: > Mgmt module manage the message gerenated from the hardware. > This patch implements mgmt module initialization, related event > processing and message command definition. > > Signed-off-by: Yanling Song <...> > +static void spnic_get_port_link_info(u8 link_state, struct rte_eth_link *link) > +{ > + if (!link_state) { > + link->link_status = ETH_LINK_DOWN; > + link->link_speed = ETH_SPEED_NUM_NONE; > + link->link_duplex = ETH_LINK_HALF_DUPLEX; > + link->link_autoneg = ETH_LINK_FIXED; > + } The driver is using deprecated macros. If you can rebase on top of latest next-net, you will get the warnings. Since it is hard to continue with bunch of build errors, I will wait for next version and can continue the reviews with it.