From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB585A00C5; Tue, 15 Feb 2022 16:52:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB96F410F7; Tue, 15 Feb 2022 16:52:56 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 2661C410F3 for ; Tue, 15 Feb 2022 16:52:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644940375; x=1676476375; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=qwLRSKZkZSrrbcNqkIOwCPJuFmwZM9MzgTGKv+Tmsog=; b=TK8BdTDmpLJznGIS4W2cwkEww37TQKL1kYZoHNb0W0ZjmD5QMUnYSlYU 1UeBDZy060VVS0G1NZUbXO0jTzy19QAhCaFTSIzy8yUYZfAsxqWcl991P yf9I02fm2SHMph1IhYYOUZZY9vYyXOtlySVxBhtI8p68o02XfqFoOuV6c yhGlgNjfn5Oorss5y9LHJqeILxXYVxO6u2dM36ozS4ht9GgJe0d9+yYag ogTpv2Db4Ua5n7gkyBt0PoCxm/e4+Pkp3vASZRMRNbn265K02NOGo6BG4 V5jqN3UuVT4ofg4H8uXEqn80/ikcxIeRYtpFsIzCijONB5jrFs92DByii w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="311118510" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="311118510" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 07:52:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="544354654" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 15 Feb 2022 07:52:53 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 07:52:52 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 07:52:51 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 07:52:51 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 07:52:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOhj/ptw3TFWahWikSFGyqUVL0PRbjEaqFNpqvgRl5R/ZzDT6rsf2eJ4Nic2CCbSzxB7Xx7p16dCzCERdV9KlwvuohaZVBdgx/36efA+tbZhpRqVZJTc+CQc55NGE7N0ItixjMhZ98RcC0rS49OX8WRoHe9sct9STnYpKQhyorycGZZz/j37XBN856wPP9SVwCfC3LzI/k3ILsfcCsgVAdgPJZQfofGiY//T32R7FEtXRUhJ1WSxUsIsifWboDuo9kqYHxhj2XnBzxZe/wPyKjJg21NOowWnUlGCXlm/uiyR/+WGIZNFcA215STRs9E+rT4zMHWTWBzUaCjc+5I86Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=colWulZA9XRuGNGX8ZFFaI0asFgHR0438ycgQeuF98Y=; b=BqcMGYLa5rqZpD7JCbfLnlcyLmxKRs/RIcT8/ZSXHvqLSEHPKtOhi46v88EO0USsaN9Q6pI17qL8lj04pEiIk87rOpQkVnfXWmfuMZ264ztKAkdm0kHXLWBWri4Ao8sEr8/IHPHw9O9kfGXkXoSCL7q8JUmNe0QHVry+Ybw8scP2QLR2lTJUoi7W+E0TRA2BdM4qZEOCHppW91wwRHClc+f7xgcncYoniaB3XAxNie3qTI4Oc5eSmqZdB1aW1ezWMaYyTuhCrw+LTRejnWEQAMdLjNggu/F38LK8u5H9dV3hAHuV+TwySmdJJgCFmc+YHZfU5riiZ01iyYfblU0AhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by BL0PR11MB2996.namprd11.prod.outlook.com (2603:10b6:208:76::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Tue, 15 Feb 2022 15:52:50 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657%3]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022 15:52:50 +0000 Message-ID: Date: Tue, 15 Feb 2022 15:52:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.6.0 Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size Content-Language: en-GB To: Ferruh Yigit , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> <61a3edb7-3d5c-1df8-52bd-26f4a951ad5b@intel.com> <72602dd6-b020-13cd-df70-13a06a57d9a7@intel.com> From: "Nicolau, Radu" In-Reply-To: <72602dd6-b020-13cd-df70-13a06a57d9a7@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0311.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::35) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0cfca521-a9b1-47c5-b36a-08d9f09b37b1 X-MS-TrafficTypeDiagnostic: BL0PR11MB2996:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:586; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xl2HXLlK4RiGynJj1HZi9HtqMfu+NZHApEtES6oeE/cIOiEBvWLN/UJj5Ux19OyoKJUKPcBOMa/CLh5F4TC7EeOi9cUvQGjYopRPor8zBFnlj/mVLlsLvi4e3C+/+341Nmupm17JGIIvQ0ltjAX5y8xof2BzhKLF5LSi+UUGOWKYTrszwYcg7kf+b2QLJHtz2qPi9NQQzEcASNUKuFAs8R1muW9FOxbmfJ9I1UO8Sk9NoRka9HfJHoZZKpdoEnLJXR7BwUd6f6KdvfzJ2wO3gcz69hRR8DqyVmtTcJS6IracIk0efAyzCHf9GM4N7DWTFk6DUUWS4F6FqUWUldkM1/OSa6eGh0jeoALcMRQGkNIseZY0SwDFFi/bxdpXcFYDt0NdOVbwLD9103B3zl2tyagki99H2DvDxF0FfOQNTuTAcIzIy6nVNNIDtbjKYVV0kVzky8Lfpn+MLHO6YwM+yVjVSMyJqEchl/+qxI3xlHCW73gtYVIVZLVeU+Y+TjSDIEizp8yQlaBvuPUkVYMfnQB1mhbgkvGMS3gbogyYyoQDEQtFAPs7MOn3RzL0kN0nwzTNlt/xbVArR82x5RW7by7H0YPiZQh1e0P3TJIRWyMPBh4tEGATNtYJKSAgK/JIj3XgboMBoBrykQhY2mM6422+s30TYxhlTLRK0I4WpT3UEoTpEsl9NyvsPG5ggjd2EiF7lRIbgUSNjB/q/SbYv9VWCoh0tlUoG2Y0km6Bh2BuCn9m8FWaebnwDCu9uD6E X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(508600001)(53546011)(82960400001)(2616005)(55236004)(26005)(6666004)(6512007)(6506007)(8936002)(31686004)(316002)(31696002)(6636002)(5660300002)(6486002)(8676002)(4326008)(54906003)(38100700002)(2906002)(66946007)(66556008)(110136005)(86362001)(36756003)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YndQcFBGTkgxMmtBMjRDT1ZqcXp5dklGWmt6Z1UvL3lvQTFXeHdOQmg1aXZJ?= =?utf-8?B?cXUrTFFYWWNDUHcvajcycVlQWnljZ0dqbXVqSDlMWlBOUnNpSGo1WE1lSlBk?= =?utf-8?B?MVJDTm50WmlOQmo0N3RlTjF2WnBTdjFxRVJmTmpmd3JvZmIwU29qYWF1TXEz?= =?utf-8?B?SmZPdmI3MytZU3NIZ3d4U0JYNlAwRWRwbHZYY1lsYjlYN2xhNzQ2Sld5QVU2?= =?utf-8?B?S0lGL0FkUk82TUgzUVk3bkx0V2dhTXBWaStBcDBUYitrUGsrcnErSFlNeVlG?= =?utf-8?B?WXV1L29YWmVNYXhOVVB4eVdWT0hRblRCMmprd1I1MzA3TURSOTcyWGJTa2Vy?= =?utf-8?B?L0Z1N3prWENHdVZwV1pkQmVzbjg4RXp3WmdXUjkvcnYrR0hRL0dqNUduK3VY?= =?utf-8?B?SUF1cnc0eWsrMXc1cHdMTDJJTTI4ZklYb3plajZKOFoxaytHNkoxOFB3Y2Ur?= =?utf-8?B?bGdKTjBPY0xPcWhLb0J6VTFVN3liQXB3WHJ0aGtJb0NwaWtRdmpQbWlOWUtU?= =?utf-8?B?NDB2RExsS2cway9GeEdQTENJMXM0UVphVFJKMUFuM1BDWWRzMUh3V1lrWmNR?= =?utf-8?B?VDczTXBPZnZyalYzT1M2VCtNcWRrU0QwZXF4Ny8yaUFoMDQzTk9mSVIvUDdP?= =?utf-8?B?NnJvL05SUC9kVTZNemhQNlIyRW9TeXBLTDY0TWlPVWdoZWhlcGVTZzI0YmZv?= =?utf-8?B?QkJCZnFzYVNBaHBiVloyRkphMXdkMkN6OXdjWUQ5T0hVY0Zac0t5WE1nWnpB?= =?utf-8?B?b0xJRDBUZWhQbG05eGtrM0V5eWNaRXFlUHFEUnpsa0xuMjU1eTFQWElLRjB2?= =?utf-8?B?NXUzZXQ1TVdZeE81NExNT0hDbFI3dGo4R0dQMk1mdnFnd3NWRWJiaHNDMmhU?= =?utf-8?B?MG9BeURZMWNzY1h0VC9EU213Z2Q5aitRWU5zTzZ2QVM0WnhCUXhISDB1YnRJ?= =?utf-8?B?MkhYOGE2VWNMSjVUNDNHQXkyNU5aakdGMHNjcDNaeHVuWUJ1WkVTWVorL0pW?= =?utf-8?B?RUtkSURhV1lyYVFxSUFkS1pKVU9Bb2pLaDd4dU91SUMvL0pmaG1LOWxmbGhR?= =?utf-8?B?UVZKMUtnS3hTZlpuTmlYQkNIVzlkcmN0TnIwY29FTFhsLzdlWlJRZDZ0Tnd1?= =?utf-8?B?anlOQmdZVk5MOWJ1TTg4ajFWR2ZDNGFTVTk1dm5WVTkrSlUyQTdqVG9QQisw?= =?utf-8?B?a0lueFRYN2NWN0hwdjE3MHpWUDhheTF0d2RJK3JsUUlRNXVia05SV2pwSU14?= =?utf-8?B?RUhhbGFMMy9QVUFMVGMwb0tKdmhZWDNnTHVrNGhhTGtia2VmRlRudlZhVVQ4?= =?utf-8?B?NVlOaU1ZM0NvYTRlNXRwTmJObDBXUEVTdzlvdDlwY1E0N0dIN3p1S29FRDl0?= =?utf-8?B?Z1RjK0djV2w0emJNKzFvUEt4V2pDYnkwL3dmOWlBaGMyNXRBVGVFN0k2Nkxy?= =?utf-8?B?ckcvYi9kemtJNDRWZ2Q4c3RLcVEwSEV1KzdUYXEyaFl2ZHRneUtHRk1nQ1R2?= =?utf-8?B?SFozNFQ0UlE4LzY5cHB2UkpDc3dCN1hkRExNSzBONjQ4TUU1WlJXRG9QaGVQ?= =?utf-8?B?ZUNNRXpmNUVFTHowakF0Ky9PdVlNNnBFMGxlZit3bjl1cHU1WnV3RmpOOEpI?= =?utf-8?B?VWliOW1PenBvLzVkZklqMHdiQnpLTGgrVG5TeUh6TWVwam94b0tGQ0QraG5w?= =?utf-8?B?cnpsY2VrU1FLSlU2K0I1cUVGd1dNTGk5MUNDRkxOdE9CNDY5c1hzSW91MTMw?= =?utf-8?B?WnFId0dEZ3lSZ0dzTFZod2FkR3paUGJDS3Q3V2srcDI5MXo5c2lCKzFHUmww?= =?utf-8?B?dG5vakd3bTNZMVVrUE9PQXV4bWJCTjQzbHBvRVFVNi9kSmpwL1ZWRGp3dk5y?= =?utf-8?B?NHZxd3Bpb0xFbWdpTldsQ3NrM05ndkgrMVRhMEJvMFBhR2doU2VLb3JrcGEv?= =?utf-8?B?R3UxVTdxRE5kOVM5OUY2OGVjS2s0ZTh3MVpDVEtRSlUxSnBRN0o5dmZWWnJo?= =?utf-8?B?bmxORTE3ZWwya2lXUlMwcTBIdWtDUXMwV3lGYTJBazQvSlh2SWRmSklNWUtW?= =?utf-8?B?YmxGM2ZrWkFlaExXZVdQM2w5TEtDOEhkQTlWSDFSZFZaRStQRE4yVmdlSDhT?= =?utf-8?B?TFR1dDdKRndoWlpXU3BEcmZxYlhjNk1ubWVqNVdPTFFDcHFpK3FkWWlWRnJ4?= =?utf-8?Q?7HbzdjJdz4CeYarsZvWAMVY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0cfca521-a9b1-47c5-b36a-08d9f09b37b1 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:52:49.8531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5A7O+FLpRWhNBPO/AI8i9mu7zyPozaDpasHbHnewc79wtht7U+cSxF8lyssoAFme9vPWQSkj6pY/u1VbopiHnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2996 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 12:48 PM, Ferruh Yigit wrote: > On 2/15/2022 12:44 PM, Ferruh Yigit wrote: >> On 2/15/2022 12:30 PM, Nicolau, Radu wrote: >>> >>> On 2/15/2022 11:19 AM, Ferruh Yigit wrote: >>>> On 2/15/2022 10:47 AM, Nicolau, Radu wrote: >>>>> >>>>> On 2/15/2022 10:06 AM, Ferruh Yigit wrote: >>>>>> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>>>>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect >>>>>>> buffer size >>>>>>> being computed for TSO packets. >>>>>>> >>>>>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload >>>>>>> condition") >>>>>>> >>>>>> >>>>>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >>>>>> are we having the initial issue back when this patch reverted? >>>>>> Is there a fix for that initial issue? >>>>> The initial issue was around a very specific usecase - IPsec >>>>> transport mode TSO and it is very likely back with this revert. >>>>> But it's a much less severe impact than general traffic TSO. >>>> >>>> Got it, so this revert brings back an issue, should >>>> we document this in the commit log of this patch? >>>> Plus should we create a Bugzilla etc to record the >>>> introduced issue? >>> >>> I plan to follow up with a fix shortly. >>> > > Or does it make sense to combine that fix with this patch? > I sent a v2 that does this. Sorry all for the mess :(