From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alfredo Cardigliano <cardigliano@ntop.org>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter
Date: Thu, 12 Dec 2019 12:42:55 +0000 [thread overview]
Message-ID: <e735bc66-b6b9-59a5-cc74-46618e04dfb0@intel.com> (raw)
In-Reply-To: <F0738AC2-C6F9-4C2F-A37C-C81CE73E5B62@ntop.org>
On 12/12/2019 12:04 PM, Alfredo Cardigliano wrote:
>
>
>> On 10 Dec 2019, at 19:50, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote:
>>> Register the Pensando ionic PMD (net_ionic) and define initial probe
>>> and remove callbacks with adapter initialization.
>>>
>>> Signed-off-by: Alfredo Cardigliano <cardigliano@ntop.org>
>>> Reviewed-by: Shannon Nelson <snelson@pensando.io>
>>
>> <...>
>>
>>> +/*
>>> + * There is no room in struct rte_pci_driver to keep a reference
>>> + * to the adapter, using a static list for the time being.
>>> + */
>>> +static LIST_HEAD(ionic_pci_adapters_list, ionic_adapter) ionic_pci_adapters =
>>> + LIST_HEAD_INITIALIZER(ionic_pci_adapters);
>>> +static rte_spinlock_t ionic_pci_adapters_lock = RTE_SPINLOCK_INITIALIZER;
>>
>> As described in previous version of the patchset, it is possible to remove the
>> PMD maintained list of adapters, is there any benefit to keep it?
>
> I will try to implement the approach you recommended. If that looks messy,
> is it a problem to keep this static list?
>
No problem, that looks reasonable. I believe it will work without being messy,
please check octeontx PMD [1], it does something similar, but if it turns out to
be messy please feel free to keep the static list.
[1]
http://lxr.dpdk.org/dpdk/v19.11/source/drivers/net/octeontx/octeontx_ethdev.c#L1146
next prev parent reply other threads:[~2019-12-12 12:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:46 [dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton Alfredo Cardigliano
2019-12-10 18:48 ` Ferruh Yigit
2019-12-12 12:01 ` Alfredo Cardigliano
2019-12-12 12:39 ` Ferruh Yigit
2019-12-12 14:09 ` Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano
2019-12-10 18:48 ` Ferruh Yigit
2019-12-13 10:25 ` Hemant Agrawal
2019-12-17 19:46 ` Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 03/17] net/ionic: add log Alfredo Cardigliano
2019-12-10 18:49 ` Ferruh Yigit
2019-12-13 10:22 ` Hemant Agrawal
2019-12-10 18:49 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano
2019-12-10 18:50 ` Ferruh Yigit
2019-12-12 12:04 ` Alfredo Cardigliano
2019-12-12 12:42 ` Ferruh Yigit [this message]
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 05/17] net/ionic: add port management commands Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 06/17] net/ionic: add basic lif support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 07/17] net/ionic: add doorbells Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 08/17] net/ionic: add adminq support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 09/17] net/ionic: add notifyq support Alfredo Cardigliano
2019-12-10 18:53 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 10/17] net/ionic: add basic port operations Alfredo Cardigliano
2019-12-10 18:50 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 11/17] net/ionic: add RX filters support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 12/17] net/ionic: add Flow Control support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 13/17] net/ionic: add RX and TX handling Alfredo Cardigliano
2019-12-10 18:51 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 14/17] net/ionic: add RSS support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 15/17] net/ionic: add stats Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 16/17] net/ionic: add TX checksum support Alfredo Cardigliano
2019-12-10 18:52 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 17/17] net/ionic: read fw version Alfredo Cardigliano
2019-12-10 18:57 ` [dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e735bc66-b6b9-59a5-cc74-46618e04dfb0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).