From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 744DFA0471 for ; Thu, 20 Jun 2019 11:58:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 492781D0D6; Thu, 20 Jun 2019 11:58:24 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3DE3B1D0D0; Thu, 20 Jun 2019 11:58:22 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73701A3B65; Thu, 20 Jun 2019 09:58:21 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95EBE60FAB; Thu, 20 Jun 2019 09:58:17 +0000 (UTC) To: Andrew Rybchenko , Tiwei Bie , Zhihong Wang Cc: dev@dpdk.org, Dilshod Urazov , stable@dpdk.org References: <1559587805-1637-1-git-send-email-arybchenko@solarflare.com> <1560771098-20375-1-git-send-email-arybchenko@solarflare.com> From: Maxime Coquelin Message-ID: Date: Thu, 20 Jun 2019 11:58:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1560771098-20375-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 20 Jun 2019 09:58:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/virtio: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/17/19 1:31 PM, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Virtio requires pseudo-header checksum in TCP/UDP checksum to do > offload, but it was lost when Tx prepare is introduced. Also > rte_validate_tx_offload() should be used to validate Tx offloads. > > Also it is incorrect to do virtio_tso_fix_cksum() after prepend > to mbuf without taking prepended size into account, since layer 2/3/4 > lengths provide incorrect offsets after prepend. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc:stable@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > drivers/net/virtio/virtio_ethdev.h | 3 +++ > drivers/net/virtio/virtio_rxtx.c | 32 +++++++++++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) Applied to dpdk-next-virtio/master. Thanks, Maxime