From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EEB4437A2 for ; Fri, 8 Dec 2017 00:52:46 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 15:52:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,375,1508828400"; d="scan'208";a="10039358" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.165]) ([10.241.225.165]) by FMSMGA003.fm.intel.com with ESMTP; 07 Dec 2017 15:52:45 -0800 To: Adrien Mazarguil , Andrew Rybchenko Cc: dev@dpdk.org, Jingjing Wu , Roman Zhukov References: <1511166121-743-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-1-git-send-email-arybchenko@solarflare.com> <1512124996-13388-2-git-send-email-arybchenko@solarflare.com> <20171204140320.GE4062@6wind.com> From: Ferruh Yigit Message-ID: Date: Thu, 7 Dec 2017 15:52:44 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171204140320.GE4062@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 23:52:47 -0000 On 12/4/2017 6:03 AM, Adrien Mazarguil wrote: > On Fri, Dec 01, 2017 at 10:43:15AM +0000, Andrew Rybchenko wrote: >> From: Roman Zhukov >> >> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. >> Add default mask for the item. >> >> Signed-off-by: Roman Zhukov >> Signed-off-by: Andrew Rybchenko > > Just one remaining nit, please see below. While you could address it through > a subsequent patch, you might as well send v3 directly to make things easier > for Ferruh. > > Otherwise it's all good, thanks. May I take this as (for series): Acked-by: Adrien Mazarguil > >> --- >> doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ >> lib/librte_ether/rte_flow.c | 1 + >> lib/librte_ether/rte_flow.h | 30 ++++++++++++++++++++++++++++++ >> 3 files changed, 43 insertions(+) >> >> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst >> index d158be5..5b8f9c5 100644 >> --- a/doc/guides/prog_guide/rte_flow.rst >> +++ b/doc/guides/prog_guide/rte_flow.rst >> @@ -980,6 +980,18 @@ Matches an ESP header. >> - ``hdr``: ESP header definition (``rte_esp.h``). >> - Default ``mask`` matches SPI only. >> >> +Item: ``GENEVE`` >> +^^^^^^^^^^^^^^^ > > Missing "^" under title, this may trigger a warning during documentation > generation. I can add that one missing '^' while applying, no patch required.