From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 544A4A00C2; Fri, 14 Oct 2022 11:29:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBF32410F2; Fri, 14 Oct 2022 11:29:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1B8BC410F1 for ; Fri, 14 Oct 2022 11:29:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665739768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aVJSSKMmuncjG/u9DwExAQYvBjloZf8Ej+X9A/XsZWw=; b=LpYH5bnDHckV41v2iB44HHy3se6GNwfjosFr0BMp7sAxyBg87R/iLMeILJU5YHJIjhnkCu Y3/rAVIMjnSZqlAF+uN+fDjCr0+2effGiwRE4/pD8Ts7RQvSeCGO8yyKhkap7lqh7IIYAo gsTE5zpCBTPktJ/9TfR52IQFhwQAp1Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-nQ0NkgPFMCS38u95dnX8PA-1; Fri, 14 Oct 2022 05:29:24 -0400 X-MC-Unique: nQ0NkgPFMCS38u95dnX8PA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0CCB229AA3BD; Fri, 14 Oct 2022 09:29:24 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16D572144B2D; Fri, 14 Oct 2022 09:29:21 +0000 (UTC) Message-ID: Date: Fri, 14 Oct 2022 11:29:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 03/30] baseband/acc100: memory leak fix To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20221012025346.204394-1-hernan.vargas@intel.com> <20221012025346.204394-4-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20221012025346.204394-4-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/12/22 04:53, Hernan Vargas wrote: > Move check for undefined device before allocating queue data structure. > > Coverity issue: 375803, 375813, 375819, 375827, 375831 > Fixes: 060e7672930 ("baseband/acc100: add queue configuration") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas No new line here. > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/rte_acc100_pmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index b436bd9078..436af977e4 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -662,6 +662,10 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > struct acc_queue *q; > int16_t q_idx; > > + if (d == NULL) { > + rte_bbdev_log(ERR, "Undefined device"); > + return -ENODEV; > + } > /* Allocate the queue data structure. */ > q = rte_zmalloc_socket(dev->device->driver->name, sizeof(*q), > RTE_CACHE_LINE_SIZE, conf->socket); > @@ -669,10 +673,6 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > rte_bbdev_log(ERR, "Failed to allocate queue memory"); > return -ENOMEM; > } > - if (d == NULL) { > - rte_bbdev_log(ERR, "Undefined device"); > - return -ENODEV; > - } > > q->d = d; > q->ring_addr = RTE_PTR_ADD(d->sw_rings, (d->sw_ring_size * queue_id));